Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp362555lqr; Wed, 5 Jun 2024 08:12:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVun0Y1dQmokSur+zwCyddHs3r7cMIi5Mav3LJPIhj8UiuzId31w/dfIAwmb2h6S4sv8qWDk4wGSZ7pxMqwtvpEAgdAFmTU0LAtuL8WUA== X-Google-Smtp-Source: AGHT+IGfqcU1lRoW8AEI065pCqQ7GRGLfqWGDsdvuoacWD7ZZuT6x1K3Z9X2k4bdwIXT/WweQ8M+ X-Received: by 2002:a05:6a21:1a8:b0:1af:d6dc:86b9 with SMTP id adf61e73a8af0-1b2b71552abmr3267158637.53.1717600354206; Wed, 05 Jun 2024 08:12:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717600354; cv=pass; d=google.com; s=arc-20160816; b=GBOYRe3ayKWVwKueSjjQklGROh3q9h/CeTkx7N7Fkoq8SyFqif+tRWCS/3jntLfqVw mLd8b/sB3HjgDuwOdK3uWUVUKTnteaTxj0woye4Q1AH0/NSoUxwO+Spe5CyMH4mZqOA0 t16ex+ED7JgyUIZb2/NHKjOxUO0RJvSnk72go9vNR2sbE3HYo8e8MYZ29yXE074YFTis f3pORDCuvjLe8KyQ32FmDWf0eT7RjiaVi1mtQcTk+omPCxUVOSFyX1zPQxiaxbEOm0iU POCWlReMrxqYbjxOfeiEiKUjlfnNMpbKRg5JtS0QI3+jfTgAPROYVPPK2l16PZaLgckq 1nhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iqV2acmMzOLGBC90yH0i7PZOjKc+YcoOzvs2GcSNu0I=; fh=fnxRbob9v9ecCHZjkJDL5du5j4YQmhJumIcK7XTkfmA=; b=iMzOXyyFlW+aaPooPKHPPjD4NmSsEqT6NfTtrVqOTnkWVOxSWDGqZ1ezFdc5YhGZLh xNG9XENB9crlJ8+A+InnOf0mWEXYBs0AO3hgxoyTliu8RzHVsChrdEMwnhzw5/+Q2PmB ZovD6LL6+9CNMBmJK3grt16jfdJodxJo9vJgWbNJapK2OA8SlmPeVWqNEdcDp94qBrvg NbEvqSeGDzHMshigpV2Pg/497D+lNSS5xvfl4qSeLo69QDtuKr4a2wHruUj/57L4Ba3U aMlldzFQClqO6CgTyaVg0HxhQxdooBI91BKXAPS+ZVI9IqL8+74HVh6qpzgnyxB+/dvp y8PA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CD7ZrY+x; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-202800-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202800-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6d3c1f9841asi2897619a12.447.2024.06.05.08.12.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 08:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-202800-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CD7ZrY+x; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-202800-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-202800-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 45B832895E7 for ; Wed, 5 Jun 2024 15:03:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B8F7A4AEC3; Wed, 5 Jun 2024 15:03:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CD7ZrY+x" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF0444776A; Wed, 5 Jun 2024 15:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717599795; cv=none; b=OSOVOFRFTpiqLeRNW7m1TW8vfqGsYyDlCu4r1itx9p1u3zkBu9ZX+l8bG5DQ7zbPejfZ5l0+2YCpz46FI2c+te2dlBXz5PMs0Sfs2bjqfuea5XGzSYkfgfmyIz5h/uCdPdP8SJzzGc4/pbLNZt27Tzncazr/MNm/JR72Y+Rxt0I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717599795; c=relaxed/simple; bh=iqV2acmMzOLGBC90yH0i7PZOjKc+YcoOzvs2GcSNu0I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iiIcRWpdZ54O09DnsqqNesTdQU9rDyRC+Q5dcC/oA0yOLjbnAFnZzLmw+zCdYzINI82OSYw4yd6rAJ1cU8dlVqc68nkDtRxJ1AMkyry16g5Ab8fP0yDSwwooapvoJzp1TSHVEVZmVQJ3XDzFj/Q3KgJ2JyZwNZsNuGytx3hnZH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CD7ZrY+x; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0ED8C2BD11; Wed, 5 Jun 2024 15:03:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717599794; bh=iqV2acmMzOLGBC90yH0i7PZOjKc+YcoOzvs2GcSNu0I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CD7ZrY+xO4CHKNb+DEk8cqYB/csWTMoUhn0/v8yXjBWT77Yq7kUBYB3B3jgoAJZPm Gwh3p9Nh6Tnn4xQjZzCjO4AFzUuyrjj4xy+NJmpELrIVwF5s0TqLP6kCSe/hyhj2U5 I9swmUvsDLbgNMYRkfQ8CMsH/a7G6MScLZ2KXc0dy/nMspx15DoLMsjCslS/FTDXo/ gavP5OCIt2rBM/jG7g6eMRioA+zVrDoPqypDg2O9jUC9esfeZFlMYzdZt9Xy26U9eP aFa+md3b3hH1/TZein3rlu0W3K7gG0zPEP8gm7ezQm9UKjpiqEOBhFEBat0PvZTZ/E YafsTzQO2DA/Q== Date: Wed, 5 Jun 2024 17:03:09 +0200 From: Christian Brauner To: Mateusz Guzik Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 3/3] vfs: shave a branch in getname_flags Message-ID: <20240605-sonnabend-busbahnhof-3f93ffcac846@brauner> References: <20240604155257.109500-1-mjguzik@gmail.com> <20240604155257.109500-4-mjguzik@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240604155257.109500-4-mjguzik@gmail.com> On Tue, Jun 04, 2024 at 05:52:57PM +0200, Mateusz Guzik wrote: > Check for an error while copying and no path in one branch. Fine to move that check up but we need to redo it after we recopied. It's extremely unlikely but the contents could've changed iirc. I can fix that up though.