Received-SPF: pass (google.com: domain of linux-kernel+bounces-202859-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Will Deacon <will@kernel.org>
To: robin.murphy@arm.com,
	linux-arm-kernel@lists.infradead.org,
	iommu@lists.linux.dev,
	Mostafa Saleh <smostafa@google.com>
Cc: catalin.marinas@arm.com,
	kernel-team@android.com,
	Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org,
	joro@8bytes.org,
	nicolinc@nvidia.com,
	mshavit@google.com,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH] iommu/arm-smmu-v3: Avoid uninitialized asid in case of error
Date: Wed,  5 Jun 2024 16:45:46 +0100
Message-Id: <171759168166.1126369.9985606897560767685.b4-ty@kernel.org>
In-Reply-To: <20240604185218.2602058-1-smostafa@google.com>
References: <20240604185218.2602058-1-smostafa@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Tue, 04 Jun 2024 18:52:18 +0000, Mostafa Saleh wrote:
> Static checker is complaining about the ASID possibly set uninitialized.
> This only happens in case of error and this value would be ignored anyway.
> 
> A simple fix would be just to initialize the local variable to zero,
> this path will only be reached on the first attach to a domain where
> the CD is already initialized to zero.
> This avoids having to bloat the function with an error path.
> 
> [...]

Applied to will (for-joerg/arm-smmu/updates), thanks!

[1/1] iommu/arm-smmu-v3: Avoid uninitialized asid in case of error
      https://git.kernel.org/will/c/d3867e714831

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev