Received-SPF: pass (google.com: domain of linux-kernel+bounces-202867-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 5 Jun 2024 11:52:04 -0400
From: Frank Li <Frank.li@nxp.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
	Vinod Koul <vkoul@kernel.org>, Maxime Ripard <mripard@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
	iommu@lists.linux.dev, linux-sound@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH 02/18] dmaengine: bcm2835: Support common dma-channel-mask
Message-ID: <ZmCJpCUc3BcC065R@lizhi-Precision-Tower-5810>
References: <20240524182702.1317935-1-dave.stevenson@raspberrypi.com>
 <20240524182702.1317935-3-dave.stevenson@raspberrypi.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524182702.1317935-3-dave.stevenson@raspberrypi.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?+YU0pQ50kNnij8nsRPXN2bFzvwx0FbxHjrPyGKYcS78VbTY+xFXqXY+R8SQO?=
 =?us-ascii?Q?q059yP2k+H5WKfUQajJXFivtaSdUSO9iTq0UXUDlW6NV6OAm8i0G6b+ogLbr?=
 =?us-ascii?Q?Mz857I+KuT877uHPRi8GDaq971iPPdQZma1wpvOs87Hoxb3fq/KROhpsconw?=
 =?us-ascii?Q?2BQnxCjqWP7IzOkRC9IclgZUBSkTSlGhVtV+dPIlL93q3I6PWLZzIg6HUJny?=
 =?us-ascii?Q?Ok1y9JhpXwrpsTX6AUBvyH9aO8L0ODMy56bzb3UhazKY5zAp5b2T4pe8k36S?=
 =?us-ascii?Q?0G0t3pVER3r25mqDyF37TrDOWW8WyoHiren02Ky1pTJ3pwzS5SDH+u6mGtEu?=
 =?us-ascii?Q?/PiJY2CuZlyNYTD9lNV+GjIoDPtSZDd9KB85SHU3fwq7feWEQ/5UzrScC8Gv?=
 =?us-ascii?Q?DmiMx66XLy3yZ4BTsIUtdIRZlHf8UtRjU1ydQdXBcpKLfIkchjhEVN3hH6/r?=
 =?us-ascii?Q?qA1MYvRER6h4a931NSiD2Hw2brLBAW7nNKxfs56M9rruGmlDupDDlgqhE6D6?=
 =?us-ascii?Q?Y7CxF7ssx/IEbmtbZY8jac8WJlMj3i+tvSqZrkwiUgi17VKqimmfsUqHdlwA?=
 =?us-ascii?Q?xqo9LIbNhylELtTLKFdBA7sY0hgTkO96KUZiDqi6y33lqK9+bUvfgk8Gfe65?=
 =?us-ascii?Q?QegcZB1dfkd8ROLYZesy3ElB+HEHqtmhXG0AlM3jvxUwjppnSUqpGYoR4kbx?=
 =?us-ascii?Q?hFXDDSr9sfdaiRB5ff8qb0I1ktpEB91tYCbLM0NBSaSUCSqQ8SAaQybD9HTK?=
 =?us-ascii?Q?9U6m+fiNgGgCXi3gJ+ypmbN0WVKmqX6UJ5j1JX8FOaQC8XJZPnoKX3b/iEJ3?=
 =?us-ascii?Q?860A63CcMEC2ZjUDE5VZn42KM9pNpbKr7gRSIL95jv2M5hiUCEmkc/TyOr++?=
 =?us-ascii?Q?3xX9jkyugBBpznj5bbyhOTU19eqhxteYUoJS0mfK/kqyhSWvNdA7WBWeq7Ol?=
 =?us-ascii?Q?reBQX7BtFDN7HZI+ENDy0/wFeQXAD7a6UsN+E9znWB37FZyifMGOPGSqDmgM?=
 =?us-ascii?Q?9ueEPk5jRAeGGClJsJ3tqKJjqYUy35MYQX0qDuiEm7Ec8nNUwfpUsBvQL1QC?=
 =?us-ascii?Q?vLYUZc1oL8Hb80t2Z703waWWrIMR3M+wXaMi0PdnSf1Bk88O8y2aynaQ0RJ0?=
 =?us-ascii?Q?mgIVo6iBa9jyPtVvhqL14TKKMObpd/SdTvFek38c9BtPMAwZ8Zt81Ii3u7CQ?=
 =?us-ascii?Q?8Tf31MaSg0126YZ4m4qzSknNyZYff9oPwMNpGa5w7LbVhjdTD7Wq6jMhelQz?=
 =?us-ascii?Q?53vfPXIje5MSFCiI9J+ctx4nCdKnKAgdM/PgmvWi+ZdQGNgc4ulHJnO7soWc?=
 =?us-ascii?Q?4sBs9k/pm7LlW91bdIOozgnTf3pl5GV/aph5uqmNCjiXsahC0JKU9HdqM/K4?=
 =?us-ascii?Q?T0lcPl/b5xdB9TPbMJyY1BaOk9BjdrF+L8ObskF7WEwGAV8CJDCM0oGzQDrp?=
 =?us-ascii?Q?5sQORz7wJSZh2fatp1gATYlCAw/k++s+MVi44UmhCZ3WW/m+C2RqXtYzQCkc?=
 =?us-ascii?Q?joeggEvU6Fg9i4mKjMR5b455SVYQwmR5Vyyz4dhmgIqHySkcRhr0sxrL1Uzw?=
 =?us-ascii?Q?TE06JLtrBPUxul0ug2kxDgDHlJZq+iIY56xUBMk7?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2902b79-fa33-40a5-4e9c-08dc85777afa
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 15:52:19.2376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MsJ2BiUZe0E0fCsUNcVU1LPGf5Jt+MGrlo915nZhTW1kRBTXt74QBgQDSAiPBBmD4fPIYpZ/fv5qXEQqzgcyaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6864

On Fri, May 24, 2024 at 07:26:46PM +0100, Dave Stevenson wrote:
> From: Stefan Wahren <stefan.wahren@i2se.com>
> 
> Nowadays there is a generic property for dma-channel-mask in the DMA
> controller binding. So prefer this one instead of the old vendor specific
> one. Print a warning in case the old one is used. Btw use the result of
> of_property_read_u32() as return code in error case.

Use generic 'dma-channel-mask' property. Print a warning in case the
old brcm,dma-channel-mask is used.

Did you update binding doc?

> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  drivers/dma/bcm2835-dma.c | 19 +++++++++++++------
>  1 file changed, 13 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index 9d74fe97452e..528c4593b45a 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -941,12 +941,19 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Request DMA channel mask from device tree */
> -	if (of_property_read_u32(pdev->dev.of_node,
> -			"brcm,dma-channel-mask",
> -			&chans_available)) {
> -		dev_err(&pdev->dev, "Failed to get channel mask\n");
> -		rc = -EINVAL;
> -		goto err_no_dma;
> +	rc = of_property_read_u32(pdev->dev.of_node, "dma-channel-mask",
> +				  &chans_available);
> +
> +	if (rc) {
> +		/* Try deprecated property */
> +		if (of_property_read_u32(pdev->dev.of_node,
> +					 "brcm,dma-channel-mask",
> +					 &chans_available)) {
> +			dev_err(&pdev->dev, "Failed to get channel mask\n");
> +			goto err_no_dma;
> +		}
> +
> +		dev_warn(&pdev->dev, "brcm,dma-channel-mask deprecated - please update DT\n");
>  	}
>  
>  	/* get irqs for each channel that we support */
> -- 
> 2.34.1
>