Received-SPF: pass (google.com: domain of linux-kernel+bounces-202922-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 5 Jun 2024 16:37:11 +0000
From: Matthew Brost <matthew.brost@intel.com>
To: Thorsten Blum <thorsten.blum@toblux.com>
CC: <lucas.demarchi@intel.com>, <ogabbay@kernel.org>,
	<thomas.hellstrom@linux.intel.com>, <maarten.lankhorst@linux.intel.com>,
	<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
	<daniel@ffwll.ch>, <intel-xe@lists.freedesktop.org>,
	<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/xe/vm: Simplify if condition
Message-ID: <ZmCUN0bb/d2NnftV@DUT025-TGLU.fm.intel.com>
References: <20240603180005.191578-1-thorsten.blum@toblux.com>
 <Zl9XnmJQMjeNDtko@DUT025-TGLU.fm.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Zl9XnmJQMjeNDtko@DUT025-TGLU.fm.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qVyYDM8RR3MrvaZxAHkw2vhjBy2DPL2ds020X/qmst7KZsLjOwBm2LDqaMgp?=
 =?us-ascii?Q?KYAS9XXXSLHZvQH3Ue3Ki/4pavpFKhrKaaGFlWSxvg0P1ZVw+uNO2M//19iq?=
 =?us-ascii?Q?YoSaBSej5ZeT1Ako8/Q3elpJ9evi9KUWIU/BOImA3d2UxlhFkGrwNztTLb9H?=
 =?us-ascii?Q?vy4Q6fn5vQuCQU9tIKBNnsvwTWgrSew9c0SIEGCV1VZfaBnf5Ay4zw5XSNcb?=
 =?us-ascii?Q?3IdgotytRP4nC4/VR4SFNHmnzRBFmgplKo1ONX62fDOv/cpotKpdVSAIrOON?=
 =?us-ascii?Q?eWLlnvB6Cgl3M3L/8VkIy6pcaj+FZa7zdmD9yqyyWwV8gg+FPNjfncDIrvan?=
 =?us-ascii?Q?wB2C7lAU7TKfOdVmaAnMWHXOfV71fakxMmkIcsu0LH54IqbFt9TrjQRC547g?=
 =?us-ascii?Q?nFlPOwNyOHwhp+MI3QV4dxO0IAbYBA06axvUjM/oGjclSC69Xi8JbU3R3t2t?=
 =?us-ascii?Q?diXB8eXEbLJm3GHJ5LsCji0nC2CSdRbyzjEkL/h3Bqg/WjC98REXKlKdzZz+?=
 =?us-ascii?Q?D6enOT9ZEsWuARkpnX3Mpt1K0FGM/ospsW/eXfVZKqJMAsXLkGg3HQpgPpLo?=
 =?us-ascii?Q?NSAuln1qKjTsulHCGx6RnDgtPl6nVOy0lbc2urWU1wVdoq3Iul77Vmkju70d?=
 =?us-ascii?Q?czuj04aSyF9errXA5ESHqfqohvB7EHCr0o9GBSJRbd/WpvWiujZr3gKF2zc0?=
 =?us-ascii?Q?DFuC29AWE4tX+o3QtlKgLIXeEstAzeUvmguLZ/mskQA335lxNazPW5RitoNV?=
 =?us-ascii?Q?E/Sv24B6PI/xeQxWiePlX0op3e9jNrPuv8JYsjCe0ZFFC+HDldry/cyADIqN?=
 =?us-ascii?Q?nlsc0foWcp8puYB4w6zMwzcLFfUBWeZo95+SIu859+rfQ5pJkBpnjwrfpvY6?=
 =?us-ascii?Q?6mF9OmsGFoDkh32Gqt+T6qWtM+J7o62uvxYy4R3K1q3eZLdj5jeEyZU6Iek8?=
 =?us-ascii?Q?N8HNExQbYkR58SuLLyioBQ9RyXu8hkFsxI/WBxxYRGtMoR5qlIPF92OYbRvT?=
 =?us-ascii?Q?tfyYR6hb+OS/l6saXj/2HtAhkJNt6K4RjRObYIs+d7hncfor2F3gDpL59grs?=
 =?us-ascii?Q?nM/1nNmjXcqGuHZFiJ+z45vqocLWwzQX+QsZBgY7qjjValUfDVDAIU0JbVje?=
 =?us-ascii?Q?gGl2CqmWByokRfwuH1TzfjOdwjy3ylGOK2Nkw1cKaklpIQXbdyqOWoIw/AqG?=
 =?us-ascii?Q?M9/x1CSzdl63yeDgMn7N5FJOgpx02vz2YSRQml1+nYncRW+JHGCH0qHG6o0+?=
 =?us-ascii?Q?KeLmt4XAq2VfIznzMaW13N2QGVUTG+RBtHdJGxQ3oBkcOBrW021R97jUPumr?=
 =?us-ascii?Q?Ddaxyai3EEjD4N2s+eKHn72nGnAxIQhWMlNCmprHq6IXwxo4IgPWtHu9Ayp5?=
 =?us-ascii?Q?YHlU5fbnWrElyBDBMHO9EskNWwn4JwsVkomckGMetT09VNQNvmQtZRemFg6L?=
 =?us-ascii?Q?lVtX0rf8GmBwIqGyd1ZNg167tWUj9+zxgFBSjftlS5Z5ut6w6hmsuzpdApBa?=
 =?us-ascii?Q?eHDBxJL9UYeK5Tts8xVpnm7/tom0BrZwCzCnwpbiCmtEtRAJzOTHLexC6Lpz?=
 =?us-ascii?Q?6o1zandmR+nTdxOQcYaqWGVWfTCxSaXynQBM6+w3XrL4NS/PSu9GxZLH4GGD?=
 =?us-ascii?Q?Tw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 341d1f23-d214-4fa9-b2fb-08dc857dddb9
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6508.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 16:38:01.8179
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A/OHdszbKoXPlqi0lXnNUdMcDyH0T3e6qybT2py4zaVO4ULDFfvKYv9S1xjw0HetsXmpqLTcZN8ANHWni+XrVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7829
X-OriginatorOrg: intel.com

On Tue, Jun 04, 2024 at 06:06:22PM +0000, Matthew Brost wrote:
> On Mon, Jun 03, 2024 at 08:00:07PM +0200, Thorsten Blum wrote:
> > The if condition !A || A && B can be simplified to !A || B.
> > 
> > Fixes the following Coccinelle/coccicheck warning reported by
> > excluded_middle.cocci:
> > 
> > 	WARNING !A || A && B is equivalent to !A || B
> > 
> > Compile-tested only.
> > 
> > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com>
> 
> Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> 
> Will get this merged once our CI system is working.
> 

Applied to drm-xe-next. Thanks for patch.

Matt

> > ---
> >  drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index 4aa3943e6f29..3137cbbaabde 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -85,8 +85,8 @@ static bool preempt_fences_waiting(struct xe_vm *vm)
> >  
> >  	list_for_each_entry(q, &vm->preempt.exec_queues, compute.link) {
> >  		if (!q->compute.pfence ||
> > -		    (q->compute.pfence && test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> > -						   &q->compute.pfence->flags))) {
> > +		    test_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> > +			     &q->compute.pfence->flags)) {
> >  			return true;
> >  		}
> >  	}
> > -- 
> > 2.39.2
> >