Received-SPF: pass (google.com: domain of linux-kernel+bounces-202925-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 5 Jun 2024 12:40:54 -0400
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: Jung-JaeJoon <rgbi3307@gmail.com>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] maple_tree: modified return type of
 mas_wr_store_entry()
Message-ID: <52hpolyqyyytkn4pjpuphfqdl7atb4woqaagdx365irpe2xhor@otb5znes4w65>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@oracle.com>, 
	Jung-JaeJoon <rgbi3307@gmail.com>, maple-tree@lists.infradead.org, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org
References: <20240604150629.30536-1-rgbi3307@naver.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240604150629.30536-1-rgbi3307@naver.com>
User-Agent: NeoMutt/20231103
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Kqr2hsHmQbegovY13GZJ6eNsCpjyxFsVpIG5vorbaMuZ/yXs/gP791mbYkoD?=
 =?us-ascii?Q?aKhyDMyV2EAPudr2jTrH/mu/+j6j4oDUotFVkn1LgV/YH3WXVe7zQr/jakEN?=
 =?us-ascii?Q?Ar6uBnrUygQtGWHu4o7WxsoEkhBmNgEsP2IpCaitSe8pNkIR3gzgE2WmDw56?=
 =?us-ascii?Q?Azq+Na69wNRVSWGTgNJjNjOdXQy43/92uPW+xa391gmEq4XAIF5OnfXY8+Ec?=
 =?us-ascii?Q?64kI7hdqwD+DDHO0iRBOH6sHH1blvPIorh9o7P06/sHa7vfCrNJYT6k5c25Q?=
 =?us-ascii?Q?OS7tyn3VDDTlaz0fswXv3vEkhwRRuRcuCgiiAdYCOAVsmFPT8x4rHucrHV6o?=
 =?us-ascii?Q?LPG9XMhUWxPDWX9Y02hqkICtDI07Cz8pvb4LmeUSSAdJBB3acuaCha/4PyYG?=
 =?us-ascii?Q?xdiCI6H+ykmYMnjvexi4J2PRVEII7pG/MdR+B3275MfPXhiekseaX+KpWsGL?=
 =?us-ascii?Q?TKcD6mg0jfMJW17b204vjWc0bJMN+vwN8kzVM2NzFGyeOiMDbcnXrujc4a02?=
 =?us-ascii?Q?QN0uMSyj9MY95eVaPJx2N2q947cauVeH144OgjehSTv2qi4POUhMBe0f0YDl?=
 =?us-ascii?Q?xXt1cGCBFltUtr/4cbJ3bEA6NPLYwRR1cDgaIcHCyaJA7mqD2XmwozvcKehl?=
 =?us-ascii?Q?wYbKBpreymRKIsiKwP1X4Arr2XwNqiM04XRrDwmuPcEKb3ZyQoOK6ZH/nfG9?=
 =?us-ascii?Q?WYtHOfXa63GENpho4PqDR8ZONjcBF65a0EtUCSVcwkb5E3vAaHZYcENbsxuX?=
 =?us-ascii?Q?p2HdCoewo+AzVvloKnkDpeWlAWCPAX7+688K7IlQybvdBkj19HvTNedlBokq?=
 =?us-ascii?Q?EFVzNNxUEofXtBxFtIE+xoclx3Y8TX4Yj6qIjdpRntPHd15xwS/9niZBmCCt?=
 =?us-ascii?Q?L828GQnQK5Kd8MaFZ3iPQbkg+mTCa6MJie6X29GwbCBdHXhuudCia+fLTK/w?=
 =?us-ascii?Q?X7xe3raXWXQNuWgZHFFqElgGSfasHW6RjuW/t1rBS/CX/qJhsw376g6Foz1p?=
 =?us-ascii?Q?r1Oh+X6himoheJYJLxoQ1c8FFsSPP0PQhHMg6a4XON+cag/Wh+mGHZFYbGRU?=
 =?us-ascii?Q?LoF590hzy570dB+i4rUZmIX8C8rWG/cpkHDtqiM+9vGWSiJmIbd/MDlCGzQP?=
 =?us-ascii?Q?Ja0lB/SZ0MljN+AZhoPlkxegGhc+qr7vBqbTbvmAYtLAaIM51L5K0gPZpt/V?=
 =?us-ascii?Q?lZwKIq/hB/WcI3ZN1jxfry6TCG7v7CqSaECsUtVqfIqWKy4cStkqe02xyzMp?=
 =?us-ascii?Q?BLuINwhymgNt58apiYca26I7HPi33/R9isvu7yQ/Q2iIVWdCPAJdOORDPW9T?=
 =?us-ascii?Q?ljscrN6r2aibdzljmX+JeTLB99wlnDQpifjgu8V2GkE6yZm5kOs7n9KKWBH3?=
 =?us-ascii?Q?RclaWU6/VQe5zKS93qjhd0LEQ9xB0/CszINyvT60GSOvzlM6/RmNIGGn30Ap?=
 =?us-ascii?Q?QOSejkhf3apOWSaDr3Td3/DjlEu9xPIMdrBnPPrELgu4nhiDKFdadaaGyw2L?=
 =?us-ascii?Q?seRKywO07/ZQPQWrGZMsdXNsvFMcc8FwhfAnaZEVpHxsMhxIDS2V+evuUUzJ?=
 =?us-ascii?Q?7zIwIONhoSSVyXBs5wnguVH6+IfNb6yeGALj08kI?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	7ZWkD5GjSBdXCqHCsMcxpvZSQuHkXGq3dNfMDqBNHLWpiwQ/eHF5IZqJPw8FLDHtG60D66HrJ1uiUNJ2R4VxSmpMq2bIROG+Z8UG7OHq+rLLp9Z/z9VOsJothDNB30+UwKHVYmZPd0aQs5Gs1HiZDmo70x2CQYCDig1bIEYAJ2e5K8I+M6Ubg9wyHvCQLUi03jgO5GcyTn19zBmrZWwnQp0UvU1J1baC4GDZqs4xYi/LMj5RRzPQxye/UYWSiPt5BgAKmB1o57vQl5/SFgkzkobcuywIWjTRsQAjQfOl2rFdqs9D8gpJfRZRrZWHuFF+E4isV4S0mPRWFmFZtn13zb1rAvCdoH2suB8eHI3Pss0YNJAPN/KS8JaUPNw5D2UhQTsYIGHHB4tOmmn3G67gDfXnSELM/bT9Scq1pORCxO/P0+JvW/KGBJyZEG5UrGNDPwc9JVYvVZh9ltiGAn5gORBocZg1dEm8FytYjIADGxu0tmmkQ3Z7DD29FQKQUleeQJXC+4h/NclCbtdEZmSnPYuH1+JmsgUbAGmS4Yr9zOif8PXXmXFc0TTnJ9EhocUto7wRXPlO4ZQCAgCp+tDPk7V3SNuRUKmXpH2aRP3eRwQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7e698941-381b-420a-e82c-08dc857e4661
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 16:40:57.4121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JHY3t9EV6pUO5DwS+kR2yZK010VJ7oaKw8X/uyXNcygKoyeLorQsUV/U6o2frIYXymQUy5Qwl1iSG8N6Co/PRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6148
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-05_02,2024-06-05_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 spamscore=0
 adultscore=0 suspectscore=0 malwarescore=0 mlxscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406050125
X-Proofpoint-ORIG-GUID: trAq4_wUas8Ca9d8rRNciMQUnVAvRKEE
X-Proofpoint-GUID: trAq4_wUas8Ca9d8rRNciMQUnVAvRKEE

* Jung-JaeJoon <rgbi3307@gmail.com> [240604 11:07]:
> From: Jung-JaeJoon <rgbi3307@gmail.com>
> 
> Since the return value of mas_wr_store_entry() is not used,
> the return type can be changed to void
> 
> Signed-off-by: JaeJoon Jung <rgbi3307@gmail.com>
> ---
>  lib/maple_tree.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 2d7d27e6ae3c..da30977aab0f 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4203,31 +4203,28 @@ static inline void mas_wr_modify(struct ma_wr_state *wr_mas)
>   *
>   * Return: The contents that was stored at the index.
>   */
> -static inline void *mas_wr_store_entry(struct ma_wr_state *wr_mas)
> +static inline void mas_wr_store_entry(struct ma_wr_state *wr_mas)
>  {
>  	struct ma_state *mas = wr_mas->mas;
>  
>  	wr_mas->content = mas_start(mas);
>  	if (mas_is_none(mas) || mas_is_ptr(mas)) {
>  		mas_store_root(mas, wr_mas->entry);
> -		return wr_mas->content;
> +		return;
>  	}
>  
>  	if (unlikely(!mas_wr_walk(wr_mas))) {
>  		mas_wr_spanning_store(wr_mas);
> -		return wr_mas->content;
> +		return;
>  	}
>  
>  	/* At this point, we are at the leaf node that needs to be altered. */
>  	mas_wr_end_piv(wr_mas);
>  	/* New root for a single pointer */
> -	if (unlikely(!mas->index && mas->last == ULONG_MAX)) {
> +	if (unlikely(!mas->index && mas->last == ULONG_MAX))
>  		mas_new_root(mas, wr_mas->entry);
> -		return wr_mas->content;
> -	}
> -
> -	mas_wr_modify(wr_mas);
> -	return wr_mas->content;
> +        else
> +	        mas_wr_modify(wr_mas);

These two lines have whitespace errors, you should be using tabs.
Please use scripts/checkpatch.pl to detect formatting issues like this.

>  }
>  
>  /**
> -- 
> 2.17.1
>