Received-SPF: pass (google.com: domain of linux-kernel+bounces-202957-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240516174357.26755-1-jim.cromie@gmail.com> <CALwA+NZ7Cdd9M2Cus+Lv3yoc+eWNdUjCmECGJbfoin3ikHLbxQ@mail.gmail.com>
 <CAJfuBxxus5_0=ydNWwQhDNhe1++oh8nBe-+3Egt6mKk_W=0w3w@mail.gmail.com> <CALwA+NbtX4pkFm35L7bjL0D-c=RMOu7vVC0=cUg4Q6n7uD=u-A@mail.gmail.com>
In-Reply-To: <CALwA+NbtX4pkFm35L7bjL0D-c=RMOu7vVC0=cUg4Q6n7uD=u-A@mail.gmail.com>
From: jim.cromie@gmail.com
Date: Wed, 5 Jun 2024 11:05:30 -0600
Message-ID: <CAJfuBxwSXVLnis6T=ybbyxQRdSV6mHMBbDJ_CwUr93f=adSHDQ@mail.gmail.com>
Subject: Re: [PATCH v8-RESEND 00/33] Fix CONFIG_DRM_USE_DYNAMIC_DEBUG=y regression
To: =?UTF-8?Q?=C5=81ukasz_Bartosik?= <ukaszb@chromium.org>
Cc: jbaron@akamai.com, gregkh@linuxfoundation.org, 
	linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, joe@perches.com, 
	mcgrof@kernel.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, 
	jani.nikula@intel.com, ville.syrjala@linux.intel.com, seanpaul@chromium.org, 
	robdclark@gmail.com, groeck@google.com, yanivt@google.com, bleung@google.com, 
	Kees Cook <keescook@chromium.org>
Content-Type: text/plain; charset="UTF-8"

>
>
> > Im thinking that a combo of 1, 2 would suffice.
> > And we could probably drop the config constraints,
> > especially if the test avoids failing on configs where a failure is expected.
> > IOW - if no test-modules/builtins, run only 1st 3 tests, ending with PERCENT
> >
> > That said, I wonder if the exit 127 should be success instead ?
> >
>
> I don't follow you here. Could you please elaborate why exit 127
> should be a success ?
>

well, exit 127 is sort-of a monkey-patch.
(this) monkey, sees it used by git-bisect to not be a normal fail,
but a special signal that bisection itself failed. (maybe..)

I have no good reason to think its useful for selftests.  RFC.

WRT success,  if /proc/dynamic_debug/control doesnt exist,
thats probably intended, and we shouldnt complain.

>
> > thanks Lukas,
> > ~jimc
> >
> > > Thanks,
> > > Lukasz