Received-SPF: pass (google.com: domain of linux-kernel+bounces-202991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 5 Jun 2024 13:52:44 -0400
From: Frank Li <Frank.li@nxp.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
	Vinod Koul <vkoul@kernel.org>, Maxime Ripard <mripard@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
	iommu@lists.linux.dev, linux-sound@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH 06/18] dmaengine: bcm2835: make address increment
 platform independent
Message-ID: <ZmCl7LXbdCwJm/wJ@lizhi-Precision-Tower-5810>
References: <20240524182702.1317935-1-dave.stevenson@raspberrypi.com>
 <20240524182702.1317935-7-dave.stevenson@raspberrypi.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524182702.1317935-7-dave.stevenson@raspberrypi.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?s73sUocWUyyeHMwr8FAxVLAuQCDl+/eHfu5G2w/bftUyYk/8AR3YDYTg3rhZ?=
 =?us-ascii?Q?4QcGPFAGD/HKfo4OT0UXSDfKard1pHHmR3VWEN578ZPge0XQzJy3wVY+6i7X?=
 =?us-ascii?Q?Vqn17+fWxhj5i/zqTBUHPVLlsGQBfSBslk2wKURNV272GOaG2+lxGxiDOn4K?=
 =?us-ascii?Q?q6Yw9RW76fMEbKXaTLeQr5n4LWi5UNOoM4QDUOnXoPIi/R7yACnG4CRIe1FW?=
 =?us-ascii?Q?u8P5wkOAAJ34GJMCoUD6NSqBZuT/+odEvep08LMEiC+TGpXYvdusiHKBmtGr?=
 =?us-ascii?Q?cDWUlgHoZ87vmYugMgrXAcPp0s6Uc9WIbyNtRrRJaF7ukyWtbfe1JrSosG+c?=
 =?us-ascii?Q?tj1VjTAgL1sKwhJIkbC826xZG/A8h2hzriv8dDzzta6tFk6tvfcFSjU9z0A4?=
 =?us-ascii?Q?heuNvkr5X61miz2EY015RqpuJgczyq5BmxlIELgSZQCyFKUi8xvT0gxJ/OnU?=
 =?us-ascii?Q?3pgi+wX2xPfRDfqH/5zxpRwOpJ3Z+UUDTCiS6YV8gi0DYSFTX0pBJHFcjLfq?=
 =?us-ascii?Q?ni8ei5adPPagjlNRUGR6p7lrxD1tmLTOMvB+FcwIDB4EPxXllEgYD6DnZlrY?=
 =?us-ascii?Q?DDaIsZrBpL7lWy9j6WgvlnBHTbH/yb/y4n7yR5Qfu2YMHdTWqaDjoI/kYtf7?=
 =?us-ascii?Q?Hg8cn93DZxfI+5hyopdw7GjZAnxojUKYf6X7Yv6qLp2yyyPxbUuAIG1Huwot?=
 =?us-ascii?Q?+7wNmYyfjJ0Da6V6tm+9Pk0ZLz/5xWmaPppOU7b8kU/UTwpWm3Tf2L7A2Dqv?=
 =?us-ascii?Q?CmCPQS8yAE6uk8F3NVwUDqlFC1oWINtiWkXrHYAl406y/2CarHYDKZutXAR2?=
 =?us-ascii?Q?D/Dcwz5Rj7xlLfX8Qa7VOrKeJkhg37KUN6I+9R62Rxf9Q78qgSnU6YoGGNXO?=
 =?us-ascii?Q?ab86Iup2FyUF4X0/GMZS6sFJfew/hHiKNp5SUZCgT4W/uGQtUh5CYavsztAJ?=
 =?us-ascii?Q?fXd/5Wc/pyGZq7QFeaa1CtfSJH0tybs3DjWwYsKcgIUth7xxBMSKvHeqvhQe?=
 =?us-ascii?Q?cvzyiWNG9oZqHveD73Xy2XjbNb/X1Zsey3hn/Fj9fYwQtOz80ZeLciWjAZi/?=
 =?us-ascii?Q?7b9h4l6rnKd5QJoGuFZZx0uWHyH/NqoBpt78cSZ3XwL3KeP5XscLTqqqSfVA?=
 =?us-ascii?Q?105c4qZvUI3XRb7nPgDGNd7X3k9FryZZ+Q6bMlTX68R6UH25m8Eqw+Q95IN4?=
 =?us-ascii?Q?LNERUs6rC7MlJl0Idfz0oFlHQ6y/hjs0Y1yBhCcTdv75U0dIWfu0hA4YZ2Rx?=
 =?us-ascii?Q?GnCbxcaaZTKwi5OIg8RprNUOo1GQk9SiZj9BM2w7jWkpdKVt1VNPVnGuvbyI?=
 =?us-ascii?Q?i2ZuPEtAGYEJbBSbAAqeGfT9cLfbikSN2fFTnJHvVrFlOkSRhuL2rmyKfnMo?=
 =?us-ascii?Q?RDGFATK+9LCFDn/wvHEGC9J6+ryZLNEPzVMoA/IaafrkIW6qr6xARin2KySu?=
 =?us-ascii?Q?S65mh9ofUB3HdaO/LkDxADJ4BJh4ki2GRCeNwNI3GllhMK7Xu5E/0uRzpLuc?=
 =?us-ascii?Q?6048hmPXhndftAjTr4TXR4/393Y9ZStYgT4lZK4d0eNp/YyZrEWmpcqGROAO?=
 =?us-ascii?Q?qK2gsSg48oVSyPOwZITYE1Q7nntGlfxJgNi7OaFt?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e8fb22c-fb9f-42d9-2e97-08dc858855dd
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 17:52:58.3437
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qPo0VB6l8VmR+6P6Ah3GALj5FREQR7aO88mH8Nr+k3uJNTlw0Fdx9QRCDovXfvsbxmdaz+JZmHt+ex6IhaaXHw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6959

On Fri, May 24, 2024 at 07:26:50PM +0100, Dave Stevenson wrote:
> From: Stefan Wahren <stefan.wahren@i2se.com>
> 
> Actually the criteria to increment source & destination address doesn't
> based on platform specific bits. It's just the DMA transfer direction which
> is translated into the info bits. So introduce two new helper functions
> and get the rid of these platform specifics.
> 

Fix increment source & destination address depend on the platform drvdata.
It should be depend on dma_transfer_direction.

look like it is bug fixes. Can you add fixes tag.

> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  drivers/dma/bcm2835-dma.c | 28 ++++++++++++++++++++++------
>  1 file changed, 22 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index ef452ebb3c15..d6c5a2762a46 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -252,6 +252,24 @@ static u32 bcm2835_dma_prepare_cb_extra(struct bcm2835_chan *c,
>  	return result;
>  }
>  
> +static inline bool need_src_incr(enum dma_transfer_direction direction)
> +{
> +	return direction != DMA_DEV_TO_MEM;
> +}
> +
> +static inline bool need_dst_incr(enum dma_transfer_direction direction)
> +{
> +	switch (direction) {
> +	case DMA_MEM_TO_MEM:
> +	case DMA_DEV_TO_MEM:
> +		return true;
> +	default:
> +		break;
> +	}
> +
> +	return false;
> +}
> +
>  static void bcm2835_dma_free_cb_chain(struct bcm2835_desc *desc)
>  {
>  	size_t i;
> @@ -336,10 +354,8 @@ static inline size_t bcm2835_dma_count_frames_for_sg(
>   * @cyclic:         it is a cyclic transfer
>   * @info:           the default info bits to apply per controlblock
>   * @frames:         number of controlblocks to allocate
> - * @src:            the src address to assign (if the S_INC bit is set
> - *                  in @info, then it gets incremented)
> - * @dst:            the dst address to assign (if the D_INC bit is set
> - *                  in @info, then it gets incremented)
> + * @src:            the src address to assign
> + * @dst:            the dst address to assign
>   * @buf_len:        the full buffer length (may also be 0)
>   * @period_len:     the period length when to apply @finalextrainfo
>   *                  in addition to the last transfer
> @@ -408,9 +424,9 @@ static struct bcm2835_desc *bcm2835_dma_create_cb_chain(
>  			d->cb_list[frame - 1].cb->next = cb_entry->paddr;
>  
>  		/* update src and dst and length */
> -		if (src && (info & BCM2835_DMA_S_INC))
> +		if (src && need_src_incr(direction))
>  			src += control_block->length;
> -		if (dst && (info & BCM2835_DMA_D_INC))
> +		if (dst && need_dst_incr(direction))
>  			dst += control_block->length;
>  
>  		/* Length of total transfer */
> -- 
> 2.34.1
>