Received-SPF: pass (google.com: domain of linux-kernel+bounces-203038-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Javier Martinez Canillas <javierm@redhat.com>
To: Brian Masney <bmasney@redhat.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lib/Kconfig.debug: document panic= command line option
 for PANIC_TIMEOUT
In-Reply-To: <20240605174736.778321-1-bmasney@redhat.com>
References: <20240605174736.778321-1-bmasney@redhat.com>
Date: Wed, 05 Jun 2024 20:05:23 +0200
Message-ID: <87wmn3nu3g.fsf@minerva.mail-host-address-is-not-set>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Brian Masney <bmasney@redhat.com> writes:

Hello Brian,

> PANIC_TIMEOUT can also be controlled with the panic= kernel command line
> option, so let's reference it in the Kconfig help. This option is already
> documented in kernel-parameters.txt.
>
> Signed-off-by: Brian Masney <bmasney@redhat.com>
> ---
>  lib/Kconfig.debug | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 59b6765d86b8..a6eb7425b888 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1043,7 +1043,8 @@ config PANIC_TIMEOUT
>  	  Set the timeout value (in seconds) until a reboot occurs when
>  	  the kernel panics. If n = 0, then we wait forever. A timeout
>  	  value n > 0 will wait n seconds before rebooting, while a timeout
> -	  value n < 0 will reboot immediately.
> +	  value n < 0 will reboot immediately. The kernel command line
> +	  option panic= may be used to override this option.
>  

Thanks for adding this, I wasn't aware of that panic= cmdline before.

Maybe it could also be mentioned that the timeout can be overriden by
user-space using the /proc/sys/kernel/panic sysfs entry too ?

Regardless, the patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat