Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp475816lqr; Wed, 5 Jun 2024 11:14:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWaKFmSq4MHymN1Kep/X0IxgQcKpQOFKhQFH8WcnKONbxwkH8txL9NTijNUP84QYhoQUHLEmfjZJATtmK7s+Hs26Z9wXNVn7rCv9VAqJw== X-Google-Smtp-Source: AGHT+IHLjfxgC4QhKrtbM91t+BkLIJZIiEm0OGakfdIoE1HTb1yBv+4JZ5+9HKUb+I0nBVheWI7J X-Received: by 2002:a05:6a20:918d:b0:1af:6541:8a08 with SMTP id adf61e73a8af0-1b2b6ee5c1cmr4007224637.20.1717611297189; Wed, 05 Jun 2024 11:14:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717611297; cv=pass; d=google.com; s=arc-20160816; b=TB8syMxIMzKz5zdbCaJeb6wz8iJdWUvUxZnqki5yJbwmf9G90UHclnubyTkmSdONKY VWlB490bued1h8SxN/ntPzLZqu+y8cu35z88ljux4YjexZlNjYBWXnTuw7VLSqn5QEdv Q0cZQcvDlbMxANWKta3FrS+wIXmHteOYpwRi2l+cazR9k/vIMcNl/cIUXWSbJsocgNN2 4GSRL2OYne4crtjxIwKSpRvTGyzmvEcVmM76XT7U49ZO4VRo/pKw1tdNB53LV+pgmvf4 a92EHtZz6ey0jdkmumSynabu4+KtqqVZxAIRMvtAbcJGId7E6X2Wkfes/e6Mt5mh/ARP B3nA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=K6wymAHmOteJ+lmn0Y1vvco6eN/pvzXV4g+tp+KZ15s=; fh=WdJTzcKHC8ktk8y0U/4EQuOcdeMySvxPUHN4GuE6Cms=; b=G7TiDXSPZLdj1WuJRMKCeS09XPTd3rqfAT2SfeOIZuwvWVnCukuEKGd/+YyAWN1L6F 1yBBuNqV6+u4uaxblvP6mSwg8ImKJCFqWpFiIB4LpqXqaGoRfLmQSPsap7epyaUiMBF8 wB1enHXUJ81rLiUYlRuKaKuFeYlbERkhPehJygn77nTX1M3C4TLIAG7Pg4Eya9JckE4m Jgebgn+XZoKKUnujqSETcjfdiDPVd1gv6xBD+VnE0lXkGaxDPzmP/MbvnQDjGBXPzT1g 7tmjslIG7wBsNMpRqhLGLxxLpdoTosOpRf2JE6buXc49wWWRRzaJDQQOyDx8fx5qIVLl BdrA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-203034-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203034-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35d59faa8si4008400a12.849.2024.06.05.11.14.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 11:14:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203034-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-203034-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203034-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BA12C28510E for ; Wed, 5 Jun 2024 18:10:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D714D13C833; Wed, 5 Jun 2024 18:04:55 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 571DC7347A; Wed, 5 Jun 2024 18:04:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717610695; cv=none; b=qw8bmOWz7d6WA8CNYGCnL3LmDNBMceX9UnEJ8YUAmXroH3zy9WzFh7SFCnmcYC7J3vlEYCFcYmFTzlH3FkzvnfBGIbI+LwGsaZ/u0dLV/uZ3JaPN3/oP9vXZzB8If19eD/N3PVJdY74JYv8SCbe89UAOW5dowiAVewCBb0cBG/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717610695; c=relaxed/simple; bh=EwronXBW71M61WKlYINkIFLMDKf8/K6XHuj6hhf2t+s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PO2Nm7sYY43hNXLQ3voojzt17cG31nT/hejWdTrmAicmFe7TeGpRihe8qno+u6IDSkmG/E5DNHcShTsABfgx+AJb80ZHrb4OgBXjge0Kxr1QT5KyUsM8PkA9C/kfgdZ+/ffFdHzSFJvITsISNWZYxzpG6/v7A7VKhYfmNSuPWtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21751C2BD11; Wed, 5 Jun 2024 18:04:54 +0000 (UTC) Date: Wed, 5 Jun 2024 14:05:03 -0400 From: Steven Rostedt To: Mark Rutland Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mathieu Desnoyers , Andrew Morton Subject: Re: [PATCH 3/5] ftrace: Remove "filter_hash" parameter from ftrace_hash_rec_disable/enable() Message-ID: <20240605140503.3b385ab1@rorschach.local.home> In-Reply-To: References: <20240604212817.384103202@goodmis.org> <20240604212854.883675803@goodmis.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 5 Jun 2024 11:17:31 +0100 Mark Rutland wrote: > On Tue, Jun 04, 2024 at 05:28:20PM -0400, Steven Rostedt wrote: > > From: "Steven Rostedt (Google)" > > > > The functions ftrace_hash_rec_disable() and ftrace_hash_rec_enable() > > always has 1 passed to its "ftrace_hash" parameter. Remove the parameter > > and pass in true to __ftrace_hash_rec_update(). > > > > Also add some comments to both those functions explaining what they do. > > > > Signed-off-by: Steven Rostedt (Google) > > Looks good to me. > > Acked-by: Mark Rutland I removed your Ack from v2 as it changed enough that I believe it requires a new Ack. -- Steve