Received-SPF: pass (google.com: domain of linux-kernel+bounces-203039-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 5 Jun 2024 14:05:20 -0400
From: Frank Li <Frank.li@nxp.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
	Vinod Koul <vkoul@kernel.org>, Maxime Ripard <mripard@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
	iommu@lists.linux.dev, linux-sound@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH 08/18] dmaengine: bcm2835: pass dma_chan to generic
 functions
Message-ID: <ZmCo4IfRhEzMf9gs@lizhi-Precision-Tower-5810>
References: <20240524182702.1317935-1-dave.stevenson@raspberrypi.com>
 <20240524182702.1317935-9-dave.stevenson@raspberrypi.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524182702.1317935-9-dave.stevenson@raspberrypi.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?m5yDdZD41BFVCa2kZ7u764hjXcWyZ16fmKckUaILteKV1rz9hXIMwo6LErvs?=
 =?us-ascii?Q?Z2IL9D0Re1/caOtV9nNdqD/KQ17IZsSgy6N60wXaDoRgrf/mSQv/EjCZJHxX?=
 =?us-ascii?Q?maR5ajQOQWFyFle63I2TS+n1xQ9bzz4FWiE56ODvBEQIY/Soxs2+kdxUiLF3?=
 =?us-ascii?Q?X/WtLjzA2aCSqxeaTWsM89MyDIHx6hAEmyj9KeKBtgOFqQzXsaqLm2XAfObf?=
 =?us-ascii?Q?NMkdD5wouUh4kAdSX7o0rzLnOG58bV+tQNgT3PqOgA/AKz8SC8BO1LDV6Xa9?=
 =?us-ascii?Q?FsaW6/PKqRhBF293kFUE66NQ5U70DW4IZZCeI/hY034JfURxfr5d7rVXHVXP?=
 =?us-ascii?Q?mXbUngB2dXfmtOkrED5iDxtva0a4xghQAxBhM126rOzeA8rvu41MD74fkuwZ?=
 =?us-ascii?Q?Q+8Lv9sUljtICAO8ga50ICLiaAiEktmomdc92X/MhQxNHAw4aPcNt9iYehzc?=
 =?us-ascii?Q?7v54c4XNRZAalQX9i8rLV0P04rF4cmxjdRtkEfUXxLLLHvqwOsygOvA0OAoB?=
 =?us-ascii?Q?1P2sV0XiPrBPXah9X7OTBAjYxPtrvOqCbgvFv18HAQo7Pz5Uk3fX1gHjrc3N?=
 =?us-ascii?Q?PfTfrtiadUh8uSkRKdSGeagZHvWVMxJwZoBqqMOFiFvwzvmOpqky/b3VUNEr?=
 =?us-ascii?Q?TcU4pepU9X+m3kHgm2MglMoC+VcO2u7/8S93dqH9/2gQQlBRWXwoB5RVl+l4?=
 =?us-ascii?Q?azAJVDxoiUlwETpiYoJTwc+8VvmvpoysRk9rg4U4EyEUiOJWjxKnM+24WATW?=
 =?us-ascii?Q?OuUtS7lBxLDXfttE1wAs4cyVALlqmGNDew0lWVFeRekw7aOCfVE8MTIJsIHh?=
 =?us-ascii?Q?Qxp7VmCN/RJMOAa7v0uQNK0UgffveIWXhSCYV1vzu4Rgq7QK/hwmVFJURo51?=
 =?us-ascii?Q?vrlFgasIVG/zN16XGO/hcRbsFSon0JgIwLndSywSAvyVwM8SWJ4ehT+K7Jry?=
 =?us-ascii?Q?eN6PUWl0HNhABPs0k6+4cw5xMHVLA+L+IpDKq64SdmJENJng/0WCHfR6xQf4?=
 =?us-ascii?Q?aABhV2iPrOBA1sAo0oTeXLHZvdwDNmKnvAQEX1BhRfWWaApFby26OH308U0s?=
 =?us-ascii?Q?L0ns3dza8sUs/ZLz/PderCp5yovMlUx9LS6TffO0G4Wo6w2yAT6+1a0TT2It?=
 =?us-ascii?Q?xCapuR76nA4CRia6ejmAdNsju9jNZX3kHp86nDki7q1abA3iyJt6dbDG3ZEf?=
 =?us-ascii?Q?5UqObcuV0MKU1sDKvmtH2JRadWQZL4XQ0Ab4vGgvICG7IHEXMAP48i7ndNuT?=
 =?us-ascii?Q?DNgpUwWzCDV8W7hlaAHCbVZyPwbczAmkfcScqgjUrJBCKMR2jCixe5/iBTXT?=
 =?us-ascii?Q?rQ7KwUhONQRRAbo21LRAbKOnU8i/gPGxueUyclhIA34xs8j4gy27FDi4E7pQ?=
 =?us-ascii?Q?a5zWpGeiUA7Cw1sdYvF+HR7v+jzBUFY7+LaT4iMzYStmyJ6EgbFfedZrL0n8?=
 =?us-ascii?Q?I28NqU2lJJyOGACWWX3K/WfWDtXdY8JFMzDBX2Sm06wq6Tsb+U8ae+YkoiAK?=
 =?us-ascii?Q?Gt0Y7yHqumGcrzUmXzQ/7q370EflQo46Ft7bnheh+AE8J+qpMruSkqhBS5FU?=
 =?us-ascii?Q?w6Oq4fDmkIeyJ93j1Aw=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0319b694-fbbf-4ed0-aede-08dc858a182d
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 18:05:33.8432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: V08tGu04nPFoB8QDgQsT5CeNqZoesHSvcRfrVf22hbyGwb+1hCYTnKa7oIbZYaapmbr9FzJ4qnS498ADRLbO7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6832

On Fri, May 24, 2024 at 07:26:52PM +0100, Dave Stevenson wrote:
> From: Stefan Wahren <stefan.wahren@i2se.com>
> 
> In preparation to support more platforms pass the dma_chan to the
> generic functions. This provides access to the DMA device and possible
> platform specific data.

why need this change? you can easy convert between dma_chan and
bcm2835_chan.


> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  drivers/dma/bcm2835-dma.c | 24 ++++++++++++++----------
>  1 file changed, 14 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
> index e2f9c8692e6b..aefaa1f01d7f 100644
> --- a/drivers/dma/bcm2835-dma.c
> +++ b/drivers/dma/bcm2835-dma.c
> @@ -288,12 +288,13 @@ static void bcm2835_dma_desc_free(struct virt_dma_desc *vd)
>  }
>  
>  static bool
> -bcm2835_dma_create_cb_set_length(struct bcm2835_chan *chan,
> +bcm2835_dma_create_cb_set_length(struct dma_chan *chan,
>  				 struct bcm2835_dma_cb *control_block,
>  				 size_t len, size_t period_len,
>  				 size_t *total_len)
>  {
> -	size_t max_len = bcm2835_dma_max_frame_length(chan);
> +	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
> +	size_t max_len = bcm2835_dma_max_frame_length(c);
>  
>  	/* set the length taking lite-channel limitations into account */
>  	control_block->length = min_t(u32, len, max_len);
> @@ -417,7 +418,7 @@ static struct bcm2835_desc *bcm2835_dma_create_cb_chain(
>  		/* set up length in control_block if requested */
>  		if (buf_len) {
>  			/* calculate length honoring period_length */
> -			if (bcm2835_dma_create_cb_set_length(c, control_block,
> +			if (bcm2835_dma_create_cb_set_length(chan, control_block,
>  							     len, period_len,
>  							     &total_len)) {
>  				/* add extrainfo bits in info */
> @@ -485,8 +486,9 @@ static void bcm2835_dma_fill_cb_chain_with_sg(
>  	}
>  }
>  
> -static void bcm2835_dma_abort(struct bcm2835_chan *c)
> +static void bcm2835_dma_abort(struct dma_chan *chan)
>  {
> +	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
>  	void __iomem *chan_base = c->chan_base;
>  	long int timeout = 10000;
>  
> @@ -513,8 +515,9 @@ static void bcm2835_dma_abort(struct bcm2835_chan *c)
>  	writel(BCM2835_DMA_RESET, chan_base + BCM2835_DMA_CS);
>  }
>  
> -static void bcm2835_dma_start_desc(struct bcm2835_chan *c)
> +static void bcm2835_dma_start_desc(struct dma_chan *chan)
>  {
> +	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
>  	struct virt_dma_desc *vd = vchan_next_desc(&c->vc);
>  	struct bcm2835_desc *d;
>  
> @@ -533,7 +536,8 @@ static void bcm2835_dma_start_desc(struct bcm2835_chan *c)
>  
>  static irqreturn_t bcm2835_dma_callback(int irq, void *data)
>  {
> -	struct bcm2835_chan *c = data;
> +	struct dma_chan *chan = data;
> +	struct bcm2835_chan *c = to_bcm2835_dma_chan(chan);
>  	struct bcm2835_desc *d;
>  	unsigned long flags;
>  
> @@ -566,7 +570,7 @@ static irqreturn_t bcm2835_dma_callback(int irq, void *data)
>  			vchan_cyclic_callback(&d->vd);
>  		} else if (!readl(c->chan_base + BCM2835_DMA_ADDR)) {
>  			vchan_cookie_complete(&c->desc->vd);
> -			bcm2835_dma_start_desc(c);
> +			bcm2835_dma_start_desc(chan);
>  		}
>  	}
>  
> @@ -594,7 +598,7 @@ static int bcm2835_dma_alloc_chan_resources(struct dma_chan *chan)
>  	}
>  
>  	return request_irq(c->irq_number, bcm2835_dma_callback,
> -			   c->irq_flags, "DMA IRQ", c);
> +			   c->irq_flags, "DMA IRQ", chan);
>  }
>  
>  static void bcm2835_dma_free_chan_resources(struct dma_chan *chan)
> @@ -682,7 +686,7 @@ static void bcm2835_dma_issue_pending(struct dma_chan *chan)
>  
>  	spin_lock_irqsave(&c->vc.lock, flags);
>  	if (vchan_issue_pending(&c->vc) && !c->desc)
> -		bcm2835_dma_start_desc(c);
> +		bcm2835_dma_start_desc(chan);
>  
>  	spin_unlock_irqrestore(&c->vc.lock, flags);
>  }
> @@ -846,7 +850,7 @@ static int bcm2835_dma_terminate_all(struct dma_chan *chan)
>  	if (c->desc) {
>  		vchan_terminate_vdesc(&c->desc->vd);
>  		c->desc = NULL;
> -		bcm2835_dma_abort(c);
> +		bcm2835_dma_abort(chan);
>  	}
>  
>  	vchan_get_all_descriptors(&c->vc, &head);
> -- 
> 2.34.1
>