Received-SPF: pass (google.com: domain of linux-kernel+bounces-203057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 5 Jun 2024 14:28:38 -0400
From: Frank Li <Frank.li@nxp.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>
Cc: Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>,
	Vinod Koul <vkoul@kernel.org>, Maxime Ripard <mripard@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Brown <broonie@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Vladimir Murzin <vladimir.murzin@arm.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	Serge Semin <Sergey.Semin@baikalelectronics.ru>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
	iommu@lists.linux.dev, linux-sound@vger.kernel.org
Subject: Re: [PATCH 16/18] drm/vc4: Use phys addresses for slave DMA config
Message-ID: <ZmCuVtXrwDxbkqAR@lizhi-Precision-Tower-5810>
References: <20240524182702.1317935-1-dave.stevenson@raspberrypi.com>
 <20240524182702.1317935-17-dave.stevenson@raspberrypi.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240524182702.1317935-17-dave.stevenson@raspberrypi.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?f4JppEpsVHNRidpszQ7pTvwzJRWL10VYJD2WmA8+GmMvyvWj2nn24Y4AB7QT?=
 =?us-ascii?Q?8rcHZU5p/St5todaDrdw6+afB/edd2RX0H++qhMWIOyytRNLp3GIOMqIZ66I?=
 =?us-ascii?Q?5eKwJbQOKR0+8ZRrEEEJFGQFL4vZzuts/m3zkhnoOWz+N47k1XwGpzAQfDA5?=
 =?us-ascii?Q?GgFCaXB4XvfhtbfnINrDjemoWIe6ZY3IFYelVNyodUvWFe7LS6ETmkO643Wn?=
 =?us-ascii?Q?v1PXF9OS6antgU9DJELqZJ1VuN6YwC6+Zs2LNIligCH+f+WbCLSBb0l4/v52?=
 =?us-ascii?Q?Qm2gkZzKnaE0izOU2jml5nUI+Whg2ajr7az87rp+xZZzvl54oULRonSJ1PLn?=
 =?us-ascii?Q?itEX1BDpqWNByR27s/4RnrP6DELosWA9JoaxYeeiW4+pgjQP6iYGxbtn0ouH?=
 =?us-ascii?Q?O0oKzQUGJeV8vw03o0hdJYKaZmTbJz2qIfzAT7RCfwNw1W5ULJ16jXKO2KZf?=
 =?us-ascii?Q?2RaLkr6bgFwfnx9Glz0sP+XTkVnUS58mVtizJzDWeY/Z92w5MEXnvtne0knH?=
 =?us-ascii?Q?h1UekqZvxBXz16gIpYxEkHJePFcOqQxBxiHeEASTUXv5on+MwsyKMrwbF+ud?=
 =?us-ascii?Q?lcNWmrDYkluh+wexotmY3ywOf0QRZOf3t+38Fv3KR3TSGxEOu7m0cJBYMOek?=
 =?us-ascii?Q?F3oKwAPV+vYcPyEEbJL1voA0R8FWmomm8xafFljnPMiMyUyA+GN6muU77upp?=
 =?us-ascii?Q?YCdKd2GXayj+5W5+YFcz7DFCdLEgW8XOVS5VUfjwyWogL1F9pOuBXjSNGKG4?=
 =?us-ascii?Q?5JXxqDiWMPGyU5bQpk3nQqo5SVBWPMjGRUAgwr0J8uvG6BuK5DMfVbCxy1DP?=
 =?us-ascii?Q?pSy767LctEB3+tGNQxrVEX1XA9NdZJPZLozSxmAKKhCl23BoIUBurCQeALGz?=
 =?us-ascii?Q?68wUPfaktJMQ1Ru9C0eJAUc0Mpd9PtE3R3cNZUpw3OtGHYpbit3zYN31WO3H?=
 =?us-ascii?Q?MgAQBWElE3Lqm2fhGPuZHxknxVvQFBsJ3d0aKlhPUmaXPavyH4iBdOnV9OFi?=
 =?us-ascii?Q?qXqKsdF2DJDxXtu77MCYDML/NtAY32+jluLvJR9U4pBuML7UIiBc2XjobN90?=
 =?us-ascii?Q?42yxq+hVEbVVNQhOyeFjvMXEqd5NXCcxixVKj+XUuDIvx1tNrnssWiTi2M8j?=
 =?us-ascii?Q?tqTMKd8ZYOc2m3+j7ty2qcu3aCmeik9dq6g8Y4XcK0egzEzWx7/AmIajmBpQ?=
 =?us-ascii?Q?tKg8TC0twXwyd+dYmBdpeUWL92DYpG8abdTALLBRXBsnDKX0HcXImzfPsZWh?=
 =?us-ascii?Q?vIswlZcXDyWz5WPAfzx6oTly1xVbLb3JKta/a1i5hEiN+IKspfLihvDv7Fym?=
 =?us-ascii?Q?N1LOCQywlr//dZka/CIAZOiarWp1JZrHswaGyWir2oow+heQaj9+BSa8jEMg?=
 =?us-ascii?Q?BBesC2gTljxtAs/m3jgS7nOGk//L9w65Hw7DiyJ0KkRYW7zMaRnOW6BjPGGh?=
 =?us-ascii?Q?ryoBDBYT1Phk8VQQdmGUH/l8quk0NjYNUqsryIcgaLf6QHTsmok0emXNxYMr?=
 =?us-ascii?Q?LVBzoK+0Vhh6NfXuGEM2qgncaOvBXmAnqs0LOoHJcrY0jValEfgp0JgeOXNS?=
 =?us-ascii?Q?hX0h0O73OPfcmvUlzf6BO8Y4HjDUudjOlw5pte4G?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef87de64-a382-48ab-ceb0-08dc858d594d
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 18:28:51.5877
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jlDT/6XeYhA/R7WmhgCKJWO6H4F69joibEF5AOMLo+zd2LlAwdpoO+OCOYspKBL4D+mFbD55Ir0jy9zc10IWJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7906

On Fri, May 24, 2024 at 07:27:00PM +0100, Dave Stevenson wrote:
> From: Phil Elwell <phil@raspberrypi.com>
> 
> Slave addresses for DMA are meant to be supplied as physical addresses
> (contrary to what struct snd_dmaengine_dai_dma_data does).

Can you use the same content for patch 14-17?

Frank

> 
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index d30f8e8e8967..c2afd72bd96e 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -2696,7 +2696,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
>  	struct snd_soc_card *card = &vc4_hdmi->audio.card;
>  	struct device *dev = &vc4_hdmi->pdev->dev;
>  	struct platform_device *codec_pdev;
> -	const __be32 *addr;
> +	struct resource *iomem;
>  	int index, len;
>  	int ret;
>  
> @@ -2732,22 +2732,15 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
>  	}
>  
>  	/*
> -	 * Get the physical address of VC4_HD_MAI_DATA. We need to retrieve
> -	 * the bus address specified in the DT, because the physical address
> -	 * (the one returned by platform_get_resource()) is not appropriate
> -	 * for DMA transfers.
> -	 * This VC/MMU should probably be exposed to avoid this kind of hacks.
> +	 * Get the physical address of VC4_HD_MAI_DATA.
>  	 */
>  	index = of_property_match_string(dev->of_node, "reg-names", "hd");
>  	/* Before BCM2711, we don't have a named register range */
>  	if (index < 0)
>  		index = 1;
> +	iomem = platform_get_resource(vc4_hdmi->pdev, IORESOURCE_MEM, index);
>  
> -	addr = of_get_address(dev->of_node, index, NULL, NULL);
> -	if (!addr)
> -		return -EINVAL;
> -
> -	vc4_hdmi->audio.dma_data.addr = be32_to_cpup(addr) + mai_data->offset;
> +	vc4_hdmi->audio.dma_data.addr = iomem->start + mai_data->offset;
>  	vc4_hdmi->audio.dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
>  	vc4_hdmi->audio.dma_data.maxburst = 2;
>  
> -- 
> 2.34.1
>