Received-SPF: pass (google.com: domain of linux-kernel+bounces-203059-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <77e34b55-b114-e807-b81e-a5525350e547@quicinc.com>
Date: Wed, 5 Jun 2024 11:31:26 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v3] drm/msm/a6xx: use __unused__ to fix compiler warnings
 for gen7_* includes
Content-Language: en-US
To: Nathan Chancellor <nathan@kernel.org>
CC: <freedreno@lists.freedesktop.org>, Rob Clark <robdclark@gmail.com>,
        "Sean
 Paul" <sean@poorly.run>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        "Dmitry
 Baryshkov" <dmitry.baryshkov@linaro.org>,
        Marijn Suijten
	<marijn.suijten@somainline.org>,
        David Airlie <airlied@gmail.com>, "Daniel
 Vetter" <daniel@ffwll.ch>,
        Connor Abbott <cwabbott0@gmail.com>, <dri-devel@lists.freedesktop.org>,
        <seanpaul@chromium.org>, <quic_jesszhan@quicinc.com>,
        Rob Clark <robdclark@chromium.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20240605003829.4120343-1-quic_abhinavk@quicinc.com>
 <20240605180553.GA2457302@thelio-3990X>
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
In-Reply-To: <20240605180553.GA2457302@thelio-3990X>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Nathan

On 6/5/2024 11:05 AM, Nathan Chancellor wrote:
> Hi Abhinav,
> 
> Just a drive by style comment.
> 
> On Tue, Jun 04, 2024 at 05:38:28PM -0700, Abhinav Kumar wrote:
>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>> index 0a7717a4fc2f..a958e2b3c025 100644
>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c
>> @@ -8,19 +8,15 @@
>>   #include "a6xx_gpu_state.h"
>>   #include "a6xx_gmu.xml.h"
>>   
>> -/* Ignore diagnostics about register tables that we aren't using yet. We don't
>> - * want to modify these headers too much from their original source.
>> - */
>> -#pragma GCC diagnostic push
>> -#pragma GCC diagnostic ignored "-Wunused-variable"
>> -#pragma GCC diagnostic ignored "-Wunused-const-variable"
>> +static const unsigned int *gen7_0_0_external_core_regs[] __attribute((__unused__));
>> +static const unsigned int *gen7_2_0_external_core_regs[] __attribute((__unused__));
>> +static const unsigned int *gen7_9_0_external_core_regs[] __attribute((__unused__));
>> +static struct gen7_sptp_cluster_registers gen7_9_0_sptp_clusters[] __attribute((__unused__));
> 
> Please do not open code attributes. This is available as either
> '__always_unused' or '__maybe_unused', depending on the context.
> checkpatch would have warned about this if it was '__attribute__'
> instead of '__attribute'.
> 

Thanks for the note. Let me update the patch to use __always_unused.

> Cheers,
> Nathan