Received-SPF: pass (google.com: domain of linux-kernel+bounces-202958-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6c4a508382d7f485c87814152282679aff120f86.camel@linux.intel.com>
Subject: Re: [tip: sched/core] sched/balance: Skip unnecessary updates to
 idle load balancer's flags
From: Tim Chen <tim.c.chen@linux.intel.com>
To: linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>, Chen Yu
	 <yu.c.chen@intel.com>, Vincent Guittot <vincent.guittot@linaro.org>, 
	x86@kernel.org, Mohini Narkhede <mohini.narkhede@intel.com>
Date: Wed, 05 Jun 2024 10:07:33 -0700
In-Reply-To: <171759927306.10875.2450909647126184930.tip-bot2@tip-bot2>
References: <20240531205452.65781-1-tim.c.chen@linux.intel.com>
	 <171759927306.10875.2450909647126184930.tip-bot2@tip-bot2>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-3.fc36) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-05 at 14:54 +0000, tip-bot2 for Tim Chen wrote:
>=20
> Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Reviewed-by: Chen Yu <yu.c.chen@intel.com>
> Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> Link: https://lore.kernel.org/r/20240531205452.65781-1-tim.c.chen@linux.i=
ntel.com

Peter,

Thanks for putting the patch in tip.

Can you also also add=C2=A0

Tested-by: Mohini Narkhede <mohini.narkhede@intel.com>

Thanks.

Tim

> ---
>  kernel/sched/fair.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 63113dc..41b5838 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -11892,6 +11892,13 @@ static void kick_ilb(unsigned int flags)
>  		return;
> =20
>  	/*
> +	 * Don't bother if no new NOHZ balance work items for ilb_cpu,
> +	 * i.e. all bits in flags are already set in ilb_cpu.
> +	 */
> +	if ((atomic_read(nohz_flags(ilb_cpu)) & flags) =3D=3D flags)
> +		return;
> +
> +	/*
>  	 * Access to rq::nohz_csd is serialized by NOHZ_KICK_MASK; he who sets
>  	 * the first flag owns it; cleared by nohz_csd_func().
>  	 */