Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp498410lqr; Wed, 5 Jun 2024 11:59:19 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWIqSooM55769KVXwA3a5yF3s6EBTq9Si3vpLd5zMyXmDLnyAjuAZzw81SycaTFbJ6Lf5tpTzhpQQ3IREOioFUsc7wIhsz9oj+NrrKf6Q== X-Google-Smtp-Source: AGHT+IHdrraq2pvYMnN6wabUKvgutKs6TkI2QNZgLEgOyZpF81gcrqo6tgSxUIfe6ePAW+NxJF5f X-Received: by 2002:a17:902:e84e:b0:1f6:77e3:774c with SMTP id d9443c01a7336-1f6a5a1931amr43438585ad.38.1717613959612; Wed, 05 Jun 2024 11:59:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717613959; cv=pass; d=google.com; s=arc-20160816; b=xfsaHKLWTRTWf31GgAuBxYa4TPWC/xSoQyU9zRkcrI/1oml5LczuI0rFUjuhjs3yBe z6lFq0bWFIxvO/0JW5ca4A3DkC8RtpjNwEqYt6rk5RFj49gsblZyXPn8o1+JuOCS1ZmC QSMLgRF9OTfbW2zI6+t1gG5rNeYpLl/ta3kiTNcoFzkaiNMYFRwD3KuceIRyIcAsh9yO 0CT71oXsDQqF7t6MEXpmmLPJ9nW/JGDjWLma4ge0bcOXmGnzjpEu6RC/y2ju4t+dNMBb urRJFy+oQ69/V8w3EoFN0EJAZkZmRi+eYyn520JUwq+iaGPnkxQTrohyLlC7ZEVS4MhV 2+sw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CSa4bOQTR2+W/Prz7ymLMO3YY1eDglyGK50TP/ZGYGg=; fh=7FAy3EhuU6E3DBdcB6FnBppBKHyXRfcHbSsGmAlkLss=; b=dtFMeEykpvzB2KpFUJkpjCAz8gdZZ2IMj58nWOJPlns2mHTWaV0GXtGe4Euzwjxq42 WBU54gfjj69h/rAyApnISNGeNQ4ysZhG7V1yxxzu/NZ5gecRPOARyVX9iAE+fi33Rzb+ AqWWEFm1qGX9xYup6MewtZGATi0Jl/wyzKi3Z/dKeTMMzXXI4WSi0gRJeMH6v+Ss/8tA IS94HFPbxSnIozFqW4SrUmf/VSA5fNwcdRXooJFwIb5ECr3qcQK+hDEiB63nSV8N9tWU ZIN4qEPM3oBqXEe+uXUhlzilmMdpkebRyS+3lS7HN46+0BSWOxJA+8Yo4LVWGmAgukFt K0Vw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R0vWrlMl; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203081-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203081-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f63236663esi47362875ad.171.2024.06.05.11.59.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 11:59:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203081-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=R0vWrlMl; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203081-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203081-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DD9D228683E for ; Wed, 5 Jun 2024 18:59:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AB3313C3CA; Wed, 5 Jun 2024 18:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="R0vWrlMl" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 606D413AA3F; Wed, 5 Jun 2024 18:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717613933; cv=none; b=mdRJPICjVI8NZ7sPVnHx6suMUCvCQPLOK7Pok9Fn8Pjuwr7Qjyc/Bx8IeHnzO/F9xsOLARgZvHXj2QWss/t0x+9tcqFExMGlewWvlFERbAAloWhDcgYMkhuAewiUhqdVnYzUDvylOB2XuFcCfyDJ4YJaGAKoLT3eLzFXlzi42ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717613933; c=relaxed/simple; bh=w1G9Oy3BR84r7WDCDEjU/smytorKBoYjKrur2nAtEeY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ACO5C5Pq2W9WIBpE/JDvcJ/dMWI2KVByHQODmXtPnES/oWkKOy2nvnvYk0bhquwiSfOdV+eKR5KpF1G7Q4e4dLtcYeq03JGPEx9kHLv56mYYu6ea5dRDo8I+jEokTDMsbTRxMY4bOTDurP0q/gycIw8V+PBu0x/15sTk0/6W2gY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=R0vWrlMl; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F6EEC32781; Wed, 5 Jun 2024 18:58:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717613933; bh=w1G9Oy3BR84r7WDCDEjU/smytorKBoYjKrur2nAtEeY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R0vWrlMlRj4c1iScujbH5fsyGqtYPyP+/J0VJNX4ix9iLi62oUIDLwnohofDukOsm EySt6P4ujd48YhL2UYG1uzc4Egw4XJ/Gat/kQnIYtrwMj9VK1pQ1iwtCgWoqx7nPkB PZVgPcg9IRc5rTwGSokHOze9XEZcuLIKMIAf0rgODSqbuA22uVD3u5Z4IxtPfj4Ued /0TKGZ9XHvVYRSiARf9kxsXjAkMwZwEq3dyoFhMlWj7SezQ8aufULPgYgxYi73afkn 9B1uaZjQad5b6KKyX/eyu7v+PaN4v3hEoBatvmlumA64STa6ptiYuyzGjNBCGL60GP SdVOEIoS6KjwQ== Date: Wed, 5 Jun 2024 19:58:48 +0100 From: Simon Horman To: Aleksandr Mishin Cc: M Chetan Kumar , Loic Poulain , Sergey Ryazanov , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH net] net: wwan: iosm: Fix tainted pointer delete is case of region creation fail Message-ID: <20240605185848.GV791188@kernel.org> References: <20240604082500.20769-1-amishin@t-argos.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240604082500.20769-1-amishin@t-argos.ru> On Tue, Jun 04, 2024 at 11:25:00AM +0300, Aleksandr Mishin wrote: > In case of region creation fail in ipc_devlink_create_region(), previously > created regions delete process starts from tainted pointer which actually > holds error code value. > Fix this bug by decreasing region index before delete. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: 4dcd183fbd67 ("net: wwan: iosm: devlink registration") > Signed-off-by: Aleksandr Mishin Reviewed-by: Simon Horman