Received-SPF: pass (google.com: domain of linux-kernel+bounces-203077-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <f5b9aa86-f8a2-49ac-bc7c-7121a1bdb342@amd.com>
Date: Wed, 5 Jun 2024 13:41:36 -0400
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, Guenter Roeck <linux@roeck-us.net>,
 x86@kernel.org, Mario Limonciello <mario.limonciello@amd.com>,
 linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 3/8] hwmon: (k10temp) Check return value of
 amd_smn_read()
To: Borislav Petkov <bp@alien8.de>
References: <20240523-fix-smn-bad-read-v3-0-aa44c622de39@amd.com>
 <20240523-fix-smn-bad-read-v3-3-aa44c622de39@amd.com>
 <20240605122012.GXZmBX_KFQArXB9Lar@fat_crate.local>
 <7a7c2f41-1608-4348-9183-d99aaa51398e@amd.com>
 <20240605161236.GIZmCOdP-CRPJ8-3sY@fat_crate.local>
 <e17b38fe-97cb-4559-be97-36af0ab14789@amd.com>
 <20240605164505.GKZmCWEROq9QByGDRn@fat_crate.local>
Content-Language: en-US
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240605164505.GKZmCWEROq9QByGDRn@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aWttQ3QrQTJGRHJkMDRBUFZGMmh5Vk1EVVdZWDBtSWZtVUFFdnlvaVJJcE5N?=
 =?utf-8?B?ODJndEJLYURJcVlpTkFTNkx4Qk1uajU5ZmsrYWxUTytURWdVMUkzWHM5Vk84?=
 =?utf-8?B?ZjNHVW9QelZ0Q3hFNnFxc1NVVGhhWXQxVCtkbFdYc2kzQmZnaWtLTU4yWk9q?=
 =?utf-8?B?bnp5aDNIMWFpZkhhSjlBZjNkZEUyTFpKU2ZxT0MvU0hUcEpNUUQzRlFZOFhT?=
 =?utf-8?B?aVUrVkdBNm9zMU9YVUF0T3BDd3JraFhFQnNjWWZiTmN6Qk9SOTJuN1NodS9r?=
 =?utf-8?B?Mkd2QVBDUzZMWE05RGlmQTlPaHE0YlZ4TjVSRE1LeXBGK0xZMFlRVXNkZmtP?=
 =?utf-8?B?R3ZUUVZKVmMybmZEQTR4Qm9nM0szU3c1ZGx4Z3YyOUpaQTkxbHBWY1diWW9l?=
 =?utf-8?B?b242WExWUjRrZlM4R005UTlaK1dzRnVyNHhWVGdwVDRHNllmQ1V0ZjNjWGo2?=
 =?utf-8?B?b1JJOTRqYVhJY0FKbVVqTHZURy9RRmtZa0ZsSUptYVVpdmY5ZnVsQWZKa0pr?=
 =?utf-8?B?a29NTDFzNnROYWhyaFhFTURqbnZNQlpiZm9KRXdQaWh3Y2FmWG9XTTJ3dWpP?=
 =?utf-8?B?dnpnaUFybFBJQXVnVXlSc1cvTkt2ZHFMekM2WGt4alAwMXJLUk53SkJ6R096?=
 =?utf-8?B?V1pVWm9rQ0IrRFdLVU9wNmdBcHhzWmpJMTJkcWZhQVBaR29obkNScmZUSXpu?=
 =?utf-8?B?Y0V3Y09QbG9jKzVtWm5EVnBnTHMzUVI3OGFuMm1zcHRTUXBiSkx1Mno5ZHNC?=
 =?utf-8?B?N0dFKzVmeE1XY3NIL3VJN0pQSXpyZTlsclJCejJnZEFrTzV5aW5tR09oYWlJ?=
 =?utf-8?B?WXYrdmZuZVJxcFNlamhYRmJKL0dCcWpYVUlxSVQ0aytpTStNSnBDSXVyZkJR?=
 =?utf-8?B?dGFWMjcybHNMSTNYdC9OZXgxT3I2WE53d3BwMEJKb245TnI0T2Y3VVdKRE5G?=
 =?utf-8?B?aEhDV05QNmNoaHpBU0MvK29xdjRqbDFnMDF6MU5XWXVYZ3JveTk0ekY4RTZE?=
 =?utf-8?B?dlRabzFwN3Q2OVdXT1ZCK1U4Z2dkazcrWEZzTFl3NmJFcjkyMHhQbThHZXI2?=
 =?utf-8?B?ZVhFWTJDWEhSL0JjZ1pFeDUvcXEzNy9QZkRZdkdkQVBZcFMxVjI3ZVZ3SUFV?=
 =?utf-8?B?SWVpNXpObTFwd0tFbk54amJKNWdZdEswV0UycXpwSTNUR1M0dWpHblB5aWt6?=
 =?utf-8?B?WE5SSGlMeE9pZkNiTDhwVzNUcllHWitscG9XOVppNmtSR3krUjl3aUVEZG9J?=
 =?utf-8?B?ZlY5bHRFd1FGMjk1bE9vYXkrVHZHUXJ3YlVzMFhxSkVJMVVjcVBlTkkwcXJt?=
 =?utf-8?B?V2JlMW5McmZWN2FjYm8ydHBwaXhHMnQxU0JqSVd6S25JWE1sWGkzN0xVWmZV?=
 =?utf-8?B?RGpGdXA5aExmYmtUei9pajFHVG5UR2FFdFlMZTgxTGltZWc4cWp2c2FPS3or?=
 =?utf-8?B?VGE3TFQzaEQ1MUpuK1BJeDBIME5ndTZNazNscGEzUGhhNlBzZ2dlOGxsbkJW?=
 =?utf-8?B?c1hnOHE3WTZXT0VZNWpWWlhRUkp3TlV0VFNuZi9ST3VCaDZoMWdUV2ptQllt?=
 =?utf-8?B?MXZIb0pmaXh2MEgzZG1nRis2bG1QVEl5ZnBjWHFhWmtiSDdGblcvay9iNVpu?=
 =?utf-8?B?MjlHc0JmdzBMM0NIVG5NRlBXek00T0pEYitVVGJLZ0lhSXRHQ3k3M3ZpY1FD?=
 =?utf-8?B?UWdrRGc4d3M2bmx4bzY3MVEzT2ZEYXdvalRXeWEzVzN2V0RhLzNvY0pzTFU4?=
 =?utf-8?B?TEQ2N3ExNEd2bmRBVldFd2pwQWtaZTgrMDJUclVFWXBjb1JQQ0MydXBraTlM?=
 =?utf-8?B?ZDcreVVmemhCNGlKWnNpcWlDUnJpMk84eTF0SytwSEFXWEVpNjhTZ3ViSUdG?=
 =?utf-8?B?ajB3NEVpbkpNV1hSUXdlSFZJaVRaM0dENCtZb3AyYmI2bTcvSDRaV3AyNkth?=
 =?utf-8?B?TW9uekVSUXBDK0hiclRKd3oyWmg4VFFzTDZ1cGo5TzFZTW5YV3ZlY1dLWkdy?=
 =?utf-8?B?dWZDY3dCOUlYbkhXQk10T010UTNIdUpwYytwbWpxZWt0ZjNWRG1pT2NRSDM2?=
 =?utf-8?B?eEtzMHhTS25ibnF1cmVOejVTbDNycE0vdkNtbXE0bXZJcGNVZ2RkZ1YrTjhu?=
 =?utf-8?Q?N2leeWfvU94tgb3KUrtYemA64?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 596cae5b-7b07-47ae-d05c-08dc85907a6a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 18:51:15.7116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WyjYSJUCysOYuWMHdcYhDcoEwmndIleOKMOgCTe6pzt0+i4/NhWS/yCbPFYz5EWusCWa+s928Hil75QfMDZx8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4418

On 6/5/24 12:45 PM, Borislav Petkov wrote:
> On Wed, Jun 05, 2024 at 12:30:35PM -0400, Yazen Ghannam wrote:
>> "It fixes a problem like ... a hardware quirk ..."
> 
> I'm pretty sure that means a patch which sets a magic bit in some MSR or
> does something else to make the hardware work again. Errata fix and some
> other hackery we get to do from time to time. Or my favourite - fix
> a BIOS f*ckup.
>

Yeah, makes sense. I agree.

>> Most systems will return 0 for SMN addresses that are not accessible.
>> This is in line with AMD convention that unavailable registers are
>> Read-as-Zero/Writes-Ignored.
>>
>> However, some systems will return a "PCI Error Response" instead. This
>> value, along with an error code of 0 from the PCI config access, will
>> confuse callers of the amd_smn_read() function.
> 
> Yes, but it hasn't so far. It is all pretty-much, a hypothetical, "what
> if" thing.
> 
> Sure, if that error would cause a serious issue on some system, by any
> means. But just because it might potentially happen... Meh.
> 
>> But I think it's fine to drop the stable tag after reading through the
>> rules again. I'll do option 2 or 3 if there's interest for specific
>> branches. And the cherry-pick thing should be easy to do if all the
>> prerequisites are already upstream.
> 
> Just wait until some real issue happens. Otherwise, you'll be pretty
> much wasting time and energy.
> 
> And, btw, people should upgrade their kernels on a regular basis - not
> run old, Frankenstein backported crap and think they've got the best of
> both worlds.
>

Okay, no problem.

Thanks,
Yazen