Received-SPF: pass (google.com: domain of linux-kernel+bounces-203083-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <204e541d-ff48-487c-8f70-619f90f65635@intel.com>
Date: Wed, 5 Jun 2024 12:04:35 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] x86/fpu: Make task_struct::thread constant size
To: Ingo Molnar <mingo@kernel.org>, <linux-kernel@vger.kernel.org>
CC: Andy Lutomirski <luto@amacapital.net>, Andrew Morton
	<akpm@linux-foundation.org>, Dave Hansen <dave@sr71.net>, Peter Zijlstra
	<peterz@infradead.org>, Borislav Petkov <bp@alien8.de>, "H . Peter Anvin"
	<hpa@zytor.com>, Linus Torvalds <torvalds@linux-foundation.org>, "Oleg
 Nesterov" <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "Uros
 Bizjak" <ubizjak@gmail.com>
References: <20240605083557.2051480-1-mingo@kernel.org>
 <20240605083557.2051480-2-mingo@kernel.org>
Content-Language: en-US
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <20240605083557.2051480-2-mingo@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0kra0V1TnM5TTArMTVpd1NFUitBbUNUeEtyTE1SOWc0TFh2RFV3a1lzYkkv?=
 =?utf-8?B?TVRadjhMQlBGb212K3JOUEIyMTNkSE5udGhKNjgrK1Q2VnR2MUhFM0tGYWd0?=
 =?utf-8?B?dDVEWUdibU5aK3Joby9TNmhtZnpZR1gyM2FGN3NTbHpERUw5V01ic1BKYzdR?=
 =?utf-8?B?N0lvQnhsSmlHbFNuY3RsUGI3by8rUjFTUlMrRHd5c2s5U2NzQndKenlKRkwy?=
 =?utf-8?B?WFF0a2xqWG5rT2NJMHNDZHVsMHBqOEduY0ZVZlVESm5wekowM2UrL0Y4cjBM?=
 =?utf-8?B?N3Y1MU84REZzZDE2OCtOMmFEN3ZLL1Q1aWtwY0hHVWt0MENLQnlPTG9Ub3RM?=
 =?utf-8?B?MzNZK3hJR09oaEVuS05TakdrRHN4OTEza2x5dlAwamxaVklIZ2U3dDZWSW4z?=
 =?utf-8?B?QlVWS3VPNTl2cVN2ckttQTFUYmU4T3NFMGhqTTFwZlNPRDBkOVovQ3kyVjJG?=
 =?utf-8?B?OGY2VDlndVFnS1hYYTFOa1o4aTAvZDc1UGM5K2ZUT2c4TkNUY0FJNk5NcVF5?=
 =?utf-8?B?SzFHaG1RSGllbEU1VVFWWUNMczRNQzVBWUxDV1MyclovcXBiR1IzOUFwaGhs?=
 =?utf-8?B?eWdvUnZUSUxkcWJZMlR0U3Y3dXFiTEsxbmdRcWswVnVzdGIxdmVSbWlDTjY1?=
 =?utf-8?B?YmgrRlRsUU9zdjQrK2ZFb2tPcFE5akJsNDVnMGtxZVAvM3ZUOVV3VFhKaStQ?=
 =?utf-8?B?dVlVVXBmZ2ZDVHIzejc0eWMvQ0tJR1hhS3Y2Tm9pOXduM2t0WDA2RExPN3d1?=
 =?utf-8?B?OERnWS9UQWpvMTBZaEtCVEdmZXh1ditCdzU1cWFpdURvSmMvdEF0b1dCVG4v?=
 =?utf-8?B?Ky9kbm82NUJVSnpIT3ROOWpQdUdUbUNZVXJ5RHNqbm9IZnNwYndYV0E4K2Fx?=
 =?utf-8?B?cWlFMVZNSjdJMUdybUFzNENnSWlaYnprU2k0WWpRTC9FWTViczZScE5MNy9H?=
 =?utf-8?B?VUtHd2RXZFZYRDhpaTRYSWhYS3ZZdVlnWlpLRnoyb3NuN0dHUEpJNndsOG1t?=
 =?utf-8?B?aVlJZzRBQlRydkgwWGpaSCthUnR2emwybnB2Vm8vaUZ1cWRDNmhsUjRjbUZB?=
 =?utf-8?B?KzNBNG8rYTNvWDNyNWt3OVdxVFlWK1J0OGtLeHFlVndRMUNnU2lhSVlYL3Fq?=
 =?utf-8?B?SVpZTGdxZURjUmhzSUFpbmlaMmhVMzkrcUVJNVdIT0dzRUlxeTZiejFPcDV1?=
 =?utf-8?B?Ui92cnJ4ZUJ1cHBnS25JdysrNG16UVBLZDFYK3VXSkZGbWZ0dFBCODZwcXBE?=
 =?utf-8?B?cUdWMEZlWS9wbVhuUVpUdWFWVWxpWSs1Y0ZrSDMrd0pRczFxZWlqeUZYMW1F?=
 =?utf-8?B?RUk3TVVBYUk4L3F3eDNnN0R4cDlsVEkzdkJaeGxMdkNRRkd3QUtYcFY1Ym1n?=
 =?utf-8?B?NkMrTWtxSXZOdEFGRTB0SjN4enhlSVMzL0NWcG92UkJYeGZPS2JZUXYrNzk2?=
 =?utf-8?B?bTM5SlppMVlUZHhqVkdYdllZVFVPSkJ6WjlTR0hra0VldzMxOVlOWnF1Q0oy?=
 =?utf-8?B?dG5BcWRoV0V5MDlkYVBnVEtaK25mMXFPTGZJcXA0akovMldSUU10Q2lucTVj?=
 =?utf-8?B?ZmdnZFhXWG9ya0xaNmwzbTYrN3ViUUFWTUFnSkxRN0k4WFAwa3duYkxUZVlx?=
 =?utf-8?B?OGpZQTEveG9ESkVvck8wcG1xOGcvd2xyUTQvaGdFaWk1eURlNzNIN3VzeURQ?=
 =?utf-8?B?bnZjUU1MaXgxVlBGOXJDMkxVT0pnRTFZcVR0Q0Z2SnFXMStkSG85b2RPZ1Vm?=
 =?utf-8?B?Vmk4bnhTM1VTR3FkUVQ2TVBiNEdQSUJSMUpVUTVsNHhtQ1pDa3MzSjlxSk9o?=
 =?utf-8?B?UytTTTh2QjRjb2NlSjZtenJTR3Irelk5Tjc4WjFkZmhEQVN3UHUxa1NuMjBa?=
 =?utf-8?B?azhpNFEwa2JXZkw4bmxJWFgzRXBndlFXczdNYmRTRGtYSjVlcGkxMVlwMHVv?=
 =?utf-8?B?bHBnN2ZBTy81QWd4MzV6aU9HN045T1h2TVhlMnlVdkdQeCt2NWJoUE52Lzcw?=
 =?utf-8?B?NzA1cTFiWXRQTDZndi93bTZ5Wm9XTmF4bHBsYU9HdUVsYmZRL0dOd1JzSXlJ?=
 =?utf-8?B?cXhvZE8vamFveGFnUFV2MTIvbGpaSnhmS0Qva09JRlIwRnVKejF2TnFrKzh4?=
 =?utf-8?B?VC81Vm4rSSt4SjhxTjRMaHNtYllqUmNNdENhQ0lGY3dzOUNRUm9tekhXb0xB?=
 =?utf-8?B?cnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: eb6f2e15-b5bc-4483-8898-08dc85925929
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 19:04:38.9331
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E6E18JmLPXrkj06VRKWIIh3c09lda3lrzqvyhnd+AsQGxV3WsydR6LpF3wl1egU60e5d8x5ZMYt/Vq+PgfWwuCJuTui+OPyMW3oz9n1Sc8c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7498
X-OriginatorOrg: intel.com

On 6/5/2024 1:35 AM, Ingo Molnar wrote:
>   
>   /*
>    * Handler for when we fail to restore a task's FPU state.  We should never get
> - * here because the FPU state of a task using the FPU (task->thread.fpu.state)
> + * here because the FPU state of a task using the FPU (task->thread.fpu->state)

Just a nitpick:
	fpu::fpstate now points to the active FPU in-memory storage.

Thanks,
Chang