Received-SPF: pass (google.com: domain of linux-kernel+bounces-203108-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3af40110-98c6-41e2-bd19-29a999f3bdcf@amd.com>
Date: Wed, 5 Jun 2024 14:34:04 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 6/9] PCI/TPH: Retrieve steering tag from ACPI _DSM
To: Simon Horman <horms@kernel.org>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-doc@vger.kernel.org, netdev@vger.kernel.org, bhelgaas@google.com,
 corbet@lwn.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, alex.williamson@redhat.com, gospo@broadcom.com,
 michael.chan@broadcom.com, ajit.khaparde@broadcom.com,
 somnath.kotur@broadcom.com, andrew.gospodarek@broadcom.com,
 manoj.panicker2@amd.com, Eric.VanTassell@amd.com, vadim.fedorenko@linux.dev,
 bagasdotme@gmail.com
References: <20240531213841.3246055-1-wei.huang2@amd.com>
 <20240531213841.3246055-7-wei.huang2@amd.com>
 <20240604153028.GU491852@kernel.org>
Content-Language: en-US
From: Wei Huang <wei.huang2@amd.com>
In-Reply-To: <20240604153028.GU491852@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QjhTN1drdzcxYUhra0dPSk1wK1ZKTE5JdjNvbWNFakljMlZEK0NJQUc1WTVS?=
 =?utf-8?B?TWF5Nll0UFpvQ0VIS1UzbTRnNjk1R2E0SkV4VWhOUkxOTVUrT2NoeDJ2dU0w?=
 =?utf-8?B?M0RFSHAwKzRqVHkzRjQwZk8vWHJCQm9UYmVlYmZVeGFuZXdVZ1lDN1JyZkF6?=
 =?utf-8?B?Wk5kSW1NMWsxNHRaOVcxS0swSmVWdjh2VGtwQlpBaHBBMUJzVUJ5eDhmWFdM?=
 =?utf-8?B?OUkrZ3hZVnBVY0ZuRGF2R1NZTzhYcjlMVldvd3RjRDh4L0dxRXRKZUhGWjlQ?=
 =?utf-8?B?anZQNmNDRDdnYnNmaHFHRXp5K2M3MGY4YzdueWlzZDVNcG8zci9wU0ZXWXps?=
 =?utf-8?B?NUZneW9vSE13OWtieGZYSFk5RnJoSm91RXBDUlJnZ0ZrMy83eXlNK1VUcCt0?=
 =?utf-8?B?UmxvU0tNaGhrbVVHdDRXWVFubE9JaUNwditDWmtkckdiU0FNRmczL1NGZ0dH?=
 =?utf-8?B?Slk0OHlGaDFNeGJWSmV5aWJxL0ZtVndteEpVZm1QNCtMaXNlNEZaWE5EeTJw?=
 =?utf-8?B?NlkrTlJ3WTg3SFBKTytkQ1NMUGk1REVISndIUkgvUDNzNi9tMlZXdnQycW0r?=
 =?utf-8?B?MUUvNG1aOVphSnB3Y3M5Q3EyQWFlSUozTGNoUHFEQTk2cTdGRG9HVis2SFJT?=
 =?utf-8?B?ZFRXbUR2K0xORDhiRFcvN0gwRG1DTjRxMFZuellObkpWeU9EUlBOOVdjR2s3?=
 =?utf-8?B?N1VjZTFmbTNPZ1NleVU1QjlIK2ZNTXptcE4rYzBkcXFTazlkNXAzQXBrdCsw?=
 =?utf-8?B?eU5aa2FkMWNkV1ZYNVZ5V29OVG5MbitEcFRqY2lWd0Q5a1M3M1ZZSlpDMkxJ?=
 =?utf-8?B?cGV3Z0xseVZSUkcrNm9NWVlHQi9wRlF5YTZxdi9kcWNPY2V3bVhqR2ZoS2tF?=
 =?utf-8?B?d0E5cUJkLzkweTdlT1Rld2xEM3B4WEk4SEZVVnZlRzVJMVFDVVV4S1JsVi93?=
 =?utf-8?B?a1MyakYvQXBxUG1pZXdFZDZqVUpFcWVMZ2paMzc1YU5aZ3M1STJSamhNNmNK?=
 =?utf-8?B?YXFRNHFaQlZ5eUJiSjBhd1VETTJlL2xXNkxibzB5MVByMzFvSW1qc1JTWEEz?=
 =?utf-8?B?OE9Kb1crbHNkSGVYOXJ4Sjd2bVcrL2haQlpuNEsrak1GQS9qZlg4MEpRMUpH?=
 =?utf-8?B?MGIwd2FLNjRSMmM1Vmt6bDZLSnRzUEdoTTBrcjFvQXk5VE9zRTI1ME9VRW80?=
 =?utf-8?B?RFhqdmpMWkF4NnVlTDFZcjRNbXdJVTVSNU9ETTczbmgyOGJQVEJFYUJWK1Ez?=
 =?utf-8?B?UE56K3AxN2xLNlJ3NkYvN3RoMXFlb2NHUGVpQUlqUEpyNkc2OVJONHlBTVh4?=
 =?utf-8?B?NDZQMkNnMVkyY0p5U1I3SWt2dkJTc3Z1amlCZGN4cE9FTXVkZk15OUp2Unhp?=
 =?utf-8?B?am5GL0hyVG5qYUI0dTJka3dMZjlRZUY2dEsrL0FRZEtPdjdnVU9uRHQxZWlM?=
 =?utf-8?B?eDdHbE9JVzc4cTcwa2ZBUWdMUVFQaVNRVkhWTVR4d1NZbk5uWFhteE9JUW9M?=
 =?utf-8?B?SGVxR1A3M3crTjRlajc2UldyVUVsTG03aWNaTGl0TU9ZNnFhM2pJYlVFamJw?=
 =?utf-8?B?WTNWcFpsQ04rRmR3Y2s3MDcvZkVVRElzd0hGSUdBWVRWWEVpelkvMWMrdzEv?=
 =?utf-8?B?Yk4zekFlN0tDb0ovMTEyaU5ubEgwR1dtSjNzN2xmT2xoVHNNK1lGN2p2U0FU?=
 =?utf-8?B?QjBjZ2VXT0V6QjNCK3BaZGdtbkMxcXhISCtXY29GYUszYUJBOUxwNk9hU3Ev?=
 =?utf-8?B?Y3VwZUhaK1RGZ1lQa0VnWFk5L21ta0pDSWZjTm14OUhocnJadkpsYWZnYWd5?=
 =?utf-8?B?ZEtLZ3QxMkxqYTZzWkxabk9PR2JENkZsUis0Z2FHM1EvOEVIMGFLQ0JBWnlD?=
 =?utf-8?B?MWkzVDZTVGdtZzBSUDdVR3doamR0cW1XOTRsYnF3dUxjWUw4TnNNNzU5U0dE?=
 =?utf-8?B?OXF6NGRyNmdxdFRFVTBLZEpldDR3TzdLTzlTeTdzS0VVMGlLTkQ3YSt4MVhr?=
 =?utf-8?B?U3NKaGE5c3VLM2I4OVc4akl5Y0JxUWFVdklLQkxZRnZhQmhJKzl6ajcwWmNo?=
 =?utf-8?B?UEp0aS9qa1BmU1JUcFFiajdOdDlMM2pWSmJsU2FvWGljWlBxWm9QaTJ5OXhC?=
 =?utf-8?Q?y3jY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2474dc95-d3e3-4ae8-cc22-08dc859676a0
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4877.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 19:34:06.2887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gj/qJ5O6xjXOwCNwZ7QgA2GcmPJB2xnv+zlmbjqEJHo05Z428cLJvmOzN94ce7HQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8478


On 6/4/24 10:30, Simon Horman wrote:
> On Fri, May 31, 2024 at 04:38:38PM -0500, Wei Huang wrote:
>> According to PCI SIG ECN, calling the _DSM firmware method for a given
>> CPU_UID returns the steering tags for different types of memory
>> (volatile, non-volatile). These tags are supposed to be used in ST
>> table entry for optimal results.
>>
>> Co-developed-by: Eric Van Tassell <Eric.VanTassell@amd.com>
>> Signed-off-by: Eric Van Tassell <Eric.VanTassell@amd.com>
>> Signed-off-by: Wei Huang <wei.huang2@amd.com>
>> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> 
>> Reviewed-by: Andy Gospodarek <andrew.gospodarek@broadcom.com>
> 
> ...
> 
>> diff --git a/drivers/pci/pcie/tph.c b/drivers/pci/pcie/tph.c
> 
> ...
> 
>> +static bool invoke_dsm(acpi_handle handle, u32 cpu_uid, u8 ph,
>> +		       u8 target_type, bool cache_ref_valid,
>> +		       u64 cache_ref, union st_info *st_out)
>> +{
>> +	union acpi_object in_obj, in_buf[3], *out_obj;
>> +
>> +	in_buf[0].integer.type = ACPI_TYPE_INTEGER;
>> +	in_buf[0].integer.value = 0; /* 0 => processor cache steering tags */
>> +
>> +	in_buf[1].integer.type = ACPI_TYPE_INTEGER;
>> +	in_buf[1].integer.value = cpu_uid;
>> +
>> +	in_buf[2].integer.type = ACPI_TYPE_INTEGER;
>> +	in_buf[2].integer.value = ph & 3;
>> +	in_buf[2].integer.value |= (target_type & 1) << 2;
>> +	in_buf[2].integer.value |= (cache_ref_valid & 1) << 3;
>> +	in_buf[2].integer.value |= (cache_ref << 32);
>> +
>> +	in_obj.type = ACPI_TYPE_PACKAGE;
>> +	in_obj.package.count = ARRAY_SIZE(in_buf);
>> +	in_obj.package.elements = in_buf;
>> +
>> +	out_obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, MIN_ST_DSM_REV,
>> +				    ST_DSM_FUNC_INDEX, &in_obj);
> 
> Hi Wei Huang, Eric, all,
> 
> This seems to break builds on ARM (32bit) with multi_v7_defconfig.
> 
>   .../tph.c:221:39: error: use of undeclared identifier 'pci_acpi_dsm_guid'
>   221 |         out_obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, MIN_ST_DSM_REV,
>       |

Thanks for pointing it out. I will add "depends on ACPI" in Kconfig
which solves the problem:

$ make ARCH=arm CROSS_COMPILE=arm-linux-gnu- multi_v7_defconfig zImage
modules
  CALL    scripts/checksyscalls.sh
  Kernel: arch/arm/boot/Image is ready
  Kernel: arch/arm/boot/zImage is ready

> 
> I suspect a dependency on ACPI in Kconfig is appropriate.
> 
>> +
>> +	if (!out_obj)
>> +		return false;
>> +
>> +	if (out_obj->type != ACPI_TYPE_BUFFER) {
>> +		pr_err("invalid return type %d from TPH _DSM\n",
>> +		       out_obj->type);
>> +		ACPI_FREE(out_obj);
>> +		return false;
>> +	}
> 
> ...