Received-SPF: pass (google.com: domain of linux-kernel+bounces-203120-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com>
Date: Wed, 5 Jun 2024 21:46:37 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of
 MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead
To: paulmck@kernel.org, Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: open list <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>,
 lkft-triage@lists.linaro.org, Andrew Morton <akpm@linux-foundation.org>,
 Mike Rapoport <rppt@kernel.org>, Dan Carpenter <dan.carpenter@linaro.org>,
 Arnd Bergmann <arnd@arndb.de>
References: <CA+G9fYsGFerOtoxwpKLOYcRtyJkmgjdP=qg4Y5iP5q-4Lt17Lg@mail.gmail.com>
 <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop>
Content-Language: en-US
From: Jan Beulich <jbeulich@suse.com>
In-Reply-To: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 05.06.2024 21:07, Paul E. McKenney wrote:
> On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote:
>> The following kernel warnings are noticed on x86 devices while booting
>> the Linux next-20240603 tag and looks like it is expected to warn users to
>> use NUMA_NO_NODE instead.
>>
>> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead
>>
>> The following config is enabled
>> CONFIG_NUMA=y
> 
> I am seeing this as well.  Is the following commit premature?
> 
> e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES")
> 
> Maybe old ACPI tables and device trees need to catch up?
> 
> Left to myself, I would simply remove the WARN_ON_ONCE() from the above
> commit, but I would guess that there is a better way.

Well, the warning is issued precisely to make clear that call
sites need to change. A patch to do so for the two instances
on x86 that I'm aware of is already pending maintainer approval.

Jan