Received-SPF: pass (google.com: domain of linux-kernel+bounces-203129-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <621eb61c-87e1-417f-ad9f-f14d858ec8aa@intel.com>
Date: Wed, 5 Jun 2024 21:54:53 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] iwlwifi: mvm: adding check if the thermal firmware is
 running
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>,
	<miriam.rachel.korenblit@intel.com>, <kvalo@kernel.org>,
	<daniel.lezcano@linaro.org>, <johannes.berg@intel.com>, <dmantipov@yandex.ru>
CC: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240605195129.89353-1-trintaeoitogc@gmail.com>
Content-Language: en-US
From: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <20240605195129.89353-1-trintaeoitogc@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlNmV2pyVHhuVVVqN0FhUmEvZDdTZjVub2JPaG9QSFI0Um0yaEdOWXBzNGhQ?=
 =?utf-8?B?VmdoQVdoR2ZLUWtGeTk5SFRWVm4vOTRUc1d4RlZvd2tHL0kwOThoSzRWMXdN?=
 =?utf-8?B?SGd1YXFiWnlYVUhZQUswZVhyb1BpYkdTYk5LT1BoQkhsdk9vajI5VVQ3S1hG?=
 =?utf-8?B?R1BLVnEwSitwOHpRVXFFTDZVZ3VmbFhJWC9lU09UZU5COFdWbEg3Zm5OeXdN?=
 =?utf-8?B?N0wvaGdHZ1dLdVQ2emk4SHJhUnpyVnEweXBZODNXbkgwMkM0Vmg2bG42c1Zs?=
 =?utf-8?B?ZldYRSt2OE0xZW0zWGlHU0laVTJpUWJwcmd6ZFB1ZGZoREk2Q1ovTXFVOENx?=
 =?utf-8?B?YVJXMWZSWTlpVUR2TEhCQzlMdFV2RXBwbGtPMjM1a2ZxcW9xb3lhS2FhWWpj?=
 =?utf-8?B?aE5paGVSVWJWemRBK3JITXdiRWtQbWNBUi9aT05OaXNmRFAwdC90TzUwWDFR?=
 =?utf-8?B?aVY4Z0l0QnlMUDZjL2I3eDYreGVDY0V1eEhsVkJmbnZmMzNRTWdQSDJsS0lL?=
 =?utf-8?B?dE1kT2gyWms5Q2haNmhNR1VxMy8zQmZpQ29lbnQzQ2lNOG5iRHZtOFVXaVU5?=
 =?utf-8?B?UlN4WTBpKy92MHBYWXRzUDFjTVhGRG0weWFiQytkNEtjUGFnNFhibFk0bHhV?=
 =?utf-8?B?WC9DdlhnSFBqNHRrZXlSN05OSkcxcUhlbnQzeGFYZXJTOS9rOGRvVEdSeUxF?=
 =?utf-8?B?dUxXQngvLzdodHRsWkJzcUViY2oyZUdEUTV2UlZNSGV0VzM5L2xwVkdjRS9S?=
 =?utf-8?B?akkvZUxkY0lyYnZoOVBsaHR1RzIzZ3MwTnBSTzNsMEFlK2NqMnN4bElRdlpy?=
 =?utf-8?B?SW5XNlpaQzdKNEhSYm5nbG55UXovZnNWWnN6bDhmNGN1cFlxMGk3cXYrK2RJ?=
 =?utf-8?B?cmtoOUpyR2pMZXovZERrMkhUbkdwbDhzWnk0cG1IcXhybE9Sb3ZpVHhIZ05W?=
 =?utf-8?B?Z0cyQUw3YjNxOGNLUGlENzJqcTcrZm96dTZBWHFqSGRRL0JVOFdVU3d6V1NX?=
 =?utf-8?B?akFUcExLWlFtTXlNYnBQZ3AweDg1TGd4V0lBRG1hSHFCOU9lMWgxbU9nRnR2?=
 =?utf-8?B?Z1FxTkZNNnREWkRINUU1U3dDU3FidTh3Zjh0d3FVVHpORGgrUU43K09pUmhJ?=
 =?utf-8?B?Y1Rnb3AxR1FFR2poNHQ0ekRVSEszM1JBK0NUdkRWcHExT0NFc1V6SmpUSVVN?=
 =?utf-8?B?K0I1aElJSE1Hckl2WU1qOHdERUhDMGxyZFdwWWhSTklNRk5zaGVmZnVBMXZI?=
 =?utf-8?B?UWpiVCtTbGxaMmhaNHpsa0E1dkcyWnhEVS85RGdTbTJqNzdqdTNaN1REb2Ex?=
 =?utf-8?B?cjVHOHZwVUJ3ZVMyRFhTRFVYZXVFUmlKMEVCaHZZWmJpTWR5NXVPOWtJbTFD?=
 =?utf-8?B?Q1ZuZ2NMTWdLQVNZRnJlL3h3MUMrQ2YyZUVHclVUNWpSa0lmUG5RbkY5NGE1?=
 =?utf-8?B?dmduVW81eWF6ZlFoWFB3UitVY2pESFFHZzhjelBuWmtrRWJ3YXBFM3krRkI3?=
 =?utf-8?B?ZGo1cW9SeXBEWmswMmZTOUdiLytENXpzbkREczhpakhqNEtnSjY1UDB3NHBC?=
 =?utf-8?B?b1JyRHp0UVFCajlUdHhQTjdXWGFRbmovM0JmV3EyVmR4bDNIQ2pWbU1NWXA4?=
 =?utf-8?B?VjR1UVY1c0laU3RaSjJnMUZFZEVITUUydnZlVm80cFhaQTBqVmxRT0NyTWFp?=
 =?utf-8?B?KzNnZm9EcWRVbWdiUWdBTkhzbk5TUzkzS0RJWkZoelc0UFBIejl0ekJpb1pp?=
 =?utf-8?B?SDZIYnUxeW1ldzZrc05ZcWU0UXI1ZmVuN0JUSUs5NlJFZ2p6Z3YvSlY3VlpG?=
 =?utf-8?B?UmY0N0c1NVhJTkZYMWFickdQSUNGbGFUcWxvbmRodURtMUNONHBWOVhubU5Y?=
 =?utf-8?B?Z1UzbWEraDc1L0RtY05tZ3Y5ZGZuOGpKenh0Q25UejRUNklLc3dkSWpTMkZw?=
 =?utf-8?B?WmhMR1M3ZE9GM3FVVURYY2R6OGFjRDZUYWR6WDBQMDVqQTVjeXZIZXN6b25s?=
 =?utf-8?B?WHVLcDBHcEhva3BpUktFMmd0b1FtTTY5c2NwMEU4OUVNTm8vMSttdzRSc0o5?=
 =?utf-8?B?c09Ca0lFZkZtSTBGdWNkYnRVeXlVWEZ5Ym5xNHhXTkNWZW9TaURZL2p6N01T?=
 =?utf-8?B?TVcyaGtCTE1wckRxbXBCM3cyTWxlN0tlYWRRSEtxVnVFdnV4ZGdqaFp2R3JM?=
 =?utf-8?B?WWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c5bf6683-4bb4-4d7b-51d8-08dc859960f7
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 19:54:58.5585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r2dS9fxEPZUXm7RVazf3USzIbNBA6axOzbdEs/1gj+KhQHy54z+MAN0Npu8sof0Lm3FFORgnBlwevTr6skgGfxhBMPG5bpf61Etrzc3G8OA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6339
X-OriginatorOrg: intel.com

On 6/5/2024 9:51 PM, Guilherme Giacomo Simoes wrote:
> In the dmesg is showing the message "failed to read out thermal zone"
> as if the temperature read is failed by don't find the thermal zone.
>
> After researching and debugging, I see that this specific error is
> occurrenced because the thermal try read the temperature when is started,
> but the firmware is not running yet.
>
> For more legibiliti i change the tt.c for return EAGAIN when this was occurrence.
> After this change, in my computer I compile and install kernel in /boot
> and in my dmesg the message "failed to read out thermal zone" is not show
> any more.
>
> I would like to thanks for Rafael Wysocki <refael.j.wysocki@intel.com> ,
> Kalle Valo <kvalo@kernel.org> and Johannes Berg <johannes@sipsolutions.net>
> for your suggestions in my previous patch.
>
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
> ---
>   drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 10 ++++++++--
>   1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> index 8083c4b2ab6b..9aa9e3be39b8 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> @@ -620,8 +620,14 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
>   
>   	mutex_lock(&mvm->mutex);
>   
> -	if (!iwl_mvm_firmware_running(mvm) ||
> -	    mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
> +	int res = iwl_mvm_firmware_running(mvm);

Why do you need the res variable at all?  You can just call the function 
directly in the if () statement.


> +
> +	if (!res) {
> +		ret = -EAGAIN;
> +		goto out;
> +	}
> +
> +	if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
>   		ret = -ENODATA;
>   		goto out;
>   	}