Received-SPF: pass (google.com: domain of linux-kernel+bounces-203181-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <db20a640-5323-4866-9968-c57391fbb6bc@amd.com>
Date: Wed, 5 Jun 2024 15:32:33 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/3] ChromeOS Embedded Controller charge control driver
To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>,
 Dustin Howett <dustin@howett.net>
Cc: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>,
 Sebastian Reichel <sre@kernel.org>, Lee Jones <lee@kernel.org>,
 chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org,
 linux-pm@vger.kernel.org, Stephen Horvath <s.horvath@outlook.com.au>,
 Rajas Paranjpe <paranjperajas@gmail.com>
References: <20240528-cros_ec-charge-control-v2-0-81fb27e1cff4@weissschuh.net>
 <CA+BfgNJByawxkZukaCXYcmOo_K9aQ0W1x8B6Y+Hyg_fZaJ4axw@mail.gmail.com>
 <5baf3caf-dc09-4829-96db-2666fc902710@t-8ch.de>
 <CA+BfgN+LE3YyF3te4m8sWbtH85tU+ERUDW7YR_BFecusVTAWWw@mail.gmail.com>
 <a527a3fd-1458-43cc-aac0-0b360beeb349@t-8ch.de>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <a527a3fd-1458-43cc-aac0-0b360beeb349@t-8ch.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?eFg1a0k2Z1JGT1pJd1RIcFdOMGE4M29WMWdLcWJMeStlYmlVbnRKYitFSmwv?=
 =?utf-8?B?Tm5weDBIRWJ3ajhjUTN1MTZwc0N3Y05kUlVTcEpoN09QUmFhU2pvMXlZdTdH?=
 =?utf-8?B?TlBXYkJxR1BsOXRkVXd6S1d3a3JOdzM3OThZdTR6MmdRaUlOY0pCZUFKWGhq?=
 =?utf-8?B?aTVvOVR6U25VektqR2huUXVTRjRzRy80SzkyY3RCZWxwRW9adEhHUDhMV0g2?=
 =?utf-8?B?REdlanFKcGxXaThuekhCU0d3ZjZPUTU0Q1JaYURGRVZndmVxNVdqU0YxUGdu?=
 =?utf-8?B?ekJXSzdBWkl0U0VQUDlQZmlzT0xreG56ejE2R3NZZjIyNDZiWjNybVN3N041?=
 =?utf-8?B?NkpKYVIzK2tHRzI0cFYyZGpHNzhTU0RlMWdpRDZJUXZ4NllmZExYeUwrUk1u?=
 =?utf-8?B?TXhyREZ1ZXF1SUN5Q0pHVk9lbVliK3JLOU0zRE5wTVp4aTZKaHdWbnpBajZN?=
 =?utf-8?B?bTBzb3hrNW1lRUpyWHFSd3IyRmQ0OTF3ZmRTMld3VGJ5NXRqQVBtVHZTMjR3?=
 =?utf-8?B?S1hzTjgycjVuYTZPbmdKYWhuRiszUnpIbEVodDRGQU9Oai85Rm5MK0VDcWFQ?=
 =?utf-8?B?N2JTaXRQbSs1SEhueFp5SnozcERaZThxQ2lqZ1BGc1pIOW5wam9QUVBNY0Nn?=
 =?utf-8?B?cVB6bzU5VlQwOXFZSSs1S3plNjlkamZZTGg2WncvalRuUmhpRlk1ZUxqd0Iv?=
 =?utf-8?B?NXhuUGhISWNndVlJVG9USlQwM3V1Zko0T0szMXV4cTk4bE5nN2Z5TlpjMmta?=
 =?utf-8?B?NDM5Z2FGcHJuKzF2RmNsTnl1UCtWRk54a3E4YWJVMG9VWDBHU3BPUVhIeDBp?=
 =?utf-8?B?RXoyTzNqM3pZcGhQU09NcmhhenhYVWw0U0RML09DT0ttV3VWZjNOdklWSHhH?=
 =?utf-8?B?eVF4WDVPNWkzZkxlWEp1am9tT1JZaGU2RjJLc1J1OGVPM0FYNzExR2htN1NQ?=
 =?utf-8?B?QWhXT3I5UVhOdGRSeG5zUGtpUmNOZC9hU2RhSVRMUHJ6N2g3eityNktMUkdC?=
 =?utf-8?B?UGxNck1qb3dKZWJ4S1pxYjAzTG43YUtRVEo5a0lQOWttaS9XTEdXRm1ZOHd0?=
 =?utf-8?B?T3EzTVdxdFpnb1djODBZSlhPRGlza1MxSWxlN2VGREhGa1V2YnNadWJEa2hB?=
 =?utf-8?B?N3I4cTFvbXZNcHJSSnlxU3Z2WDBnRlVBc1lQUkR6RytGSUJqaDRFVDRoS2RF?=
 =?utf-8?B?eVhvNTFpQ3JoM1ZXaFl2K283WTgrcXRyV1FIelhIUDVlVkdUL00yRFMxVHIr?=
 =?utf-8?B?TzlCUHhnSWU5Y0VsN1hyMmZzZ3RXd0FvYjRmMG1IWXRSV1FCWXJibnhZMGxu?=
 =?utf-8?B?UkFJWHFPUGpBaCtxVFF4YUQ2bFJiNHFMVm9qZkFuZm5IN2Q3dVdCUytlOEF4?=
 =?utf-8?B?TGUwZWwyNFQ4eTdCVWJvSmxDU1Fid1F3OCtkMzBZMUl3TkJqcG1IcTlHM3Iz?=
 =?utf-8?B?ZTNLa1hTajVLZjN1S2JYUDUvVSt3SWQzTm9ydVFYeFpRNUl5Q084czhSY2tO?=
 =?utf-8?B?aE43QWdSYXdzRDVPakRSSHdtQ2xOcjZkQ1VqbDVLUkwyL1loZGhDaXlPb0NF?=
 =?utf-8?B?NzNhbGV3cXJLZk43YStFU0JKK0NnVExVckwrV0ZHT1AzekNjSEx1OWdwSG4v?=
 =?utf-8?B?a1M0K1NaQ3FFTXpDcDhVME8xYkZDK2MyMmFHQy9KcmlxcDlITU1YZTcrbURl?=
 =?utf-8?B?cDk0aDRhZWFFQkUyQ0NqYnpwM1ZVN2ZsUUhqdEZIZzYyUHlDQWlma0pVVk9P?=
 =?utf-8?B?TkZGM1kzWE5FbEZONERLRmlKM2ZtbUF4c1FJSjNoK1VnaU9UcmVwOFJOK2xW?=
 =?utf-8?B?TkQ3NHZTZU1sTVJxM00rMWlTZzNlUG5wRGFiZDdlWjFRTmp6V2IrN2R6c2J2?=
 =?utf-8?B?Y1FJK2pTNldxbUpYZnpTVG5VbDFsYnpFWG9iOUd6aVpCc3NmL3ByZTZ2dWFu?=
 =?utf-8?B?QmozeHlzdkh0cmZhOEdUVlJCWlFVbFU0ZUNuNGdWK2FXSjRHU2QxYVdLZkRm?=
 =?utf-8?B?d3NtRUt4VTNjSk8wUmorMnQ2R3NHM3FWNWkvMEkxMkdiRVZzMzdaaWxWOFp4?=
 =?utf-8?B?S0FJcWhFSTMrTWtFNkpUV2daQnFxLzRKQklzaDFJZUZEcS83M21aK3NXL0Na?=
 =?utf-8?Q?JTRFw3ZPwXHZD7Zg9wXFwcECq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f10d5edf-66d2-4453-6f78-08dc859ea2fa
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 20:32:36.6898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P68WWfWwrVfLGAbZpb8KxkrAFBbFAvS+WJk/1NY3CWjKk2r3PGbRlybvbB135lLM4QNXq81PqfUO3CrDpliY0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7868

On 6/5/2024 04:33, Thomas Weißschuh wrote:
> On 2024-06-04 20:27:57+0000, Dustin Howett wrote:
>> On Mon, Jun 3, 2024 at 3:59 PM Thomas Weißschuh <linux@weissschuh.net> wrote:
>>>
>>> Can you try disabling all of the Framework-specific charge control
>>> settings and test again?
>>> Probably the different, disparate logics in the Framework ECs are
>>> conflicting with each other.
>>
>> Fascinating! This board does indeed support charge limiting through
>> both interfaces. It looks like the most recently set one wins for a
>> time.
> 
> If it is the most recent one, shouldn't the driver have worked?
> What does "for a time" mean?
> I'm using only the upstream EC command and that seems to work fine.
> 
>> The UEFI setup utility only sets the framework-specific charge limit value.
>>
>> We should probably find some way to converge them, for all of the
>> supported Framework Laptop programs.
> 
> In the long term, Framework should align their implementation with
> upstream CrOS EC and either drop their custom command or make it a thin
> wrapper around the normal the upstream command.
> 
> (As you are familiar with EC programming maybe you want to tackle this?)
> 
> Until then I think we can detect at probe-time if the Framework APIs are
> available and use them to disable the Framework-specific mechanism.
> Then the CrOS EC commands should be usable.
> 
> The drawback is, that userspace using the Framework APIs will break
> the driver. That userspace would need to migrate to the standard UAPI.

How does userspace access the Framework APIs?  Surely it needs to go 
through the kernel?  Could you "filter" the userspace calls to block them?

For example this is something that currently happens in the dell-pc 
driver to block userspace from doing thermal calls and instead guide 
people to the proper API that the driver exports.

> 
> Also the settings set in the firmware would be ignored at that point.
> 
> I don't want to use the functionality of the Framework command because
> it's less featureful and I really hope it will go away at some point.