Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp552643lqr; Wed, 5 Jun 2024 13:48:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX6e1xDuHWTiDKw/Qrnh1O89N33oEIlmEe0T6dc/8tN2fQ90eX0pd9h9oZrdCue4AaPNwq0yWwdQ6XBvH7/swVwkaiFw7kc4nCj4CLyDQ== X-Google-Smtp-Source: AGHT+IFmYp3fUIOtRCDVcBvIXTo+M/ZdT9zFzVDo5/TRXO2vzzWkntJ3feR27UzCKJx4GDMFB0FQ X-Received: by 2002:a05:6a21:6d9e:b0:1b2:184d:c197 with SMTP id adf61e73a8af0-1b2b713c96bmr4206433637.42.1717620535519; Wed, 05 Jun 2024 13:48:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717620535; cv=pass; d=google.com; s=arc-20160816; b=beL5QEdmtTS/xuso3E5WsntfHSSBnfNgELdxhFl2YZ4CdoQn0S2oKw51/d6xXD5Mbv 7r7COwPqlpHRhc14T33HN+Ic7WGHvPIGbkh1Oqbozu4rEosgoUUHLbq9RmTR6+0g9PtH /qEb9nqhTzzYdX2aOUHxW4rI/5/Lqgz7T6RUExsg35sqC23q6ILa/YWzfXgXA3tkJLSh zsK3+TEvChYZHvBlk7tL4Brlt+qWL+mbg6bT2WgKqzP82jq5uVjROhjoY+F30ZqDOO+S BE4W0in4CkXZmNIADybAOG7xPGI2BE14CTr6q9VHZwb1E/temOQtKQ1ZO2ga+/C82EIK Veig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=KKqACQwsw0UMD64ceEvLLbjPzghIohbVqbXl6kDY0sA=; fh=XyUzn1aEI9QntaGcgMVhTyzY/S7nfBr6mJIzGGbxpGM=; b=A3bBVgra4ZFbyAiCkOSbJ8ACn5IS7Na5a3wAZ7YuBDDnByTcBvFp10g3XenSSFTKJM CDZr/eUUaxm438s4HaT77I4zMgygrHnQS+uVLLiDvXsfZKdT52zTTYb34M+dZ5PTNj6Z JcbxyVkh65j5jPVc2BfDk0AvRgqgqakFCSjaMC8wWnS7Vx2bRnIlU6koWHC3D5NHuVS5 0Rni0OMNkY8jttzkKHsKAPIhLNrkY2LOQG7ikkoCtOp6ahyoTs0i5oLikcTTuZkhWqfU ccwERZheuWL9uHjx5sGJpo8elksBidZhUlsp+xEQSvlosuBlHtblnCBVHJYpVJ5Dl+lJ xL+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=djRW8dej; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203196-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id 41be03b00d2f7-6c35c17d01asi11101937a12.627.2024.06.05.13.48.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 13:48:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203196-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=djRW8dej; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203196-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203196-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2C2EE285175 for ; Wed, 5 Jun 2024 20:48:55 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 21544154445; Wed, 5 Jun 2024 20:48:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="djRW8dej" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4998B7462 for ; Wed, 5 Jun 2024 20:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717620527; cv=none; b=pnK5hxvq0Z9tAP7GkecqY+ODxOvma3tfEnce4UL74PML7t8joEaf/UxSsJzotaWuLseyspnifDI0nO/HyhvD/ofzE6bB5j73VngrCZtscpCl6sKtI4lnPEhYuD8Loj0+qe6fjO96yF8J2769wHxx97OEPK+/0S8NRQQR4M4qnEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717620527; c=relaxed/simple; bh=T5vr5sPvG0JFOXXVreMHeuAt0slBjtXGtC/wJP+h424=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MnbpL66JU/TCmUTj90ZPAUMpJMPHCU/D4nMVGVbEox/KA2kWoG1RmPE9hhRD3hIBadlfLiUBAeKWp5SEcJkVHWz3PzL1QLstvoSVhxL4C3gBUZyPcGvDIzKLRz7+nmPOnQIKIxxUZKWebUteO5JJh/i+xTjBuYGydR1c2zMa0hs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=djRW8dej; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8FCCC2BD11; Wed, 5 Jun 2024 20:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717620526; bh=T5vr5sPvG0JFOXXVreMHeuAt0slBjtXGtC/wJP+h424=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=djRW8dejK447Uba2SB73pKSW2tX5d1fwBlUICNRuXwHtUGONv/nLgcLoamj1LO53F 1oR6q6IjjbXmLgxcxYaRzF5sXVqQnhzL8O17xmL1hkh9vVMt6XI/PJCEfln1H6xWKr GvUmsUPJS5YbaeUi86r5hrSAo57RjJqffa9+dp6kmKEkHHhM6b503YHxmuPFbwJ/U9 Ojo3EidLxLlwktsKpYgINSAj/FSrB4uZhq1TE7RtMpMzU4Ktnudm9uWfuU8PDcdMWy qCVIgBdd76wr6Iu7hfhoaPHrU+cZP5meL/Y6ie8/jvSGuF4FRqo8FRo3FGnK19gH9Q L0JEXLbmGQ35Q== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 7138CCE0A72; Wed, 5 Jun 2024 13:48:46 -0700 (PDT) Date: Wed, 5 Jun 2024 13:48:46 -0700 From: "Paul E. McKenney" To: Jan Beulich Cc: Naresh Kamboju , open list , linux-mm , lkft-triage@lists.linaro.org, Andrew Morton , Mike Rapoport , Dan Carpenter , Arnd Bergmann Subject: Re: x86: WARNING: at mm/memblock.c:1339 memblock_set_node - Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead Message-ID: Reply-To: paulmck@kernel.org References: <315d6873-d618-4126-b67a-de62502d7ee2@paulmck-laptop> <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7d55b65e-331a-4ce2-8f72-d3c5c9e6eae0@suse.com> On Wed, Jun 05, 2024 at 09:46:37PM +0200, Jan Beulich wrote: > On 05.06.2024 21:07, Paul E. McKenney wrote: > > On Mon, Jun 03, 2024 at 07:19:21PM +0530, Naresh Kamboju wrote: > >> The following kernel warnings are noticed on x86 devices while booting > >> the Linux next-20240603 tag and looks like it is expected to warn users to > >> use NUMA_NO_NODE instead. > >> > >> Usage of MAX_NUMNODES is deprecated. Use NUMA_NO_NODE instead > >> > >> The following config is enabled > >> CONFIG_NUMA=y > > > > I am seeing this as well. Is the following commit premature? > > > > e0eec24e2e19 ("memblock: make memblock_set_node() also warn about use of MAX_NUMNODES") > > > > Maybe old ACPI tables and device trees need to catch up? > > > > Left to myself, I would simply remove the WARN_ON_ONCE() from the above > > commit, but I would guess that there is a better way. > > Well, the warning is issued precisely to make clear that call > sites need to change. A patch to do so for the two instances > on x86 that I'm aware of is already pending maintainer approval. Could you please point me at that patch so that I can stop repeatedly reproducing those two particular issues? Thanx, Paul