Received-SPF: pass (google.com: domain of linux-kernel+bounces-203201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ad56235d-d267-4477-9c35-210309286ff4@intel.com>
Date: Wed, 5 Jun 2024 13:51:24 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] igb: Add MII write support
To: <jackie.jone@alliedtelesis.co.nz>, <davem@davemloft.net>
CC: <jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
	<kuba@kernel.org>, <intel-wired-lan@lists.osuosl.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<chris.packham@alliedtelesis.co.nz>
References: <20240604031020.2313175-1-jackie.jone@alliedtelesis.co.nz>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20240604031020.2313175-1-jackie.jone@alliedtelesis.co.nz>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VEE0V3M5L2ZreGo4d2NuUGN1WDd3djRaVFVNVHNKM3hhK3FsOGJFQnE5UE9S?=
 =?utf-8?B?cEJIK3VFR3Ntc3JJRFB4TldsNzBSVFpad2hzRWFRbzBwOE5wYldYb0F6VnQ4?=
 =?utf-8?B?WjBLU0YwVkpzS2ZjMlZxRy9EWTdzWWx4ZEFpVjVIYnVROUh3ZEhrUExpNzVy?=
 =?utf-8?B?MUU5UTdCcUEyMmNLUDAwQVo2ckljSkdIekVHeU0zN0UyR1JmSExSWGU5Qkd1?=
 =?utf-8?B?NkxOOEZ6UHVpeWw1Y1V0b1I2YWRtMXY3RkEvbWxTeVVWVTRHQW9kRHZNTVNa?=
 =?utf-8?B?YnlLRVp6d1EwaVRFamtoY1dkZndORHB1c1krZk53R0U0eHdCODAxQW5MZE5D?=
 =?utf-8?B?aGFNaHlHNmE3bUVwMjhuVE45U2FmTm9sNXN3WkpjNUhCY0xXSEN5RlM1c2hj?=
 =?utf-8?B?UkJ1UC9EOXQ1QjZmV3l0NU9QeHhpUkJUc0xmbnk3ZExLbExlVmxlUVpRQS93?=
 =?utf-8?B?bDVDUCtFbEVpYTNjN3VBU09GOEpKMDlYQVBHMHh5WVBFTnpJMko1ZXhWVS9V?=
 =?utf-8?B?VlJCeUFBVnhHN1lZRnZKR0JkbnB2bVgxbW5ManRGR293eFZzdXYzUGlwWXdU?=
 =?utf-8?B?SlJyTDNlZTV5WldWdDJ3b2swSkZIZ3hpWlEyUkhYVlp6b0twd09kN0ZnMHkv?=
 =?utf-8?B?VklPbWhuOXZZRWJrengyek96dGtXZXVra1E4K0lHMjZ0OW5tOWhZT1MzeDYz?=
 =?utf-8?B?b3EycHpzT2JFR2c4akVvTHVFVXA5dUpMQmR0SmViMXBBTDRTM01SbUNpVUIv?=
 =?utf-8?B?bGM2eS9FazF5Smh0NTUzK0JPR3dSL1NMc3IzZjZnTk92czBPTU5wTjd0NnpC?=
 =?utf-8?B?K25lTGE1SHdvb1BrNm9ZN2VoYjF0R1ZMem52VElvOGhYWE0waTNLdDFFSTJR?=
 =?utf-8?B?bVdvSFZFV0FnTUVBdnZ6UWdhL1BpRzgxanFKSHNheWlvbjF1bWZ6aWNJTXJw?=
 =?utf-8?B?WUlLZHZMcklsdnJkVWdiTG1JbktLR2VVMzlYVS9RdW5BN2lYZ2FQM1Jlc2xm?=
 =?utf-8?B?QWJrMG5uaVBWeWg5RWtWK1M5WDhTTktKTVZqRTVDWG5DclZTdkhycEJ0enUx?=
 =?utf-8?B?TFJ1UjdZSENPSWFEK3V6QXNlb05VM3V3WTFyTkt5ZHRXek9FclcvZmlLWjIr?=
 =?utf-8?B?Q0xpMk8xbzRycXBPblJyL3BPRjhzWVErc1dEWnF4dVhEck9iSGxERnpsL3JH?=
 =?utf-8?B?WnViWFZNN0FtVlZDeTdBL1FzczJTZHplVkt2emEzU2xyZ1lVdVRGaUlDcVRP?=
 =?utf-8?B?V21FSnEzL1NxMWhRanBiZlo2akNoWXVpa2MxUmYyZGRzeFkxVVc5c3Q3blRj?=
 =?utf-8?B?V1JBSG1BQVlVZDg5RmlZelJJKzg4MzU2WkpxVndqTEdBa1NVTmVDWVZ5ek1s?=
 =?utf-8?B?WnVzcnZXblVTbnlKS1p3OENDSjFGMVlUV1FpYWE0VkVjL2dKZTVRckZKNlhQ?=
 =?utf-8?B?SFJKYmh5OGwyT0t3Tmg5Vkt1cVdxRDBib2ZnQmRxeFI4TVF5V1RTZTh2bXRJ?=
 =?utf-8?B?UEpNYXpMMXR6L1ptZkR1K3ByUUMrZDQyTk5JNUp4U2J2OEdyWE1hcElNUkVu?=
 =?utf-8?B?TGZnc1FzMFlsNXZ4NndiZmU3ZmFmRHJmMmFYVmIwQUhjazR0VTdLc05WS0ta?=
 =?utf-8?B?R29rS3VublZ5VTJQS3lZZlMvM0Z2b2VRbVZxYll5bUQvUkRBcVBLWXY2SUxJ?=
 =?utf-8?B?REo0RTBVUmlkZUl1cVVjL3UvL09TSFRzSzdKdzgxNy9WdnpQOG9GZHQ2SS9r?=
 =?utf-8?B?MjQyQm9nbk1jakNnVDVZMk1WVFFNZWJsUklyWFdpeGV4dzN6bENXMWh3VUJL?=
 =?utf-8?B?dXFtWEpzWmpmQ2hBOW9uV0MyWXViNmpBb284Zk02VDFCMWVpNmhnclgyOEpT?=
 =?utf-8?B?OWtMc1dXVWVZY2hKbGtTU1MwckZnVElSV3lFa2xsdHFUeUx5RU5RamlPNU1P?=
 =?utf-8?B?Y21xSE1sTUhGNDNUUWJUczBkTUFCcEVhWlFTWEMvZ2M0Y3BjZnVZRUIyb3Nt?=
 =?utf-8?B?UmpqLzVZNjdWc1JZV3RnSzJJV3RyVGRtcnpMVkhSdi9nUjN0aXFTYkUrSk5Q?=
 =?utf-8?B?YTBwMUJtVVlIMEpKT0dQRkxRaVR1Q3Q3TmIxdjlWNURuQ1dvNEVqdVlOby9u?=
 =?utf-8?B?Y3dRTHpGWUhSWDdreWlwSFdzcU1XWjZySmJYU08vZld6T2ZTcDVUV2tvbzlI?=
 =?utf-8?B?ZWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 706efdfa-2a3d-43cd-3824-08dc85a14475
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 20:51:26.7284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ed1XqdGNhdpOc9X2wkapzSY0Aml9QYiy2sJvwEnfexGv1WNdV8I8owp0li5XrOFeTZ3j4pI+ecFHGJ5iGlvDC+njqy9XGsfuv2yNtYgcIZA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4557
X-OriginatorOrg: intel.com


On 6/3/2024 8:10 PM, jackie.jone@alliedtelesis.co.nz wrote:
> From: Jackie Jone <jackie.jone@alliedtelesis.co.nz>
> 
> To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
> ioctl. This allows a userspace application to write to the PHY registers
> to enable the test modes.
> 
> Signed-off-by: Jackie Jone <jackie.jone@alliedtelesis.co.nz>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 03a4da6a1447..7fbfcf01fbf9 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -8977,6 +8977,10 @@ static int igb_mii_ioctl(struct net_device *netdev, struct ifreq *ifr, int cmd)
>  			return -EIO;
>  		break;
>  	case SIOCSMIIREG:
> +		if (igb_write_phy_reg(&adapter->hw, data->reg_num & 0x1F,
> +				     data->val_in))
> +			return -EIO;
> +		break;

A handful of drivers seem to expose this. What are the consequences of
exposing this ioctl? What can user space do with it?

It looks like a few drivers also check something like CAP_NET_ADMIN to
avoid allowing write access to all users. Is that enforced somewhere else?