Received: by 2002:ab2:6d45:0:b0:1fb:d597:ff75 with SMTP id d5csp561695lqr; Wed, 5 Jun 2024 14:08:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUoKtIYnXVbZSRXPyxX82GdMZGFe8krTHsnVYodnyOpsZPd/pUdoonFIRL3iuNP7dwuSyZsm69fkmVxWznqDGheY/1HPI99nQZCTULQZg== X-Google-Smtp-Source: AGHT+IHlX3/XHUA4hgIIv2/zkaan7AK8WeY8kda+ftQKQ+Q5UcBckUKnYswuijSnuhCM6jjGAFWg X-Received: by 2002:a05:6a20:da9f:b0:1b1:d7b3:dc57 with SMTP id adf61e73a8af0-1b2b7469b49mr4772283637.33.1717621704618; Wed, 05 Jun 2024 14:08:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717621704; cv=pass; d=google.com; s=arc-20160816; b=D3gLsZzeMUzLpgnEbBPauwyR8dlBqhA2SKXPA0TFb1dhao676b9HMqzP/8CtTHzN+z y4NXa+3NN2IWM5aJX7SP9PCOemLCgDGdOlxNR9rZMZm/x6+DHfUSUBF/ZNUmuus9I7YO 0203lmTcgznS5kdquxZYC6OAJYLNvifLa0WrtV+tDsjxE7oZcrksFGDXLfIo7Z5+hTDw WLW279d9Ze0CGBp91hJepJpugRTHm/vRtNTNGEmaQL6POxzhYRsQPmkbQYY9m7ua9vtX QxL1t2Od4q/PhQpnsspFTXx6FzCi7+bj3ejOlwacexA+v8kT8fEdAzTNw1k0SBU3wFCL SbEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:to:from:date:dkim-signature; bh=hEyb3EnOQMfsZ6zs1eUsg/A4vS9JnDLEGzPka/hTeyQ=; fh=b+/BeSq6WU8TtrliJIZ2SJLVYlsQnb4Wi56kIPad3gU=; b=xwq9cYgxTk8tkPng1HLyjNniWZwgt4+1Et7RCW0yV0rr9AAWJdH6Qjgt3A1GNl7kkN StOcwKIQlisXC1vHO/zAILHoZFGV1uLw8fVI3B++x5Y64lLrEJqtfXWqUFTMM+YEdF1Y 6RvF/X9WGKNBq4pCbwLM2NI8ZwEYzjZTYlA5Qlw0m2Av8WXbcvFWzJh7Gg2Cp+WSsFLV tEp9LbXQeKGeM+yMDX3gP2xSFZYVoEii2psf2Gm/EXWgDv93e3fu4+aeW5eYcEBRPxuH zk+/I1HEoHIeM6U+Z01OsGNoMTE2lfHaGbZGHGl8Fdg5lhpRtVZeilxRneWrE+2IKhlg e6ew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NDcTStJ3; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-203233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203233-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d2e1a72fcca58-703fa3c6abbsi222808b3a.63.2024.06.05.14.08.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 14:08:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NDcTStJ3; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-203233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203233-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 400F628770B for ; Wed, 5 Jun 2024 21:08:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0A9515F3EF; Wed, 5 Jun 2024 21:08:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NDcTStJ3" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689173C28; Wed, 5 Jun 2024 21:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717621696; cv=none; b=ei8Ej8b8lqDV9sSKuR+R1XPYjlXwhArBczI3fLxH7FJOtwLXRq21lmB1IbhBvahNqEpko1J69qjs+yYTyj6WQL2P5rAECwk5oIWwNmG+yLfooDGWbs95sntxX5yLIKbBICv78SkPXEnMAm7vBm0APwzYDXrdVoFjv7NYmVosz/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717621696; c=relaxed/simple; bh=EuRJsCLwPoNelYVlabKWIXl87KOBUOtFbHaWsPbiAm8=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eeN8KWqdQJULXDDnBch8NDhK7mh0BIg+WxAIyPXRW4QQmNHEs9YvL/Oy5mMALhC5xVragBOEfDrD6b599JGlF9J5rn6g5ytQiWOPv2NmUhWJbzzwoMOEFZHdhfitxAYxlpWM+uTQ4+qlPqHKOuwbzl0C+iKMXHoCrmPj1SyElkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NDcTStJ3; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717621695; x=1749157695; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=EuRJsCLwPoNelYVlabKWIXl87KOBUOtFbHaWsPbiAm8=; b=NDcTStJ3M2EU0NCZPR/MCZ8pBqLI6n8q1NHzWD/m5kacMdvulkkayaZ5 WXRsNWBZ35ybWI4IodO0udYNhsFDlnX2HHMVR6By00DbTiSc7uxrKr3dH AUR+X5uLxR1G9JQQGNs81urPc++WsoKLs11DMC8WEMC6qYoAlFhNtN/gh 0D+HqAnt25vrEZxbnMZbIrYbIVJi6FDm/KRUQ/80dkpOUdRADkSNS7WRd R7J3J1XwRS8ulRB+T+WOkLz60og04jzczDSiLVVHWK3ZdWRpKpA326YHK kWtBfxremHds7NcKW20NiW/bajozN1et/8qchJBvz5CGJZmyvYQOTVJ31 Q==; X-CSE-ConnectionGUID: ou0SP6bbTMOrELft5+islA== X-CSE-MsgGUID: cm3/8il+Q2m/zvu3quONJw== X-IronPort-AV: E=McAfee;i="6600,9927,11094"; a="14003565" X-IronPort-AV: E=Sophos;i="6.08,217,1712646000"; d="scan'208";a="14003565" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2024 14:08:14 -0700 X-CSE-ConnectionGUID: LnmSXtnTToGE3o9TkT1HqQ== X-CSE-MsgGUID: ZKDdLtubQbCydMbiQMGujQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,217,1712646000"; d="scan'208";a="42649154" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2024 14:08:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1sExrf-0000000Dy52-0xXz; Thu, 06 Jun 2024 00:08:11 +0300 Date: Thu, 6 Jun 2024 00:08:10 +0300 From: Andy Shevchenko To: Mark Brown , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] spi: Refactor spi_stop_queue() Message-ID: References: <20240510204945.2581944-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510204945.2581944-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, May 10, 2024 at 11:49:45PM +0300, Andy Shevchenko wrote: > The refactoring makes code less verbose and easier to read. > Besides that the binary size is also reduced, which sounds > like a win-win case: > > add/remove: 0/1 grow/shrink: 2/2 up/down: 210/-226 (-16) > Function old new delta > spi_destroy_queue 42 156 +114 > spi_controller_suspend 101 197 +96 > spi_unregister_controller 346 319 -27 > spi_register_controller 1834 1794 -40 > spi_stop_queue 159 - -159 > Total: Before=49230, After=49214, chg -0.03% Hmm... Other more recent patches went through, is this lost in cracks? -- With Best Regards, Andy Shevchenko