Received-SPF: pass (google.com: domain of linux-kernel+bounces-203242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <952085da-d209-5144-19ef-26c5e7b03cfb@amd.com>
Date: Wed, 5 Jun 2024 16:17:07 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v5 02/13] x86/sev: Check for the presence of an SVSM in
 the SNP Secrets page
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-coco@lists.linux.dev,
 svsm-devel@coconut-svsm.dev, Thomas Gleixner <tglx@linutronix.de>,
 Ingo Molnar <mingo@redhat.com>, Dave Hansen <dave.hansen@linux.intel.com>,
 "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
 Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1717600736.git.thomas.lendacky@amd.com>
 <9d3fe161be93d4ea60f43c2a3f2c311fe708b63b.1717600736.git.thomas.lendacky@amd.com>
 <20240605193831.GYZmC-twcfjlArW3Hq@fat_crate.local>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240605193831.GYZmC-twcfjlArW3Hq@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Y2R6NlhFSWw1Smp5M2Q3cURPajdpcTlJNWxhcEdjeGJKVDQ2RnhaZlVjaW1w?=
 =?utf-8?B?V2hYWjR3Y0YwNXE4dm5aRWppRmhSalMyb2JTLzVRa3owS1dISWl6ZDcyRUJP?=
 =?utf-8?B?cjIwY2JNNnlDMTBKS0xvb1kyWVdpVzk4Y2RQcU8yT3VaTFZVb2RVTm5nU2VU?=
 =?utf-8?B?dFhhc2QzY0hmNXZRN3NsWndXTzB2Zmo1WVRlZjV4eUs5YnRkelcwek5mQmlk?=
 =?utf-8?B?NW95Z3o2aGI2cUVQVHJaNVkxU2x5b3RWMmtJWW91YTJBb012SzFXNDd2Q2d5?=
 =?utf-8?B?amF1azdNYXdCYkpRY04rRTlod0g3WEtVK04yZVRDOXoxU3ZxZEZweHMvOHpM?=
 =?utf-8?B?WTlSQnNIK1E5YTVjcTdxU2QwSndXSitOOVhKMktTSmJJVFAxSWhTL1dWbUdL?=
 =?utf-8?B?YXNVRmJWVG1XMXRaSlFPTG01bEMyNExkRGRtRjNmZHZOYTQyNmEyZjVtcXdk?=
 =?utf-8?B?TVVIRnhaclpVbSs2Nm0yWGNKZXh0Ri9Ja1FUNXpLTXUrL29KMTQyTGJkc01V?=
 =?utf-8?B?RlF1cVhkWU50TVBOQ1pjdlVoUVVaWTEyUDNSc09FL1pqaVdvRUNFQ0NMdlNN?=
 =?utf-8?B?dDJMK3dKN2tqVFc2Y0hEaFpEd3BicjNaT0xTNHY1UFM2aUFzZWRkQ0M2U1pS?=
 =?utf-8?B?U3c4VXRIVWxUNDZ3UWdIZm5pSGxoZm5hZGU1eUUwOWlMbTNoWjJsK2pZd1BX?=
 =?utf-8?B?VjhSdE5kbkZ1R3ZmV2dFbGFRZ0RkQkN5eUcvQVFqUmtQcnd4eDRCTnE1MnNl?=
 =?utf-8?B?MnlEYk9PcUdlNFRPcVEvM054eXRWMlh2ek0xbUFNTUlNNnZuWjZadTErNlgy?=
 =?utf-8?B?K2VOYmtNUjRXQmF2elJZbk45dTNNbXVVSWRXeklXS1Z6NU00SnVSRUVCYURJ?=
 =?utf-8?B?WUI0bGh4YTAvUHJueDFjWHF1T2llMWM0bE5Ic25sTUFMVENjeWxDUWNQeFpE?=
 =?utf-8?B?M25ucTlnTVdZblJ6WUZEYzFpNDhRVUlUR1hoRVZWMTBpOTl3NDlDUzBNNHpz?=
 =?utf-8?B?d09aSXo2M3BEVy9mU09FeGxtU3lFckt3NmFjZ292aU9kSmVFcHhXdEtRd2Qv?=
 =?utf-8?B?SVEyTlFzN09mNDVnYVJQYmZ4ZEZzYUNHU3p3TkcrcUMya0FFNjVnby9FRjZN?=
 =?utf-8?B?NHBEVkR4R0poZVpYSGwzck5TeFpTWlZYWTZWN2IyK2kzUzdHVHUxdkRjdDhs?=
 =?utf-8?B?aGpVWFhOWUlqMFV6MWZVcUtiRjlpN2VaNmZGSnlmWFBsNjN5RWpxTFhzTkhW?=
 =?utf-8?B?amNPYWJoTHRrQktkQ3NmN2l2aW9FS0JUMXJsa3VQVlgzc3ltcFhQaFFQbnMw?=
 =?utf-8?B?bWhOcnZNK2M0R2NIUXg2SC9pSlQzRlFCR1dMdXdIMEpYZVM5dVdDdmYvQ0Rw?=
 =?utf-8?B?RmRXZ0ZxRDN2OHB2eEJOMFlHVzNQS0k3K294bDF4NEQyb0dJYWtCL0twcitY?=
 =?utf-8?B?YXRrTzJxa0RhMHdyempMOWxDVW1FU0p2TjBLVmtJWXloc1p5bFNpUmFHeENh?=
 =?utf-8?B?VTRpRUdDb2FvNEVVQU43QzVvVWd1aTlBNG0rMFVsNkppUXlZUE9vYlc5aHc4?=
 =?utf-8?B?ZTdQb1FuMlBFcE9hVVMwS3FrNGdTNWlra3J5a2ttcXJhQU41aVZhcFlTUlVC?=
 =?utf-8?B?TTRLalUyZkIxZ0ozT0xZbHhqNHAzYTVJNUhYUjM1N0ZyZHVCbCs5RFM4RWRt?=
 =?utf-8?B?VnMzOHN3bzFydDRza3JBNmMvd2Mxa05kNXNHT2lBVjNHOXlUMXF1NTN5V2sw?=
 =?utf-8?B?RDMrOHM5Z29UQVY3QUtkMWdCSjVmT29YOVk0V0RKNEsrQzlEWmFpUHBGd0Nr?=
 =?utf-8?B?Y2ZnRk1FcHFBZkJkTkJFWGhyMStIdkROQ2xXRDFJR2dETUdEbmFIWjl3MkdO?=
 =?utf-8?B?SzNqV0pMczQyc2ZYaG5ENE5hQnE2MFZFSUhMeDVzQVN5dzNKaWI0d3k2Q1NR?=
 =?utf-8?B?cTRrZUx1MFYyb3RQZUFXQjJGdGo3SnZ3ZzRrNHFPL3lBdVdWdjIxc3BqY3hq?=
 =?utf-8?B?V1RqOUlSc0pubWNDUGJZUExJUFIxallVZWtRYmY1c0taQXNaZ0NBeFZaQ3pN?=
 =?utf-8?B?TzhRQ2NnQ3QrS3plMk1FM0tCeUhGaVlROHZxTmJGd1gvR2tyanZHbk1oR08w?=
 =?utf-8?Q?cR/2c7NOPtReh/BmPDBf7qAMC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f9e83b63-c617-49c9-148b-08dc85a4dc30
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 21:17:09.6632
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ngXR0EKkne2uH6ySwokxD/59aM54j3UWyV6TY68gYrlQve6h7PZEL6XZ44ZvYig/MZG0Nqn0nkm60G0mOtzIzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7221

On 6/5/24 14:38, Borislav Petkov wrote:
> On Wed, Jun 05, 2024 at 10:18:45AM -0500, Tom Lendacky wrote:
>> During early boot phases, check for the presence of an SVSM when running
>> as an SEV-SNP guest.
>>
>> An SVSM is present if not running at VMPL0 and the 64-bit value at offset
>> 0x148 into the secrets page is non-zero. If an SVSM is present, save the
>> SVSM Calling Area address (CAA), located at offset 0x150 into the secrets
>> page, and set the VMPL level of the guest, which should be non-zero, to
>> indicate the presence of an SVSM.
>>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>> ---
>>   .../arch/x86/amd-memory-encryption.rst        | 23 ++++++
>>   arch/x86/boot/compressed/sev.c                | 21 +++---
>>   arch/x86/include/asm/sev-common.h             |  4 ++
>>   arch/x86/include/asm/sev.h                    | 34 ++++++++-
>>   arch/x86/kernel/sev-shared.c                  | 71 +++++++++++++++++++
>>   arch/x86/kernel/sev.c                         |  7 ++
>>   6 files changed, 151 insertions(+), 9 deletions(-)
> 
> I did some touch-ups ontop:

Works for me, thanks!

Tom

>