Received-SPF: pass (google.com: domain of linux-kernel+bounces-203104-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Martin Oliveira <martin.oliveira@eideticom.com>
To: linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	linux-mm@kvack.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Michael Guralnik <michaelgur@nvidia.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Valentine Sinitsyn <valesini@yandex-team.ru>,
	Lukas Wunner <lukas@wunner.de>
Subject: [PATCH 5/6] mm/gup: allow FOLL_LONGTERM & FOLL_PCI_P2PDMA
Date: Wed,  5 Jun 2024 13:29:33 -0600
Message-Id: <20240605192934.742369-6-martin.oliveira@eideticom.com>
In-Reply-To: <20240605192934.742369-1-martin.oliveira@eideticom.com>
References: <20240605192934.742369-1-martin.oliveira@eideticom.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Mf35F/cWIkuaaScaGDguCG8V/by0hLcB+4RKy3usMauvo2s3BNx5o+dEypva?=
 =?us-ascii?Q?KXYdOCBoi0Z4N815nkILKrkazHy2itH0wFd9Os6I85A6yoQ2G/0Se3AIrn+k?=
 =?us-ascii?Q?j1L1uIRes8nm19qsouD+VTide5OjfXkT4QDZor1OBTo6yy9eAKs2tEuP7KCX?=
 =?us-ascii?Q?jhGWG/wy45zFMjhjyqT2vFLoeDL2m5nY9jbnxLmOeH7Mfnz2Mu1dubZ3xnyv?=
 =?us-ascii?Q?WpzklZMBwxKkEW/md1Ka6yVG6aSX3O4ulX85Yisqg6lYMpiM9WNwZoyYESib?=
 =?us-ascii?Q?JJMKZCTKL7hE+GZPjtAd7nDF5MdsQA4vXYsp47nzeqgTBEfAAqTImN+3Owda?=
 =?us-ascii?Q?K+yVvjTyQZdmmUJCQ2WlMFcQ0nrlELTuPJGxErQe0OFzDas5iRzDG7SrZAdn?=
 =?us-ascii?Q?npOZFfOVFxbltNJ7A325XFJVw1K36tXHSlHWyZCA+7hBAKtedfWn2eduVhEP?=
 =?us-ascii?Q?pYYWCtrWJ/LmL8T0yC3K2il9164zOYTU4fgKUCfmY2A8+8GjiUIOylZPY/lv?=
 =?us-ascii?Q?ITpN649JCwsNJbTjzpa5P6CJTM1BIkJtT3T6gG60eThVGnr0mtHng4sBIgXz?=
 =?us-ascii?Q?1Ey08nf08rHXFQ0iyDp3TJuU6Nb/Q/i2ksYjs86Rn1+ay8m8WGqsYccWtE5q?=
 =?us-ascii?Q?Ddh71lHHi/cs3ecl5NZDhAHT9NOBnjYXkC+mws7FrxeUzQNGH79FWIfsNqbS?=
 =?us-ascii?Q?VvtcEBfG8H9gq3sX5yiiOfFsIDJLhkEhdrffy71+68K+ox7Z7UHScgR/8ckm?=
 =?us-ascii?Q?6UBR7jc4o03+b59rSgHPpBcsH/KqScvR6jEKU40tr1MoqbpvtCSmtJUxL0oU?=
 =?us-ascii?Q?KLLnAUrpshcpMblEHzj+NrhCw7k6O3O+s3yOelpW7agsfpcmf/aHBMqMAkih?=
 =?us-ascii?Q?VF8ppSEXUVnEBwzJ35fKyBzAaKytydWGq7ktZCSH4284CTauKJFRdE1BCKsn?=
 =?us-ascii?Q?dDQ93D+tKLfHrZo1sueayiClkJenKUtUjffdnSHZrjnDuNnMsU4NTa/hSpIZ?=
 =?us-ascii?Q?tFUCvsaepJi4NZ9qTMPD4jWXJ/jwZ5PUE+vgup3z58Bl/4xXtS0xbBVSHCUM?=
 =?us-ascii?Q?dJ31tAj1hr/xdXLRMhLMJA/6jj4cdTPrVennOUkZ6zFBUUvQyHVu2D98/YDN?=
 =?us-ascii?Q?QjPGofH/FWgLAaItaogn/V23po/+aFMs8CKn46JxpARKdlRVPbGJ6JRmhIoz?=
 =?us-ascii?Q?sejlmGqKnzB79oUhBdqmw2B8BNA91Nk8Z/4CyRE2RwBaZItc3JhAfy+8egHx?=
 =?us-ascii?Q?DTBIc4/DE77FAuV0VL0/bBkp03cVnUnNMsvncdYBob/+KGi0MecfEpDm+5db?=
 =?us-ascii?Q?91it9im5QljICdp/FI9W2HPooOPb1CbUyLSTPkkDRHi//Nvgs3+2wOFRfH1v?=
 =?us-ascii?Q?nBR/zIlFNyjhWNfCqN+oYVpxBPjx3S9q0McewiDL2U1LiD1k6f2GXWdWp0zB?=
 =?us-ascii?Q?wyXYs/gB5DFf8eE09mNPbGlOjZYIFPMRjdnWGqpWK4Jjkqcd94TVttm+PZk7?=
 =?us-ascii?Q?i5uRDTiJ9bqpx+n0LmwUk3z9KJSdtQ375VgpVwV+iCMnuIgdIB5wACZG7vCG?=
 =?us-ascii?Q?d+/tHj80buxcnL4k1j+uqjQXZN3nMs3XQV3hT9GP1z0Bh7dEpdl/3CqikLUk?=
 =?us-ascii?Q?Rw=3D=3D?=
X-OriginatorOrg: eideticom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c8d2dfc-0b27-48cc-d87c-08dc8595e969
X-MS-Exchange-CrossTenant-AuthSource: MW3PR19MB4250.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 19:30:09.4140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qmVv2frgPeMSslsX9CVbY/cjzo/CaJG47zFK50JgOqg5VP4qjZ5UtoRdf9cTbDMOrSx869XKKVBNvYSv+y7U8tz5YVpGOC6C4ZUF60ca9rE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR19MB7093

This check existed originally due to concerns that P2PDMA needed to copy
fsdax until pgmap refcounts were fixed (see [1]).

The P2PDMA infrastructure will only call unmap_mapping_range() when the
underlying device is unbound, and immediately after unmapping it waits
for the reference of all ZONE_DEVICE pages to be released before
continuing. This does not allow for a page to be reused and no user
access fault is therefore possible. It does not have the same problem as
fsdax.

The one minor concern with FOLL_LONGTERM pins is they will block device
unbind until userspace releases them all.

Co-developed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>

[1]: https://lkml.kernel.org/r/Yy4Ot5MoOhsgYLTQ@ziepe.ca
---
 mm/gup.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index 00d0a77112f4..28060e41788d 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2614,11 +2614,6 @@ static bool is_valid_gup_args(struct page **pages, int *locked,
 	if (WARN_ON_ONCE((gup_flags & (FOLL_GET | FOLL_PIN)) && !pages))
 		return false;
 
-	/* We want to allow the pgmap to be hot-unplugged at all times */
-	if (WARN_ON_ONCE((gup_flags & FOLL_LONGTERM) &&
-			 (gup_flags & FOLL_PCI_P2PDMA)))
-		return false;
-
 	*gup_flags_p = gup_flags;
 	return true;
 }
-- 
2.34.1