Received-SPF: pass (google.com: domain of linux-kernel+bounces-203105-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Martin Oliveira <martin.oliveira@eideticom.com>
To: linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-pci@vger.kernel.org,
	linux-mm@kvack.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Michael Guralnik <michaelgur@nvidia.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Valentine Sinitsyn <valesini@yandex-team.ru>,
	Lukas Wunner <lukas@wunner.de>
Subject: [PATCH 2/6] sysfs: add mmap_allocates parameter to struct bin_attribute
Date: Wed,  5 Jun 2024 13:29:30 -0600
Message-Id: <20240605192934.742369-3-martin.oliveira@eideticom.com>
In-Reply-To: <20240605192934.742369-1-martin.oliveira@eideticom.com>
References: <20240605192934.742369-1-martin.oliveira@eideticom.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?25lmoksPC/AnTLxDIUIe1owA5WKhvq3G+5/n91gYhOwQWWr1pTu76O4zVE6s?=
 =?us-ascii?Q?ZiVYERu1jVFHgy7gqmadwomIooh6TYpU0UYUCANQ5+u44my4ndb1VXsPk6m1?=
 =?us-ascii?Q?SQShBFlFUS9hPuUbWo7KlUJ0OY2GNWbH5NuZB9zP61wawXWDOPWgPhiYPzeZ?=
 =?us-ascii?Q?JN0neL2iR7L8t6cuPFHMjUNuhIiYruOptRDAOJw8QdV1pDMEjrkM4kmdaIDC?=
 =?us-ascii?Q?t8yYBmkJNrGSo0/DJO9g49IM5kE54jvkHGcbTb86rcjGZsVThvTAi6Ache7j?=
 =?us-ascii?Q?IjSvciQHeiT6erVrNe1r0oIN/TcjKAS6tb3APhktuP1bzssMOQkv242xcU44?=
 =?us-ascii?Q?4xTmTrL/4HAoAA3ViRatyUsRpkmuCh5rdbJoRKs5G927Ek9pnKJvCPZ73UVi?=
 =?us-ascii?Q?Vvq45LKZewcff/O2inToDBesg9311+ZEAA0ZynhveIt9hotV3IH82+rr21SR?=
 =?us-ascii?Q?w+CYEg8Y73FFNrDN3fmG3EdJjdGhPDFzOq0Qrbk67pWj0wUnR71S4mXr0jOd?=
 =?us-ascii?Q?u4XzAkIROJ+iNkwarOKrBjl+NFH1hOV+Gcjuw/czkO570WhRtAEkCihNqAQj?=
 =?us-ascii?Q?EeQC+qpf/WCRvNYZiTaHoG3ze+OcDMEvlzQs59A5fK31YyuL/Tp3bixeBwZ+?=
 =?us-ascii?Q?XIulmuGrBwvigI3z27bmUCnw5Pxsp6yQnv3cc47G/JGOgzjZ6Tdd7dVGE4hd?=
 =?us-ascii?Q?CSIYjtSptYFpgy2kK2yqBzTMIH+bSWbnvg1h+twM72waLhrE6m/QKdSNfPju?=
 =?us-ascii?Q?Htyx/vp2u3fmHCvbHugo6M0OZoneuxy6vQaNx2wKJSToX+c0doW+QO3sV/og?=
 =?us-ascii?Q?3hG0QLeRQW8MYFZhXiTZNS0Y1eImDvXbRwZZQJIT5+xL/eqbj7tAYXvIVQ1/?=
 =?us-ascii?Q?ad0V6vWxouWM0jqUsFhkzvIfBzAIVAGf+xOw/oCiTRNx9zPxDv1dGYclmLSA?=
 =?us-ascii?Q?QWI+pyez/MnNo2/vMPIblH3XQHolohozs2SmgdbSV4qmnC353aXWFQ8wiz2q?=
 =?us-ascii?Q?8QXCzf2Lff8NuH7NXgPILk22LyCw/QIM1jFmmL7QY0nS2V8JBLkupfwAE/c1?=
 =?us-ascii?Q?fBOpmIl1ihPD/xNymOQBA6YqFcBOybV8jRilWMVBIieJFWFEXpp2Cm8R/m8h?=
 =?us-ascii?Q?oKgviCoqKVnNuM1mvVv5GrIlnXj0CNQJ7ZvCWaEYyuRT5nOlomhOTWZczSzh?=
 =?us-ascii?Q?/bh8KG16YkgnnJ5SvhSDLLlI1b9h+0yKkIx2S5iMZCUz7QO7hSSL6gP0pwyl?=
 =?us-ascii?Q?hrWJDoPVaSCGzvnsiO8c49zgolaIIt4aCRm+f2aRQ5bq2DtDidjenD+zIbRo?=
 =?us-ascii?Q?Ki8GDxFZ1ySMd26K3RQVGItbNqv3lLatcDo2Gtr0X+yXiU6d/ErItb6ZPL0k?=
 =?us-ascii?Q?B+F/Wm+Lt57Oe4IhGhn2eTMTzhPNtt0VpRENRA9Fso6LROUdCL89rEgWRRpt?=
 =?us-ascii?Q?Kx/DBi5HIVvUTAeltMOFOC2oz+9PNe+sSdze0M3S7Hz8VnjUzCpMmqQFo24w?=
 =?us-ascii?Q?VeVScBkrYAuz3NYuIVjNXRDiDO4/D8psNihVr+7fFGS1LhdivVbRixNt5Cqq?=
 =?us-ascii?Q?TduhtmZWxLegVUfuxpzNBc7EVgjy4G71MACP6JZuDXyRwe+KEEAOHNAbp881?=
 =?us-ascii?Q?RQ=3D=3D?=
X-OriginatorOrg: eideticom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 542ddc6a-ee66-4ec9-47a3-08dc8595e7ce
X-MS-Exchange-CrossTenant-AuthSource: MW3PR19MB4250.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jun 2024 19:30:06.6899
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H3f+77+UO1EGX1JN+1QoG7pMYrqZSayMlV0Ae3NDDaY8Skp9PRiq5y7AlwCi5QxGa2uf/9pIbse3/1grg/zRBT/DhtCQGDgje48v7F0rfkg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR19MB7093

Now that a struct kernfs_ops can have an "mmap_allocates" parameter to
avoid the page_mkwrite() operator, the struct bin_attribute needs a way
to choose the appropriate kernfs_ops.

Introduce a "mmap_allocates" boolean on struct bin_attribute to achieve
that.

Co-developed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
---
 fs/sysfs/file.c       | 25 +++++++++++++++++++------
 include/linux/sysfs.h |  1 +
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index d1995e2d6c94..77c21009ceee 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -264,6 +264,15 @@ static const struct kernfs_ops sysfs_bin_kfops_mmap = {
 	.llseek		= sysfs_kf_bin_llseek,
 };
 
+static const struct kernfs_ops sysfs_bin_kfops_mmap_allocates = {
+	.read		= sysfs_kf_bin_read,
+	.write		= sysfs_kf_bin_write,
+	.mmap		= sysfs_kf_bin_mmap,
+	.open		= sysfs_kf_bin_open,
+	.llseek		= sysfs_kf_bin_llseek,
+	.mmap_allocates = true,
+};
+
 int sysfs_add_file_mode_ns(struct kernfs_node *parent,
 		const struct attribute *attr, umode_t mode, kuid_t uid,
 		kgid_t gid, const void *ns)
@@ -323,16 +332,20 @@ int sysfs_add_bin_file_mode_ns(struct kernfs_node *parent,
 	const struct kernfs_ops *ops;
 	struct kernfs_node *kn;
 
-	if (battr->mmap)
-		ops = &sysfs_bin_kfops_mmap;
-	else if (battr->read && battr->write)
+	if (battr->mmap) {
+		if (battr->mmap_allocates)
+			ops = &sysfs_bin_kfops_mmap_allocates;
+		else
+			ops = &sysfs_bin_kfops_mmap;
+	} else if (battr->read && battr->write) {
 		ops = &sysfs_bin_kfops_rw;
-	else if (battr->read)
+	} else if (battr->read) {
 		ops = &sysfs_bin_kfops_ro;
-	else if (battr->write)
+	} else if (battr->write) {
 		ops = &sysfs_bin_kfops_wo;
-	else
+	} else {
 		ops = &sysfs_file_kfops_empty;
+	}
 
 #ifdef CONFIG_DEBUG_LOCK_ALLOC
 	if (!attr->ignore_lockdep)
diff --git a/include/linux/sysfs.h b/include/linux/sysfs.h
index a7d725fbf739..190b4b9355df 100644
--- a/include/linux/sysfs.h
+++ b/include/linux/sysfs.h
@@ -294,6 +294,7 @@ struct bin_attribute {
 	struct attribute	attr;
 	size_t			size;
 	void			*private;
+	bool			mmap_allocates;
 	struct address_space *(*f_mapping)(void);
 	ssize_t (*read)(struct file *, struct kobject *, struct bin_attribute *,
 			char *, loff_t, size_t);
-- 
2.34.1