Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp8415lqt; Wed, 5 Jun 2024 15:18:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXdooyXY8X/aswgZYQziRso2fNmFgYwtz3PcCuJ8E7W7wvbaD3KVHJR4aLQvnpzZVPP8/eEsDkY+CASjZ5ulr2R1htXwaB9y6Qg+AcaVA== X-Google-Smtp-Source: AGHT+IH+lJeDgPlOg4sIOXOxHhpfiNFcQ7X+km2NHAlOJwJU/VyhLkWAgNf+x3GwdCO3ulwBpzIS X-Received: by 2002:a05:6512:3d06:b0:528:649b:d7bb with SMTP id 2adb3069b0e04-52bab2679f1mr3090273e87.0.1717625907681; Wed, 05 Jun 2024 15:18:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717625907; cv=pass; d=google.com; s=arc-20160816; b=AFnTD6OiPmMBjr/Y2LNnk7fPdm5NjjNpo6H+mrpGxgkdLheTiy9yn5unpkN8FSQw+t iIpPpuuEQ1DPsj0pjMwGJ5M/cXQVeAZBIxFxQGp2HfyA2YItL+PZCzZQncNZxbWERRO+ RZr1ZEdXzeTGuTKyJgZR2kAPfo85+9tlLAnvwk6bHXnyj6WpqDMkVp9ElcNy0UZVxuu9 Fhl6g6RdERlent6yY4Ff3+1zj5N3EB9vBnCrSRBXSlsZqSLZBqZaz/IFiioVJv9tW73U cf/0Myax6xS78rK8BIjZcP+/HwM9fWOwwFzz4PVSPD3sdlqY8lyN51vjE0PthPZ1uWG0 i2/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=Lu7O1SK7iMqGgAORoq68IjMsPXO8BBGgjyN86gsrYH4=; fh=cSzC8sUjWUS61I+LyYNyrstU1m8ofZwVmQX8O8uxloM=; b=jpC6Acv9TEn/sUanWqpojiUm1jHMncKVMAzMZRjnKCi34DoZDlHh6wdfXe/dK4bDyq NJMs6RunMDMFBbFb8bff7+VAzTQWkK1GezyFh5SBDkoolTzwHGSFLg/QboUff2cDVidt RmttnPp6ZjmRsMjKCS2iWwQOvNwVG6WP0g/X1Y0e6rlu70Kuw2+ggea8nut4xEbnxySd CxZiFOEXIdMFsqjowphfhtevIIdQSUMomG582xBlt13hKcv2AfAfxNsOtJaKSTKCbziD kIveGdBJV6iBXGK4W3ExiV4wpxAJb0NteVX5FCNWHQQQYAn9Ct80Bttvm59tfc2WVtta NkeQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-203348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203348-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a68c41144cesi494028966b.691.2024.06.05.15.18.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 15:18:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-203348-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203348-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 78B7B1F2596F for ; Wed, 5 Jun 2024 22:18:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 948F515FA85; Wed, 5 Jun 2024 22:18:00 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C01912E63; Wed, 5 Jun 2024 22:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717625880; cv=none; b=T/8lM6/d1WNlV1Yvp2XipjkYEydJ8XrgjB4pZgZRILqBMopIWQPD9K8mZy2U4YDE25neWWq899rBxenD+6zTRpHlhwY3IkBMw5EHdMhDXYXIFfe14PY09NvSZQpuh1WNHDwWUjSK7Z9FbXUKF0VJMjtnEa5remWlF6W6atyZml4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717625880; c=relaxed/simple; bh=hLzgsMa1dzEX9W6V/wQtMP8WSGz5GDExHJphUh4myh8=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=NWZRhiQJzl5wXcdICzQHTFxsKcEYRUM90HqmH6A4TEgOPucqzecK8QkYnQIMLluweRECM/F1nk01aMu3KsfH5mainp4kh5MybgYt7KuuWf4JaEJMSplRU+n4ixvuLaNWDJCn0o1ZVJ+8hKdX1RTdUaMax1BYDSs+YpCudT4bsa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 846EBC2BD11; Wed, 5 Jun 2024 22:17:59 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id F2AEE1060501; Thu, 06 Jun 2024 00:17:56 +0200 (CEST) From: Sebastian Reichel To: Sebastian Reichel , Andrew Davis , Nikita Travkin Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Raymond Hackley In-Reply-To: <20240605-rt5033-null-clientdata-v1-1-558d710eeb4d@trvn.ru> References: <20240605-rt5033-null-clientdata-v1-1-558d710eeb4d@trvn.ru> Subject: Re: [PATCH] power: supply: rt5033: Bring back i2c_set_clientdata Message-Id: <171762587697.423727.14923925734341018284.b4-ty@collabora.com> Date: Thu, 06 Jun 2024 00:17:56 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Wed, 05 Jun 2024 18:53:27 +0500, Nikita Travkin wrote: > Commit 3a93da231c12 ("power: supply: rt5033: Use devm_power_supply_register() helper") > reworked the driver to use devm. While at it, the i2c_set_clientdata > was dropped along with the remove callback. Unfortunately other parts > of the driver also rely on i2c clientdata so this causes kernel oops. > > Bring the call back to fix the driver. > > [...] Applied, thanks! [1/1] power: supply: rt5033: Bring back i2c_set_clientdata commit: d3911f1639e67fc7b12aae0efa5a540976d7443b Best regards, -- Sebastian Reichel