Received-SPF: pass (google.com: domain of linux-kernel+bounces-203351-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <cba4f849-8443-405b-8318-a7208e6b80cc@gmail.com>
Date: Wed, 5 Jun 2024 19:27:36 -0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] bcache: Fix compiler warnings
To: Coly Li <colyli@suse.de>, Kent Overstreet <kent.overstreet@linux.dev>
Cc: Shuah Khan <skhan@linuxfoundation.org>,
 Javier Carrasco <javier.carrasco.cruz@gmail.com>,
 linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240605034057.2671663-1-marilene.agarcia@gmail.com>
Content-Language: en-US
From: Marilene Andrade Garcia <marilene.agarcia@gmail.com>
In-Reply-To: <20240605034057.2671663-1-marilene.agarcia@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 05/06/2024 00:40, Marilene A Garcia wrote:
> It fixes the following compiler warnings by
> using "/*" instead of "/**" in the comments
> 
> drivers/md/bcache/request.c:309: warning:
> Function parameter or struct member 'bch_data_insert'
> not described in 'CLOSURE_CALLBACK'
> 
> drivers/md/bcache/request.c:309: warning: expecting
> prototype for bch_data_insert(). Prototype was for
> CLOSURE_CALLBACK() instead
> 
> Signed-off-by: Marilene A Garcia <marilene.agarcia@gmail.com>
> ---
> Hello,
> These warnings happen using GCC compiler the command 'make W=1'.
> 
> Thank you.
> 
>   drivers/md/bcache/request.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c
> index af345dc6fde1..457b9605aff9 100644
> --- a/drivers/md/bcache/request.c
> +++ b/drivers/md/bcache/request.c
> @@ -285,7 +285,7 @@ static CLOSURE_CALLBACK(bch_data_insert_start)
>   	}
>   }
>   
> -/**
> +/*
>    * bch_data_insert - stick some data in the cache
>    * @cl: closure pointer.
>    *

Hello,
I have realized that even though this change could fix the warning, it 
is not the correct fix to it, because it breaks the format of kernel 
function comments.

So please discard the patch.
Thank you.