Received-SPF: pass (google.com: domain of linux-kernel+bounces-203433-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 6 Jun 2024 01:52:31 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Bjorn Andersson <andersson@kernel.org>, Hans de Goede <hdegoede@redhat.com>, 
	Ilpo =?utf-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, 
	Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Konrad Dybcio <konrad.dybcio@linaro.org>, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, 
	linux-arm-msm@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH v4 4/6] power: supply: lenovo_yoga_c630_battery: add
 Lenovo C630 driver
Message-ID: <iefpe3vjf6u43yph2jqhd2pp6dhzk5kzseo2cffv5ksoyqk22c@2plv7xxped67>
References: <20240528-yoga-ec-driver-v4-0-4fa8dfaae7b6@linaro.org>
 <20240528-yoga-ec-driver-v4-4-4fa8dfaae7b6@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ebyt27yflv6nt4ze"
Content-Disposition: inline
In-Reply-To: <20240528-yoga-ec-driver-v4-4-4fa8dfaae7b6@linaro.org>


--ebyt27yflv6nt4ze
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

Thanks for your patch. I have a few more comments.

On Tue, May 28, 2024 at 11:44:49PM +0300, Dmitry Baryshkov wrote:
...
> +struct yoga_c630_psy {
> +       struct yoga_c630_ec *ec;
> +       struct device *dev;
> +       struct device_node *of_node;

Please use fwnode

> +static enum power_supply_property yoga_c630_psy_bat_mA_properties[] = {
> +	POWER_SUPPLY_PROP_STATUS,
> +	POWER_SUPPLY_PROP_PRESENT,
> +	POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
> +	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
> +	POWER_SUPPLY_PROP_CHARGE_FULL,
> +	POWER_SUPPLY_PROP_CHARGE_NOW,
> +	POWER_SUPPLY_PROP_CURRENT_NOW,
> +	POWER_SUPPLY_PROP_POWER_NOW,
> +	POWER_SUPPLY_PROP_VOLTAGE_NOW,
> +	POWER_SUPPLY_PROP_TECHNOLOGY,
> +	POWER_SUPPLY_PROP_MODEL_NAME,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
> +};
> +
> +static enum power_supply_property yoga_c630_psy_bat_mWh_properties[] = {
> +	POWER_SUPPLY_PROP_STATUS,
> +	POWER_SUPPLY_PROP_PRESENT,
> +	POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
> +	POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN,
> +	POWER_SUPPLY_PROP_ENERGY_FULL,
> +	POWER_SUPPLY_PROP_ENERGY_NOW,
> +	POWER_SUPPLY_PROP_CURRENT_NOW,
> +	POWER_SUPPLY_PROP_POWER_NOW,
> +	POWER_SUPPLY_PROP_VOLTAGE_NOW,
> +	POWER_SUPPLY_PROP_TECHNOLOGY,
> +	POWER_SUPPLY_PROP_MODEL_NAME,
> +	POWER_SUPPLY_PROP_MANUFACTURER,
> +};

Please also add

POWER_SUPPLY_PROP_SCOPE = POWER_SUPPLY_SCOPE_SYSTEM

> +static enum power_supply_property yoga_c630_psy_adpt_properties[] = {
> +       POWER_SUPPLY_PROP_ONLINE,
> +};

Please also add

POWER_SUPPLY_PROP_USB_TYPE = POWER_SUPPLY_USB_TYPE_C

> +static const struct power_supply_desc yoga_c630_psy_adpt_psy_desc = {
> +	.name = "yoga-c630-adapter",
> +	.type = POWER_SUPPLY_TYPE_USB_TYPE_C,

static const enum power_supply_usb_type yoga_c630_psy_adpt_usb_type[] = {
	POWER_SUPPLY_USB_TYPE_C,
};

.type = POWER_SUPPLY_TYPE_USB
.usb_types = yoga_c630_psy_adpt_usb_type
.num_usb_types = ARRAY_SIZE(yoga_c630_psy_adpt_usb_type),

> +	.properties = yoga_c630_psy_adpt_properties,
> +	.num_properties = ARRAY_SIZE(yoga_c630_psy_adpt_properties),
> +	.get_property = yoga_c630_psy_adpt_get_property,
> +};
> +

Greetings,

-- Sebastian

--ebyt27yflv6nt4ze
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmZg+jwACgkQ2O7X88g7
+prgcg/+Oj9Lis1zOv00R9LtK2n3mOqqE4WLDAnm9j8cxMhyQyNlAOY/71t6VkCU
bXeDpkoBVYVLRTHu++yw7yuBXckKJ8ZGxfzGtuHPiUzl2FjXBOjZEHCc7RlAfiHy
wLpqos2ZHrDu/IkSr1wgLmPe1nqOGbuBWJLcUgmi0pk9iKt5+tB1w2UqP7CsqDRH
ncOE7YydWI71ueD4DmBceAa4p11mUnX+dBrx2vuTWUPaAJecpP6vcIkqWiKdf5LF
USw8GvSMfEgBus/KMgohMI9YJvNeNM/iC8wjxjOFHN6Csvt5VmRE7L7rk/EsG1QX
g+zXiHh8FxasapjsiM5ZHwYbT5zZBLSl6DLS16gcouZu7a8spmPXDi4PafaHi46A
YGNjb1It/aUdJdA2GLjiHXZKCtmTNKTngm40UbP0BsfSJgG7tGTfQb7HNCShBOlL
V1KmhEeIuFgs0PbkAH5bu993Vu2qn19ohYwd64KWTJqXtsMlfDWxcOPw8aNBxDc1
i8kv1Tytya3a0XK3oCHUZ4AUVO2BfwbA0uLc2JVZ0LV2nJiCeFVzyW76YA4FhAPl
PeIvwvoOYAD4GtX6Ovf4npq5QMhMjG1f5QBVW1CkjXPtYeZNqAIft8AlnL0MzazY
4rKlgjL6XywuGsqmhSEO43GoBleMTQNDwi3J+LOM/u4Fmi3f1zE=
=PNUy
-----END PGP SIGNATURE-----

--ebyt27yflv6nt4ze--