Received-SPF: pass (google.com: domain of linux-kernel+bounces-203439-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240605212146.994486-1-peterx@redhat.com>
In-Reply-To: <20240605212146.994486-1-peterx@redhat.com>
From: Pasha Tatashin <pasha.tatashin@soleen.com>
Date: Wed, 5 Jun 2024 20:01:05 -0400
Message-ID: <CA+CK2bCCeamiaoTFybTd5nW39ixVPDM2gV2rMmK+2PfFAyE+9w@mail.gmail.com>
Subject: Re: [PATCH] mm/page_table_check: Fix crash on ZONE_DEVICE
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, 
	Andrew Morton <akpm@linux-foundation.org>, Dan Williams <dan.j.williams@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 5, 2024 at 5:21=E2=80=AFPM Peter Xu <peterx@redhat.com> wrote:
>
> Not all pages may apply to pgtable check.  One example is ZONE_DEVICE
> pages: they map PFNs directly, and they don't allocate page_ext at all ev=
en
> if there's struct page around.  One may reference devm_memremap_pages().
>
> When both ZONE_DEVICE and page-table-check enabled, then try to map some
> dax memories, one can trigger kernel bug constantly now when the kernel w=
as
> trying to inject some pfn maps on the dax device:
>
>  kernel BUG at mm/page_table_check.c:55!
>
> While it's pretty legal to use set_pxx_at() for ZONE_DEVICE pages for pag=
e
> fault resolutions, skip all the checks if page_ext doesn't even exist in
> pgtable checker, which applies to ZONE_DEVICE but maybe more.

Thank you for reporting this bug. A few comments below:

>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Pasha Tatashin <pasha.tatashin@soleen.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  mm/page_table_check.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/mm/page_table_check.c b/mm/page_table_check.c
> index 4169576bed72..509c6ef8de40 100644
> --- a/mm/page_table_check.c
> +++ b/mm/page_table_check.c
> @@ -73,6 +73,9 @@ static void page_table_check_clear(unsigned long pfn, u=
nsigned long pgcnt)
>         page =3D pfn_to_page(pfn);
>         page_ext =3D page_ext_get(page);
>
> +       if (!page_ext)
> +               return;

I would replace the above with the following, here and in other places:

if (!page_ext) {
  WARN_ONCE(!is_zone_device_page(page),
                          "page_ext is missing for a non-device page\n");
  return;
}

> +
>         BUG_ON(PageSlab(page));
>         anon =3D PageAnon(page);
>
> @@ -110,6 +113,9 @@ static void page_table_check_set(unsigned long pfn, u=
nsigned long pgcnt,
>         page =3D pfn_to_page(pfn);
>         page_ext =3D page_ext_get(page);
>
> +       if (!page_ext)
> +               return;
> +
>         BUG_ON(PageSlab(page));
>         anon =3D PageAnon(page);
>
> @@ -140,7 +146,10 @@ void __page_table_check_zero(struct page *page, unsi=
gned int order)
>         BUG_ON(PageSlab(page));
>
>         page_ext =3D page_ext_get(page);
> -       BUG_ON(!page_ext);
> +
> +       if (!page_ext)
> +               return;
> +
>         for (i =3D 0; i < (1ul << order); i++) {
>                 struct page_table_check *ptc =3D get_page_table_check(pag=
e_ext);
>
> --
> 2.45.0
>