Received-SPF: pass (google.com: domain of linux-kernel+bounces-203467-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <3d13b669-ba74-6c63-8591-8e4eacd6524f@amd.com>
Date: Wed, 5 Jun 2024 19:51:52 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH v5 00/16] selftests/resctrl: resctrl_val() related
 cleanups & improvements
Content-Language: en-US
To: =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
 linux-kselftest@vger.kernel.org, Reinette Chatre
 <reinette.chatre@intel.com>, Shuah Khan <shuah@kernel.org>,
 Babu Moger <babu.moger@amd.com>,
 =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= <maciej.wieczor-retman@intel.com>
Cc: linux-kernel@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
 Shuah Khan <skhan@linuxfoundation.org>
References: <20240531131142.1716-1-ilpo.jarvinen@linux.intel.com>
From: "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <20240531131142.1716-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WjBXM1VIalN0L2FPZ2N4ejRzdVZQZUVnQi9zL2ZvRWJWeDRhMWZHZGNDWElZ?=
 =?utf-8?B?T1M5cW5aK3NUcFFpb3d6UGtxbWxOQk4yVnp5MFpMTElIVGlPK0dTWVZlMGhN?=
 =?utf-8?B?d29MU05KTkhITzhPbGJLM2toakFXQkpjWllIZkN4VzFZZVNVQ2l4SHZ3dDBR?=
 =?utf-8?B?RGJib2o3R25YbHM0QXRldm9XNDJBSFYvb0Q0NU45akxRaWx3RGFYYm8yUlhN?=
 =?utf-8?B?Y3g5SzZPZ2laa293K3pZRmt0TjhvQUM1amlFcUpBNFQvRGEyZVBJMDdOclZH?=
 =?utf-8?B?cDdZQjdwU0Z1MXVxNW5zU2gzZEIwUHh0Ni94ZHhweE1qc2JEek1qWkI0L0xL?=
 =?utf-8?B?dk1kZWpXR0YxT1lCOEVJZ1dYcVdLQ3htK2NENlJqMWJvWjBIVHZzRkphZFJ6?=
 =?utf-8?B?QjRZNThZRDEvZ0NPZEt6Lyt0dVVoUGd6T2dNbTZra3Q1YVkvLzVhQVJsTkEv?=
 =?utf-8?B?am9WOVQ0bHdPdjFRemJVcmZnenAwTlNoanVObmlYS0pFVWxZeUJDZ20zZVI3?=
 =?utf-8?B?R29CU1lmOFI4Vkl4dlVqWTB0NXBDUFAzcFBSejhra0pXazVRYUJyMkU5YXlN?=
 =?utf-8?B?aU9VS3VHMGUxNlF0cjZWcmxpbXBqQzdCeml3bFA4Q1hVcjRhOUdSK0gxdHZq?=
 =?utf-8?B?YzBySTF6UVJ5UlZNUEREejJZdDFIM3EyNXpuWndWSHo1bmZkYmhQUFJxelQx?=
 =?utf-8?B?V0tQZ0RlVUlJaEo5UTByam91YksrTFZHeFdaYVFkMUMvTWF0WERidGpUdEM0?=
 =?utf-8?B?OW4ycUxDUE1LNTI2OU1GUEhjdlY1QkdsRlhqN3RaaFEzNXNEbDlzY2p2bEY5?=
 =?utf-8?B?RFd4R3VkMGJPN0w3anNqRUJYRWNpL2I4STM3L05KN20rSFhldnU2MTZQakxY?=
 =?utf-8?B?NnFHZ213K3U3T1M0VzBIRXdNZ0dadVBIL1ZGeTY1VHl3dU1aSTEwQktjbVZP?=
 =?utf-8?B?OUJPbk1wZ3lTYkR6K1R2VHpiVjRjZFV2NVFOb09McnQ1MzZUc0lYQ1k4ZFJH?=
 =?utf-8?B?dGpTdWZRcVdRUjBXQWVWeFJISWJZY1VSQUtvS3FQWkVBQVZlNEZNV3JRZXg3?=
 =?utf-8?B?WXZXR3pIUGppZFl3RlZpbERIampubmVJUTRjRHlrZ080N1NBR3QxbkFDVVNJ?=
 =?utf-8?B?dHlkcW0rYWdFSkUyOWp1dTIzWXYzUXFsUGdBMXQ1Q3NPeWpWbkZQME9kckF0?=
 =?utf-8?B?bDYvd2ZpeU42b2pJWERxc29qVGpHUjdUUi9LaVZ0Q21MSWNENXV3TFArczNY?=
 =?utf-8?B?Nk1uMldSbXRuZFZFR1pjQzJJUlFFWTZVTGl0K3g2SjhXQThLd1VKZ2swRzlE?=
 =?utf-8?B?RHN6TUd2azhvTVlYbWV2YkFyYkNEWmZUMXp5MHFwN3QyNytENGkwcGpjM1Y1?=
 =?utf-8?B?NzF5bzBBMnlzQklVcEFLbi9ZdXdBb1J6T0JKMHk5eG9EV2lxdit3enZiY092?=
 =?utf-8?B?OC9ZZW9rVlZvbnY1ajVDQ0tjMTI5eGdzS05VYVF1TC9lMnBoVDhiNjdpNjVU?=
 =?utf-8?B?RjVLMWJnd3hyU2EzeHFCTFJkK1k5RFo2aDBtejl0L2JlMkxaM3BUYmVVQmMr?=
 =?utf-8?B?V0lZdHkwYU03d1hwTDRqc2VvQTZEbjE2ZGRnaVN0Y2lTMi9rd0s1TGVGOFIy?=
 =?utf-8?B?YTJaYWpjOEhxY1o5SnUxcnAvM1BCVmVwR3ZQaWZwUEJDRlRTUlBzb050ME9T?=
 =?utf-8?B?eVlhWEI2VGwrbEVuQVVaMzlEL3Z0MTZuQkhHaTRGSWZONHR1bjQyNEhkM21p?=
 =?utf-8?B?WjFNWGJrZjRBR2swQ3lMVncvMjQweVBCaGQ2Z1lpZW9HbkxxL29BeXV6VWww?=
 =?utf-8?B?a2dRMlVpaVpiUkMrNnJ1Vk5jV1RPR1FJK2krRU14SDRZQUFuc0thZnBWZEpJ?=
 =?utf-8?B?OUpuSDNhUVlQYnFkUFkweGpzKzdGYlo3NUhhS3hnTVNzQ2V0MjllY3ZZWXBO?=
 =?utf-8?B?MUpLcnluT1NqallxUFRQMFNLYjBPSTNGOC9JZ0ZvV1RjNml2REJCam0vekM3?=
 =?utf-8?B?T3hGeThudXZ0ckpQRHFtOUFTK1BhbUJSQ3dqakg5bFNsUEphSGMvZkZRaGhl?=
 =?utf-8?B?L2xCVS85NlBJelU0RzJmZ2hyUHRjcEg0cU91dU4vd0Z0QkNXR2NCSm9EQmI2?=
 =?utf-8?Q?uJ7A=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 039e9dc2-3f45-465e-68d0-08dc85c2dcf0
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 00:51:55.9344
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Dutm4lwZlEOWfN6fQZTOC1V3p7ayOxzpEQwZb0PenMrhQd3/s8vd2pjd5B5l9gwr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5943

Tested the series.

Tested-by: Babu Moger <babu.moger@amd.com>


On 5/31/2024 8:11 AM, Ilpo Järvinen wrote:
> Hi all,
> 
> This series does a number of cleanups into resctrl_val() and
> generalizes it by removing test name specific handling from the
> function.
> 
> Hopefully these reach also Shuah successfully as I've recently seen
> rejects for mail from @linux.intel.com to gmail addresses.
> 
> v5:
> - Open mem bw file only once and use rewind().
> - Add \n to mem bw file read to allow reading fresh values from the file.
> - Return 0 if create_grp() is given NULL grp_name (matches the original
>    behavior). Mention this in function's kerneldoc.
> - Cast pid_t to int before printing with %d.
> - Caps/typo fixes to kerneldoc and commit messages.
> - Use imperative tone in commit messages and improve them based on points
>    that came up during review.
> 
> v4:
> - Merged close fix into IMC READ+WRITE rework patch
> - Add loop to reset imc_counters_config fds to -1 to be able know which
>    need closing
> - Introduce perf_close_imc_mem_bw() to close fds
> - Open resctrl mem bw file (twice) beforehand to avoid opening it during
>    the test
> - Remove MBM .mongrp setup
> - Remove mongrp from CMT test
> 
> v3:
> - Rename init functions to <testname>_init()
> - Replace for loops with READ+WRITE statements for clarity
> - Don't drop Return: entry from perf_open_imc_mem_bw() func comment
> - New patch: Fix closing of IMC fds in case of error
> - New patch: Make "bandwidth" consistent in comments & prints
> - New patch: Simplify mem bandwidth file code
> - Remove wrong comment
> - Changed grp_name check to return -1 on fail (internal sanity check)
> 
> v2:
> - Resolved conflicts with kselftest/next
> - Spaces -> tabs correction
> 
> Ilpo Järvinen (16):
>    selftests/resctrl: Fix closing IMC fds on error and open-code R+W
>      instead of loops
>    selftests/resctrl: Calculate resctrl FS derived mem bw over sleep(1)
>      only
>    selftests/resctrl: Make "bandwidth" consistent in comments & prints
>    selftests/resctrl: Consolidate get_domain_id() into resctrl_val()
>    selftests/resctrl: Use correct type for pids
>    selftests/resctrl: Cleanup bm_pid and ppid usage & limit scope
>    selftests/resctrl: Rename measure_vals() to measure_mem_bw_vals() &
>      document
>    selftests/resctrl: Simplify mem bandwidth file code for MBA & MBM
>      tests
>    selftests/resctrl: Add ->measure() callback to resctrl_val_param
>    selftests/resctrl: Add ->init() callback into resctrl_val_param
>    selftests/resctrl: Simplify bandwidth report type handling
>    selftests/resctrl: Make some strings passed to resctrlfs functions
>      const
>    selftests/resctrl: Convert ctrlgrp & mongrp to pointers
>    selftests/resctrl: Remove mongrp from MBA test
>    selftests/resctrl: Remove mongrp from CMT test
>    selftests/resctrl: Remove test name comparing from
>      write_bm_pid_to_resctrl()
> 
>   tools/testing/selftests/resctrl/cache.c       |  10 +-
>   tools/testing/selftests/resctrl/cat_test.c    |   5 +-
>   tools/testing/selftests/resctrl/cmt_test.c    |  22 +-
>   tools/testing/selftests/resctrl/mba_test.c    |  26 +-
>   tools/testing/selftests/resctrl/mbm_test.c    |  26 +-
>   tools/testing/selftests/resctrl/resctrl.h     |  49 ++-
>   tools/testing/selftests/resctrl/resctrl_val.c | 364 ++++++++----------
>   tools/testing/selftests/resctrl/resctrlfs.c   |  67 ++--
>   8 files changed, 290 insertions(+), 279 deletions(-)
> 

-- 
- Babu Moger