Received-SPF: pass (google.com: domain of linux-kernel+bounces-203531-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240605112301.8171-1-animeshagarwal28@gmail.com> <20240606005332.GA3526959-robh@kernel.org>
In-Reply-To: <20240606005332.GA3526959-robh@kernel.org>
From: Animesh Agarwal <animeshagarwal28@gmail.com>
Date: Thu, 6 Jun 2024 07:49:27 +0530
Message-ID: <CAE3Oz82TsuDq5wAW4TSNeUuR0DTixAQPtJnCc3-5J7MnBYtuRw@mail.gmail.com>
Subject: Re: [PATCH] ASoC: dt-bindings: linux,spdif-dir: Convert to dtschema
To: Rob Herring <robh@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>, Daniel Baluta <daniel.baluta@nxp.com>, 
	Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-sound@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 6, 2024 at 6:23=E2=80=AFAM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Jun 05, 2024 at 04:52:55PM +0530, Animesh Agarwal wrote:
> > Convert the dummy SPDIF receiver bindings to DT schema. Make bindings
> > complete by adding property "#sound-dai-cells"
>
> 2 conversions of the same thing in one day:
>
> https://lore.kernel.org/all/20240605-topic-amlogic-upstream-bindings-conv=
ert-spdif-receiver-v1-1-262465adbac2@linaro.org/
>
> As I said there, I would just add the compatible to
> linux,spdif-dit.yaml. But this is fine too.
>
> >
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> >  .../bindings/sound/linux,spdif-dir.yaml       | 34 +++++++++++++++++++
> >  .../bindings/sound/spdif-receiver.txt         | 10 ------
> >  2 files changed, 34 insertions(+), 10 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/sound/linux,spdif=
-dir.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/sound/spdif-recei=
ver.txt
> >
> > diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dir.ya=
ml b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> > new file mode 100644
> > index 000000000000..61767873200f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/linux,spdif-dir.yaml
> > @@ -0,0 +1,34 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/sound/linux,spdif-dir.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Dummy SPDIF receiver
> > +
> > +maintainers:
> > +  - Liam Girdwood <lgirdwood@gmail.com>
> > +  - Mark Brown <broonie@kernel.org>
> > +
> > +allOf:
> > +  - $ref: dai-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: linux,spdif-dir
> > +
> > +  "#sound-dai-cells":
> > +    const: 0
>
> It wasn't in the txt binding, but users also use 'sound-name-prefix'
> property, so that should be added here.
linux,spdif-dir.yaml

If this is the case, I'll add the linux,spdif-dir compatible in
linux,spdif-dit.yaml instead of creating a new file in v2 of this
patch.

Regards,
Animesh Agarwal