Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757349AbYBESxs (ORCPT ); Tue, 5 Feb 2008 13:53:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750911AbYBESxl (ORCPT ); Tue, 5 Feb 2008 13:53:41 -0500 Received: from wa-out-1112.google.com ([209.85.146.183]:31983 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbYBESxj (ORCPT ); Tue, 5 Feb 2008 13:53:39 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:to:cc:subject:message-id:organization:x-mailer:mime-version:content-type:from; b=cCIyoplJ1VApllMV3s33NiyL8OgjWzGe1qwZzBFFFf2/Dd7I6SpVONdSybOEGqrHmqVJDCS1r6aeVZks1rS1OtEPasWMi33PvQCJacW+dFRmusNP9YPrnWxWZ2iXcCajJcMi3iPBjM7r6Siqka/QCyA7oke2ggqu7LzPG245gDc= Date: Tue, 5 Feb 2008 19:53:31 +0100 To: Russell King , rpurdie@openedhand.com Cc: Linux-arm , linux-main Subject: [PATCH/HP7XX] - Add combined LCD / BL driver for platform HP Jornada 7xx handhelds Message-Id: <20080205195331.fa2ca02b.Kristoffer.ericson@gmail.com> Organization: JLime X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.5; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Multipart=_Tue__5_Feb_2008_19_53_31_+0100_EkUg7vQQ_jUaZcKS" From: Kristoffer Ericson Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 18914 Lines: 456 This is a multi-part message in MIME format. --Multipart=_Tue__5_Feb_2008_19_53_31_+0100_EkUg7vQQ_jUaZcKS Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Greetings, Richard I've cleaned up the driver by checking with checkpatch.pl as Russell suggested. I would appreciate it if you could look through the patch again and give comments since the patch looks somewhat different. I can add patch for Kconfig/Makefile later on but suspect there will be some changes required before that. Oh and to answer your question regarding MAX/MIN values of the backlight, 0 = max and 255 = min. So we simply turn it around by returning 255 - value. Same thing when we need to set value. Best wishes Kristoffer Ericson diff --git a/drivers/video/backlight/jornada720_bllcd.c b/drivers/video/backlight/jornada720_bllcd.c new file mode 100644 index 0000000..4967b86 --- /dev/null +++ b/drivers/video/backlight/jornada720_bllcd.c @@ -0,0 +1,284 @@ +/* + * drivers/video/backlight/jornada720_bllcd.c + * + * Backlight and LCD Driver for HP Jornada 720 + * Copyright (C) 2007 Kristoffer Ericson + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 + * or any later version as published by the Free Software Foundation. + * + */ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include