Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp107924lqt; Wed, 5 Jun 2024 19:43:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6XMLCLyiWwdyx226Hw3VHKBwUPpaXfhBvuItWvfFUj36BT9L8AgiH4FoH/S6UiXHKaSaSlloQDNWD2DiubpOrEqN5VAu+pa5CK+niwQ== X-Google-Smtp-Source: AGHT+IFjidLH7yamNHFtAnu5jLStHcllM9BIIRfYaF0kXWQ+78ebhxvhLtaLWjBP8iE7dbpgie7I X-Received: by 2002:a05:620a:12f6:b0:795:1c70:91de with SMTP id af79cd13be357-79523d2da65mr436513885a.10.1717641795018; Wed, 05 Jun 2024 19:43:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717641795; cv=pass; d=google.com; s=arc-20160816; b=y/IeldLm/hjIBqRv0c+KF/PeTR6SmL/snnP9kBcbaUwezxRdiUsMg2uYMgjFmCETtz VXBItUofN0MIiDPg87mWF/Iv4vUbXJ7QHMVFT+e8hYFcfCyYuYtqIzYDumd8dv7deSyg irUdA64GL20Mqc0sM4NNB9tVzlN75ay1Y4HMk58fk3a6ay5F3FtsciCN8BxOmI14mmEW uSMmxyrh127LtYPLwaI2jMTmzHDWwiw5deiEQUpQW451oaNDPyNZrhgGGxr6p/Idd7pw QeUIEB5WyMkE6PeqnrCdTv9AbbYKj0FW3p0sy06VTGOB8lP4hoxTzk794Sn2XQqZxdCH eD4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=8NrSqWGK3tAVNbQ7MCEbg/HiiMed83/n7DWHMNxzJNY=; fh=0frYuUDT41hu48vMG2j/61jfH1aie63ktnd+sCtHA18=; b=QVQIL7wJinqNUv+fFb+pKTHi/xhZPCDB3WXoHkiuQDFi8reFcX1/b3xulAFi9icOhG UcpSHjxBrSTv8PWvLxNn4JdAK+WzIVr8O55Cv5Q7b2gkBjlJM3ozcgsfGh9zybH0jkrT cQH2YQepyA1ISuxS87YCknh2yXNu61KMou+81vu5LvrhBTuHyRYrBuz99gEBCkC6Xb3D VLK8JWoYs4tIZeFLPrtbHu0sbCK2WnkpxC1NjYckXKJkSMjNGxIqZyOpXqj9TXoRGd72 kYCGbi3SLQ07/hb06+F2Vojc+n9DJpA12v0gGlQO37vhBnbCxCVsm96JxzVZxU/R35+6 XV9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rQAT13a6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-44038b9052asi4713441cf.809.2024.06.05.19.43.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 19:43:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rQAT13a6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203544-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203544-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BA3441C216F0 for ; Thu, 6 Jun 2024 02:43:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D1A131DA22; Thu, 6 Jun 2024 02:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rQAT13a6" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1AC71BC4B; Thu, 6 Jun 2024 02:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717641788; cv=none; b=e6vf442TLw1JZOKAU36QAbYw+C5K/S4i6x26PirUc3hAWedJ5VUBDW02unwJQjTkSlJ6pqp3eAi8sapf83L4XRTEF/l22St+9gbYompS6BiZ5S7laIyCeLBBK4dFdtPI/qI1RpjwCzgwPdqAJcgjEG9lJRodKGuD1uA/v/xfZCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717641788; c=relaxed/simple; bh=NdLs97+ZjaEORCCIcuQq9rHIORg2yS+bwbRGKnoymKw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NjKij4twlquIy5AQ9B4O8ZN4wGomum7dAkvPTsLrSIbQLFu9ivmF0BWOW0r2jtft04n0oV+5zG48h+sQNjkP4xW/hZ0I5F8HgYLR8BQjeodnDaNo5YMQ7JuE8ptybbkAjFhh/0Li32BsIRN7n81aNwvSv7R29rMys7lVoNmjqGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rQAT13a6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DADB7C3277B; Thu, 6 Jun 2024 02:43:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717641787; bh=NdLs97+ZjaEORCCIcuQq9rHIORg2yS+bwbRGKnoymKw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rQAT13a6ueu56deIrs4ByfqUJjpP5YCQBI/8Ih/Oa2fMwVQUYUfXQxDt8mVTbn9IJ pl2uK3hFfIzpwa1IcL/VNGhpue8pG06ve1T93QO97++9WNlo1VOaZ8LVb3Dhs6aW8n 3K/ZuyxzXkw4RcaByMECjN3Oe+/U0Z6xCxgLrgzzhIY0gz0RDBu15Sd4gdHdVAvvvE 6NkPetdZEC2OPivdSUWG6+cPjv7UPZP7cePv9xbOENj+Pno9VxnbDZRljvM/kOGyup HLfVrLzJCVd/DjiL6h0y3buRJ9dDkKOvZDYfsQ2GZ1q7CiRz8gvgJsP5Gttrp9H4gG BAMSQ3Ncd60+w== Date: Wed, 5 Jun 2024 19:43:05 -0700 From: Jakub Kicinski To: Elad Yifee Cc: Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v5] net: ethernet: mtk_eth_soc: ppe: add support for multiple PPEs Message-ID: <20240605194305.194286d8@kernel.org> In-Reply-To: <20240602173247.12651-1-eladwf@gmail.com> References: <20240602173247.12651-1-eladwf@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 2 Jun 2024 20:32:40 +0300 Elad Yifee wrote: > struct mtk_mac { > int id; > + u8 ppe_idx; I thought Daniel's suggestion was to remove this field. I don't see your rebuke to that point or how it's addressed in the code. Also it would be good if you CCed Daniel, always CC people who gave you feedback.