Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp111092lqt; Wed, 5 Jun 2024 19:54:31 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXIwAPV/rDxMpUo5Dus59uX0EBGhKhIaS7OGMeWE4YcskJrH+D23b7UHFezA88eyPl7AW8yu3R/GZOuR2kSAoPr34uT+SldEmdg6VzXbA== X-Google-Smtp-Source: AGHT+IEcjm/waPE+O7+cuJHfwgwTQ2pAghWy0KGMii6RFtPUmiRTrDAN7oLvMsFPWKgmt0+MZtZN X-Received: by 2002:a05:620a:5782:b0:795:211d:f1ac with SMTP id af79cd13be357-79523d3879bmr474031385a.22.1717642470862; Wed, 05 Jun 2024 19:54:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717642470; cv=pass; d=google.com; s=arc-20160816; b=Z507JwHFcPufUYLHRh+QG491P3rF8Mxh93Xqk+qaC00zKfD0Qo/jB2GvuEuzMj9rBu at6tHPOqriswyzW4OO5anBOG+jq/5Gl7hoTEinLsFNNOWcweltBhEBYFwd0XRQbO6VNz YC8hFipg8K4x4b/LjfqlGYbGKyvbV0VhHHWMUOKZ8Ac3z/O+9VC5tZSzXdI4dEjFuvBz ZSXsdHTfcfL/c+NXmYkjKdHV4CkhrNdX/ns/oiGtfw+rSRt8WBVfmmUv2OeaG+S8JFT6 A9zj6u07/AxOHq5VqbEkcr55clvpbj2jWB1jknxCm64s+F5vs6gn2vl9N4mzQOwsSTY+ t3mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=qBs5aDRUfrpRRVtw5wPnjsjHugvU8MSOrxMRJvOYplE=; fh=kVcyTABE4eYDxZstQ5zoRUyg+n8MVRBD+Xb/qQljzkA=; b=GDFaCjvwRbXyyLDCEyTXuyLagMsdJuyv7XQh2sfDPUQN7+uDLXKLj/ljw0uZ8oNWUs e/KjWdv31Vu9k8H6uqaZU6cXS18WsQQ31rvjO7rCgEuWIx8trG1kK2lwi4kD4rKMmS6b I8zXKpOzVW4gNVg027AhgQweUVJZjbwenfV1PH9DgGYtm9tgjKkkoN//0Q066yI0YPNC C6OHuExMARvWWofqtUQfL+GwmbZMuBBCQKTUHoORYew03y8iIOiExhZIrUmMZyceGtb9 H/Z5ezek3cGEtWIW2wNIIr2rkxiPXwki99equrzjIYwqsD8zoFLdFXE12TG8YSXnGanH +DCw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E+JGGctL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-795331ca5b6si43188285a.257.2024.06.05.19.54.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 19:54:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=E+JGGctL; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-203552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 958F91C2126A for ; Thu, 6 Jun 2024 02:54:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1C68F1DDC9; Thu, 6 Jun 2024 02:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E+JGGctL" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4243C17C68; Thu, 6 Jun 2024 02:54:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717642462; cv=none; b=Pzdb5ULef1n1b9xuN1O5/HaLwIZBkufyRf7zb3mrsW1D3scP9Et2SandgbiOyZ2ccdVd2zLdm0kfZqnHb75w6fH1g263aUW2BVeEvaP/aspXYRkY9+cs2zrA76X3UHg1pmcxrSR4pep1zPPp1oFS6qedLtGt59mNroOauNmNw8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717642462; c=relaxed/simple; bh=MLnYIwDqlSKmUDFexu1Pj6yxjoOLhnj27TEZzHCziG0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s4ERvVwgL3MIGSUqhYByNz3nKihn2z2lh05TEFlC9UCsrT73pjuYH3BKCfk+pileyKrVDEe+hTOZepvViFwo15TkCCuOcL7KJC1P7GeAk8IH+SpVD3qxpa5+TAYSA0U0dsTMw+jbtiAjhXrDG+Iizz5GSpTdtZbu153i1fB9wYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E+JGGctL; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42A7BC2BD11; Thu, 6 Jun 2024 02:54:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717642461; bh=MLnYIwDqlSKmUDFexu1Pj6yxjoOLhnj27TEZzHCziG0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E+JGGctLP2NJ0SejSz2cPdqAsZgktmDM1pdGZD5f5f2rtJWaojPzdH2YzE6+fiOlk +n61hg6Jf+iVhzhIYLpQjRZs4K/fflz2AUduPW1poxad1izqh9vgMqGsFix2Hlver6 fahkr0lBiYJ9xM67lmFok+caorwwLwPin+71HhDRWE6VNpbn+bVe8cJLwGMqNy/J6z RRyxj2FBBSivBs1m8QSmVlqVpznSNcUQpiBnowcNzdc7s5LnXzzl73IDM1ImNZjh8o D6N2CQCXcxc9OTpWgntMTAk+lrhUHXC7CTy5j7oyAq4dIPL+FBYW1coPIBknDOFY+2 /2cAu+FbIRmEg== Date: Wed, 5 Jun 2024 19:54:20 -0700 From: Jakub Kicinski To: Sebastian Andrzej Siewior , Andrew Lunn Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" , Daniel Bristot de Oliveira , Boqun Feng , Daniel Borkmann , Eric Dumazet , Frederic Weisbecker , Ingo Molnar , Paolo Abeni , Peter Zijlstra , Thomas Gleixner , Waiman Long , Will Deacon Subject: Re: [PATCH v4 net-next 03/14] net: Use nested-BH locking for napi_alloc_cache. Message-ID: <20240605195420.2f47e6a1@kernel.org> In-Reply-To: <20240604154425.878636-4-bigeasy@linutronix.de> References: <20240604154425.878636-1-bigeasy@linutronix.de> <20240604154425.878636-4-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 4 Jun 2024 17:24:10 +0200 Sebastian Andrzej Siewior wrote: > @@ -308,6 +311,7 @@ void *__napi_alloc_frag_align(unsigned int fragsz, unsigned int align_mask) > struct napi_alloc_cache *nc = this_cpu_ptr(&napi_alloc_cache); > > fragsz = SKB_DATA_ALIGN(fragsz); > + guard(local_lock_nested_bh)(&napi_alloc_cache.bh_lock); > > return __page_frag_alloc_align(&nc->page, fragsz, GFP_ATOMIC, > align_mask); We have decided to advise against the use of guard() in networking, at least for now. Andrew, wasn't it on your TODO list to send the update to the docs? :)