Received-SPF: pass (google.com: domain of linux-kernel+bounces-203568-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Michael Kelley <mhklinux@outlook.com>
To: Thomas Gleixner <tglx@linutronix.de>, "kys@microsoft.com"
	<kys@microsoft.com>, "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>, "decui@microsoft.com"
	<decui@microsoft.com>, "mingo@redhat.com" <mingo@redhat.com>, "bp@alien8.de"
	<bp@alien8.de>, "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>, "kw@linux.com"
	<kw@linux.com>, "robh@kernel.org" <robh@kernel.org>, "bhelgaas@google.com"
	<bhelgaas@google.com>, "James.Bottomley@HansenPartnership.com"
	<James.Bottomley@HansenPartnership.com>, "martin.petersen@oracle.com"
	<martin.petersen@oracle.com>, "arnd@arndb.de" <arnd@arndb.de>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
CC: "maz@kernel.org" <maz@kernel.org>, "den@valinux.co.jp"
	<den@valinux.co.jp>, "jgowans@amazon.com" <jgowans@amazon.com>,
	"dawei.li@shingroup.cn" <dawei.li@shingroup.cn>
Subject: RE: [RFC 06/12] genirq: Add per-cpu flow handler with conditional IRQ
 stats
Thread-Topic: [RFC 06/12] genirq: Add per-cpu flow handler with conditional
 IRQ stats
Thread-Index:
 AQHatj3dxfDAEhKlmk6xJJhdAubqnrG36WaAgAAakqCAASXCgIAAA1YQgAANOoCAANYaUA==
Date: Thu, 6 Jun 2024 03:14:55 +0000
Message-ID:
 <SN6PR02MB4157AD9DE6D3F45EC5F5595DD4FA2@SN6PR02MB4157.namprd02.prod.outlook.com>
References: <20240604050940.859909-1-mhklinux@outlook.com>
 <20240604050940.859909-7-mhklinux@outlook.com> <87h6e860f8.ffs@tglx>
 <SN6PR02MB415737FF6F7B40A1CD20C4A9D4F82@SN6PR02MB4157.namprd02.prod.outlook.com>
 <87zfrz4jce.ffs@tglx>
 <SN6PR02MB415706390CB0E8FD599B6494D4F92@SN6PR02MB4157.namprd02.prod.outlook.com>
 <87cyov4glm.ffs@tglx>
In-Reply-To: <87cyov4glm.ffs@tglx>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?MeXDoziSiubnvCQwq/o9JKLOHPjy325GBSu5kzpwCIbVX+OSb+lQrQlZJNkc?=
 =?us-ascii?Q?rm1B/T0vNg9x/42nrdc75By7jyzVofTs6F/ZnXBedHguJHX0K1PUJjaHZTgA?=
 =?us-ascii?Q?SbqcAFIUPf8UwsTcG38FKx2xJAryiFreAo8Onq36wkWFlt8kVIeTA8WL9G30?=
 =?us-ascii?Q?AbKTG59tRKdInaiVYZLNn3o0e/9nigwrUTfvbx6c6Oz/z4kwmnRVGIkA3fuk?=
 =?us-ascii?Q?++dda5GxNf9WDprWnnAyTDyzB7gu7dY4y8RNOSTHF6zMdDdK0sGzaz+UViLE?=
 =?us-ascii?Q?eZxQNgONeoNZhX7EP1Dac1HQPs9bhWHyjPwCTtXuo1M/W4AfAjSbTakE9Y/P?=
 =?us-ascii?Q?HyVg5nV69h8t60zBJ+9cuEu3koZqEzpiZK0+ihj0O/wxVG6Y/WJYe15LX0ZM?=
 =?us-ascii?Q?k44nd2dLCjRrX195myDzGfUax6+L0gvUt3/7qV8hCkRKsW+TwIF+eApQR7Yo?=
 =?us-ascii?Q?TvmwXfT9Z6HnMbFcrwCgydjAPwQQ0cnOhHdzgGE374GdXgHvkJKprzFVLk4k?=
 =?us-ascii?Q?RCliG2FiY8KegYKy/Q6ImV86JB1iEU0PXLKM0PNAVCfNFN5u3C8mXIypst6C?=
 =?us-ascii?Q?oKFIdKdIfCLWDYyhKZm34VCKh4jRBCnTZT/yd4gjB/3Zwvx/8JEecYcFqiP/?=
 =?us-ascii?Q?IaqoZp7TYdaA2MgU8v+j9t9nJGg0ZyYKsr/AzUydCD01io0Oy+Zb1K6wj5Pe?=
 =?us-ascii?Q?zCMLeKP+BiDtXQOFGnEwokKKlzyi86ynnuPa8M6wT5igZCnKQPYdK1NPQR5j?=
 =?us-ascii?Q?6a6jOCTyd384caMXo25+SglmHSyqyWlm4HxdaYSgg/JNbBw3vO8ENmx2cR+N?=
 =?us-ascii?Q?5qJGqANEkcxv2Wm4IupvwSY7RnJhb+dmRx+8xaA7n8ICBQy/2nAe0VVp3m/7?=
 =?us-ascii?Q?NDJmlTZIjwMAKSQgWtqWNCFoq9s4gBa+G6TeaeGLxwDb/fEdb5q/kVW0sFjg?=
 =?us-ascii?Q?sEyZEsRTrOfdcnbc5RDm9K+1zLBLXxmVP02+7J6XYSYPd2GW3nz9laUljdlp?=
 =?us-ascii?Q?6skEbLdRw4WQ+TuFF6tKlTGQmM3MJ0fXe+NwApBzQD6dioJEGcbE+hf/bJlk?=
 =?us-ascii?Q?qgRFT6wexyluZ+O342hfwuXdOShhxWMzzIqBXrk2yE8+Tr4qc3mNLxeV4Hhj?=
 =?us-ascii?Q?1y/SojeV6ReOhU00SURV6WlbdXKCAURJj7mamOmpMmcbYYQh7nAy398J1XdA?=
 =?us-ascii?Q?Fci8SuaCBuhGKqQ6qlImSXLHhchy049QNarwZ8v7s0TE6F0vheZoYPO+37k?=
 =?us-ascii?Q?=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 83167f07-7914-49cc-b829-08dc85d6d704
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2024 03:14:55.6609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8063

From: Thomas Gleixner <tglx@linutronix.de> Sent: Wednesday, June 5, 2024 7:=
20 AM
>=20
> On Wed, Jun 05 2024 at 13:45, Michael Kelley wrote:
> > From: Thomas Gleixner <tglx@linutronix.de> Sent: Wednesday, June 5, 202=
4 6:20 AM
> >
> > In /proc/interrupts, the double-counting isn't a problem, and is
> > potentially helpful as you say. But /proc/stat, for example, shows a to=
tal
> > interrupt count, which will be roughly double what it was before. That
> > /proc/stat value then shows up in user space in vmstat, for example.
> > That's what I was concerned about, though it's not a huge problem in
> > the grand scheme of things.
>=20
> That's trivial to solve. We can mark interrupts to be excluded from
> /proc/stat accounting.
>=20

OK.  On x86, some simple #ifdef'ery in arch_irq_stat_cpu() can filter
out the HYP interrupts. But what do you envision on arm64, where
there is no arch_irq_stat_cpu()?  On arm64, the top-level interrupt is a
normal Linux IRQ, and its count is included in the "kstat.irqs_sum" field
with no breakout by IRQ. Identifying the right IRQ and subtracting it
out later looks a lot uglier than the conditional stats accounting.

Or if there's some other approach I'm missing, please enlighten me!

Michael