Received-SPF: pass (google.com: domain of linux-kernel+bounces-203596-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <fbc30c3a-ecd3-4525-9434-307c7769bb4c@amd.com>
Date: Thu, 6 Jun 2024 09:16:08 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH rcu 2/9] rcu: Reduce synchronize_rcu() delays when all
 wait heads are in use
Content-Language: en-US
To: paulmck@kernel.org, Frederic Weisbecker <frederic@kernel.org>
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com,
 rostedt@goodmis.org
References: <657595c8-e86c-4594-a5b1-3c64a8275607@paulmck-laptop>
 <20240604222355.2370768-2-paulmck@kernel.org>
 <ZmBVfpyEZeTIAHJn@localhost.localdomain>
 <c7d07e5d-34a0-4874-8e7e-1c576c14c8e6@paulmck-laptop>
From: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
In-Reply-To: <c7d07e5d-34a0-4874-8e7e-1c576c14c8e6@paulmck-laptop>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bnhKV2tKUDNTcjBIUFQ5V3dHOE1mMDAvVXZ6cFdZamsrdVJuQjE1V3Bla0ho?=
 =?utf-8?B?ZFUrVGdJTlRVWkdZeGVoNE1pbHp5V05ucm52N05WL3ZTVjNYOUpHaEVYS05v?=
 =?utf-8?B?TS9Lb3N5Tk9RSG9KNEtiVno0R2swcGVVZFN1YWxRYjV5Wm5IeStJaGQwelRR?=
 =?utf-8?B?cHBSc0ZyUHZvUDRPYWozQUEyTWJSWk5wUm5Tck54NVdpTG4rdHhKM2t3dHMz?=
 =?utf-8?B?N2ZoMDRhU0JRZ2N4R3duNmFuQzczdWZVWmtBNXZ6VjdoL2cvZ1A2eFdKaEZq?=
 =?utf-8?B?ZGJ2QXlXTmhtZjZCS2EzZ2FGMmw2Q1hhelZLNDByYXhLVGZtaWVJOStWM2JX?=
 =?utf-8?B?SnpwNzRQL0t4Mld1Z21JSWRZeDZ3K2VkdXFVY2JIcVpjSk0ydzF3VndDcm8z?=
 =?utf-8?B?U0hPZ2Y2ejdnWFRXZWxlWkE4ajVTb2VycFFXcVR1bUtOTHBxaFpQc3hXRFNK?=
 =?utf-8?B?MG5WVmk1UEp6ZXZ5RGVXSEwwSjF3TTFBL3RITXZ1TTA0QnVBYmd4M0E1Ni9v?=
 =?utf-8?B?MVh1RjNEMnNwcU9ockQ4Q0RJQXNuNGNUbjhEYkpXUWpqc2ZxYkxqb1hPemtH?=
 =?utf-8?B?b0NrUkJ6S3o3QlQ2TTFKMDBXaHBHbW1GL01acDVYQm5FYmtRaTBzSThKa1Vh?=
 =?utf-8?B?Q3MrYzBHRXJvUHhlOElWd29ZbEdWVWV0cFRLcUUrbzVKTFJTaGdTbFBGWVNo?=
 =?utf-8?B?RTRCSHNSdExmUTBDK0Q4VzVKc3ZCRktjY2c3RHRlSnZkT3pTV0NFcTV5eURV?=
 =?utf-8?B?RjFQWVMyV2pWeUNUWkp0QkE4ZlN2MVZCa0Y4YWttYTk5blBWZHZFWU9SOXhN?=
 =?utf-8?B?eGIyUnJpSDFWbWVGQnRNNnYrRWtVSHg3VUpCakJFMzA5NXJLaHNiaHVKV0V4?=
 =?utf-8?B?bHdGcmFLVWJpSUt5U1JvYWN1ajMranVGRmlhcElRZ0RoWHVPc05WNlYzTnpJ?=
 =?utf-8?B?QWJ4UUdveFJsM3Ivai92K01NK2NpNFJ6cjJFbXk4NFlTS3lqMEJlUm8xaFFC?=
 =?utf-8?B?Z2ltRnVTRDBoUHlFTU5jVWw1anN5WGhCSzNMdHYyRzhoaCtGQnl5MjZnQldL?=
 =?utf-8?B?RkJKbWVXRjJSSFJRVmZydlJoUGR4VjBaYVU4MU8yMUhQdVZVeTB6d0VaaHk5?=
 =?utf-8?B?NFZFVmNkU1RuWXQxL3ptYVh3MXNNYVhJTnFSZG80OWNJa2dGM3BUUGhTT2lv?=
 =?utf-8?B?RlhjTnZab2hUSVFJTTlRbnNsaW0rVDNGQ3B5SHBQbHltSXlnUllnRlYvbDVW?=
 =?utf-8?B?S2kvaUd3NHVDMGl0MExDd1JqSnVBbXFuT2NwWm1kc2hOb05mTWRwSDFuV2JN?=
 =?utf-8?B?QmFXUlZlbHBkMHM0M2dBNTJ6eC93K29EWk9EYkwxVWhjRWxEY2ltNHY3K2dv?=
 =?utf-8?B?N2NrWEdMc0VqRFFSbEZuTmpOdGUzVmtmWTBrZ01LSkdCVWpPSXlYRjNxM3Y2?=
 =?utf-8?B?ZTVlQzVXcmtERWdXV3M2M1E4cmN4Z1RaSnFHQ0Q4aTFoUXkxK21pVy85MGxJ?=
 =?utf-8?B?MkMxSS9WeWM5MTdQVHlacklKSWZmTCs4cE52WEg0SmtybHAzSDJUcHlrb3dW?=
 =?utf-8?B?VjgvWVR1Z3NvekRyY0xJcy9LbkJKR1UwWVdGR1kyOTFjK0ZrczJjUUFNMzVY?=
 =?utf-8?B?RGRGcjgxWlI3WU1xOEU5anAwQzZ3SVZxZ0VrWllRMENjOHBKbG9nYlNndWY3?=
 =?utf-8?B?OGxQMnV5WWRkUGxsa3NqSmJMcWRkS3NCcVFBYy8vWUVHdlVldVhrZE1oSFFN?=
 =?utf-8?B?MXg5ajF0azdNbkVBSUorU2pWcTVwMUpoRTN0Z1lZTDd3UXVXN2tOWjJDbkZs?=
 =?utf-8?B?cEhzUW1MMk4vemhtb2QwazY3QjF1SlBVaXpkWTU2c0Rqc1M2Q1ROY0NKVVY5?=
 =?utf-8?B?cjIrZG42Sm5iaysyZ3MrWHdGWXp0SWpoY1U3S3ZVZ29PN05vSnB5S3dDVjFy?=
 =?utf-8?B?ZUJIUlZKeGYzNnNtMit4Uit6aTloYktuUlBqWXBrVzVSUmNCQllKb2NHQXlo?=
 =?utf-8?B?RmxxRHBIZ3VDdHBzVm9PWVhmMDVXMXdQUEpZTTUweFl1QjlvWktyWWh3UEUy?=
 =?utf-8?B?dlh4SExqY280VjlqUlRxNUt1RUQ5aFNQWm02Y1N0Yi9XLythSGs1YStvQTZp?=
 =?utf-8?Q?pAFV3lPMoq1B0HltPaNvXvuCf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae8b8918-fc10-4b8d-b996-08dc85db39b7
X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB6608.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 03:46:19.6044
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ObVp0Y2SkwQZ9xtOJwSWFn6zNlRU1UYlClHvpU3mR1/V3UEEZrHa2MOrvLO8BIfI70F/Lw+7QBAXJvOgrGi4pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9154


On 6/6/2024 12:08 AM, Paul E. McKenney wrote:
> On Wed, Jun 05, 2024 at 02:09:34PM +0200, Frederic Weisbecker wrote:
>> Le Tue, Jun 04, 2024 at 03:23:48PM -0700, Paul E. McKenney a écrit :
>>> From: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
>>>
>>> When all wait heads are in use, which can happen when
>>> rcu_sr_normal_gp_cleanup_work()'s callback processing
>>> is slow, any new synchronize_rcu() user's rcu_synchronize
>>> node's processing is deferred to future GP periods. This
>>> can result in long list of synchronize_rcu() invocations
>>> waiting for full grace period processing, which can delay
>>> freeing of memory. Mitigate this problem by using first
>>> node in the list as wait tail when all wait heads are in use.
>>> While methods to speed up callback processing would be needed
>>> to recover from this situation, allowing new nodes to complete
>>> their grace period can help prevent delays due to a fixed
>>> number of wait head nodes.
>>>
>>> Signed-off-by: Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>
>>> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>>
>> IIRC we agreed that this patch could be a step too far that
>> made an already not so simple state machine even less simple,
>> breaking the wait_head based flow.
> 
> True, which is why we agreed not to submit it into the v6.10 merge window.
> 
> And I don't recall us saying what merge window to send it to.
> 
>> Should we postpone this change until it is observed that a workqueue
>> not being scheduled for 5 grace periods is a real issue?
> 
> Neeraj, thoughts?  Or, better yet, test results?  ;-)

Yes I agree that we postpone this change until we see it as a real
problem. I had run a test to invoke synchronize_rcu() from all CPUs
on a 96 core system in parallel. I didn't specifically check if this
scenario was hit. Will run RCU torture test with this change.


Thanks
Neeraj


> 
> 							Thanx, Paul