Received-SPF: pass (google.com: domain of linux-kernel+bounces-203615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <241cb8ec-14c9-4d7c-9331-2df0b8bf21b2@amd.com>
Date: Thu, 6 Jun 2024 10:43:39 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate
 magic-packet property
Content-Language: en-GB
To: Rob Herring <robh@kernel.org>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 linux@armlinux.org.uk, vadim.fedorenko@linux.dev, andrew@lunn.ch,
 netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240605102457.4050539-1-vineeth.karumanchi@amd.com>
 <20240605102457.4050539-5-vineeth.karumanchi@amd.com>
 <20240605154112.GA3197137-robh@kernel.org>
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <20240605154112.GA3197137-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NjJKaHQwSVNSTFFjMG5yY0djVC9QY2xtaVMzS0xxYU51NkhwMGJ5YWEvSzJt?=
 =?utf-8?B?UGJ0Z25SbmhIZnhqeUo0TUV1Z1pmRU5vQWhoSDV0ZzhOOTkzVThod3g0ZTBw?=
 =?utf-8?B?YnVmVXRmd3FLWFpRMEJRSGZHS0VBTUZxcmtLMkVIZHRKOXI5OEdtN0xCTGx2?=
 =?utf-8?B?OTV6TkExektrd210d05PSmVYc05mczdVWXZpbHRNTHJTVU1YdzNtaUdjTytJ?=
 =?utf-8?B?UFlXcHFpWXlHNmpPZVBHYTVVRzVub3p0MldvMTJqWFpxWnA2Zk1mbTZINGxv?=
 =?utf-8?B?c0l6WE1EN1hQWWlqQVFwOWorZzhHdStMbDI1NGUzTmxpa3NMNDNFUEZDRkp2?=
 =?utf-8?B?MDhVM0tteFlYYUJqMENaKzFDVUxJM0NUdDlvU3V3MU94NFh2bnF3bkNRWjN0?=
 =?utf-8?B?clE4L0Z0Y1NPcERiTGxJYVpDaUFpd3QvTlpHeGVuT1BYOThDYVNvZWRHMVQ5?=
 =?utf-8?B?VC9rQ2tXNEFkSlE1NVNCUW5sb0ZmTHhxd3FSajFIUExnZkRucEl5eTBjbnVL?=
 =?utf-8?B?azJWSERTblZsaU9HbzdkQ2FtSzhhdHIwNHpFT1hvSnFnaXB0eUdxeGtUNmJB?=
 =?utf-8?B?bm14WnAwSVlUZkh0dW90QVpPODZJYmplOVRMU2hVZWtDS0FyWS8yOUtuOTVI?=
 =?utf-8?B?MWNQc21PeUFWZkJXSGtCRXVaUmhOOXV2Rk5iT0o2N1p6RDA2cDZoYmMxQ3Ir?=
 =?utf-8?B?eGsvOW5QZW5UcnlGVzJWZGpPa0oxL0RDYnlTclFtcEkzYWszakNjV05RWmZE?=
 =?utf-8?B?VFEyb0J4UWgybHFOZkRrUnFtYTNQYnJyQUtiVmJLKzN1U2hKVWJPZVhBTTJP?=
 =?utf-8?B?TkY5K3hUemo0M3prZFQyOGdyM2ZrQ3ZvaGt2dkhlL0pkL3l2aTdvaFByd1hn?=
 =?utf-8?B?OTNmNmhrQS91TlFqS0loaGY0SEtSWmtTcXZ6WEdhUUJORUJOUUw4Ym5tREhl?=
 =?utf-8?B?NFVacElrUzdDTGRlZmgwT1lRWTVPQzQ2dzlJQVZUSE45dWIwOXplL29TdGJZ?=
 =?utf-8?B?U0RQMThyTmpOejRtSEZsYVdiOXA0Z0ZoS1JSeGkwK2trYTJrUDlRRDBhZ0dt?=
 =?utf-8?B?bm1NdkVIU1ZaTUFaTDFCYjlnSzl5bmdlUCs3bVhDbzArNnFaUzJLRzZKRlQy?=
 =?utf-8?B?V2ExSUdGSW1kMWwwbGg1N1dVbHVMM3ZoNnc2Ris2cFNqQ2Q2VVhNY0VhMjAv?=
 =?utf-8?B?S3AyNjdlcU5lSGdudUFpNHdxcUx0elNsTnJQbG5ZWVpKYkpGNkdFRUlyaG1z?=
 =?utf-8?B?OVlQbVhma1NMUzg3ajN0NFVmZDd6SERFWFRBRXd1RklUS1hSdnpoUzNrbTl3?=
 =?utf-8?B?WUo4dnV2elJJM2ZDOEx5VEx4bWM2RXBYZHY5Rk45TnJuemxmRlNld2VIUlpZ?=
 =?utf-8?B?bDllNUNrNGp5OGNIVXdlVXJiYW5aSit5TmtDcmU1b3lWZ0RDQVFPbkRDWXo0?=
 =?utf-8?B?cUlMdU1LdTBOYWg3R2dBRGYwbnF3MllReTBrM3ZHandoZmZDRG8wRUpPdDRH?=
 =?utf-8?B?M1BXZHY0OXlZYmw1elhyV3pDZmlKMXkvRkhCTGp2RHl6b3FyRmhjVEhqTGNv?=
 =?utf-8?B?cmdvTldaQlloanJhZkNHdFRMdXUzYjRDTDREVTUrNEViOElMeGpYcm5xOWdC?=
 =?utf-8?B?aTU0Q3Y3cnFYRFA4SXBuVnpESFpYNTMvcDRZNnN4Ly9HQ3hUdEc4QmZQM0lk?=
 =?utf-8?B?Y0UxcC9XYjJtektGaUdnUU9EM1c0ZTFDM01mSW04SDk2c05qUENGczF2TVhs?=
 =?utf-8?B?aHpaQTgvdm1kZWF2WENSMVdxRzlWaGdSWS9rTGt2OXhtZFltQlhMN2FPWFJp?=
 =?utf-8?B?Z0lXeklpdGhuN2FQckZreS9RRzNNNmdQOGI1T1RyeWJPUWJPaFplUnBpbzZp?=
 =?utf-8?B?LzN5YnVhUG5nWmVSeTIwTGM5eWViVEdCKzVUTXVRZnR6ankyOGZSUGhSM2hv?=
 =?utf-8?B?N1ZZRU4waXlvcml5UFlLcWdLT2FpQWZFRzhhb0xiRVlrVmxOZm5lcUhhRERh?=
 =?utf-8?B?a09vUnpvQmhyVjhiazJncXJxRTMzUHFYSXQrTzUzODJjMWI0MXUxRFB0di9Q?=
 =?utf-8?B?a2JKQUlQbUF0Y0w3bEdHVE5GNTZRQ05wNnhHNDZLbWhBNW5sL1NIRDRpNGlF?=
 =?utf-8?Q?lb4U6rwHrwQR+3Co8GkCa/5Bw?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81ac8288-d832-4382-ed41-08dc85e77354
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 05:13:50.1909
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4XZpTTYchbPDdVMHuA34uelLZxfY4d6AiT0d6wjpt2/4ZLk3XR67/tYhC4uDziKj
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7702

Hi Rob,


On 05/06/24 9:11 pm, Rob Herring wrote:
> On Wed, Jun 05, 2024 at 03:54:57PM +0530, Vineeth Karumanchi wrote:
>> WOL modes such as magic-packet should be an OS policy.
>> By default, advertise supported modes and use ethtool to activate
>> the required mode.
>>
>> Suggested-by: Andrew Lunn <andrew@lunn.ch>
>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
>> ---
>>   Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>>   1 file changed, 1 insertion(+)
> 
> You forgot Krzysztof's ack.
> 

There is a change in the commit message from earlier version,
as we are not using caps any more, I thought of not including the ack.

I will add his ack in next version.

???? vineeth

>>
>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> index 2c71e2cf3a2f..3c30dd23cd4e 100644
>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> @@ -146,6 +146,7 @@ patternProperties:
>>   
>>         magic-packet:
>>           type: boolean
>> +        deprecated: true
>>           description:
>>             Indicates that the hardware supports waking up via magic packet.
>>   
>> -- 
>> 2.34.1
>>