Received-SPF: pass (google.com: domain of linux-kernel+bounces-203620-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <79562882-7cf7-4d85-9072-d655d2828534@amd.com>
Date: Thu, 6 Jun 2024 11:04:09 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] perf/x86/amd: Warn only on new bits set
To: Breno Leitao <leitao@debian.org>, Peter Zijlstra <peterz@infradead.org>,
 Ingo Molnar <mingo@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>,
 Namhyung Kim <namhyung@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
 Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
 Adrian Hunter <adrian.hunter@intel.com>,
 "Liang, Kan" <kan.liang@linux.intel.com>,
 Thomas Gleixner <tglx@linutronix.de>, Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
 "H. Peter Anvin" <hpa@zytor.com>
Cc: leit@meta.com, "Paul E . McKenney" <paulmck@kernel.org>,
 "open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-perf-users@vger.kernel.org>,
 "open list:PERFORMANCE EVENTS SUBSYSTEM" <linux-kernel@vger.kernel.org>
References: <20240524141021.3889002-1-leitao@debian.org>
Content-Language: en-US
From: Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <20240524141021.3889002-1-leitao@debian.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WkhpMitZRkdWN291ZlhMTGIxdlUzYUh2NEJnRzRNbFJRVHdsRzNCTlVNcFNs?=
 =?utf-8?B?N21JRlJjYkJtay9QV0J5N3hBaGNzVjdDakwvR3ZJK3hDL1ZrVmdoUW00bDZz?=
 =?utf-8?B?Q3pqMy9qcjdUd0dBT0NqOC83aSsxMkZPOHZVb1l1QzU2czVrTG82UVB2REUx?=
 =?utf-8?B?RjZCQ21SaXpRdDVIV0g2L1JmaEJPWFNSMldURHRNSHMrQTFLTFZvdGl6d25w?=
 =?utf-8?B?WHVZeGo4L0d2SFJyN3prR0dRZDc1OHNGSXZ4QVFwSngzZG5YeWxPZ05ZdXIx?=
 =?utf-8?B?L0xkUkpzanYzcmN0T2hTMEpKZTRWa3NObU4xcnpiN0NtUittZ0FCT2c1cEl3?=
 =?utf-8?B?OEdpbVA3QUVJMjhtczBXN1N0Z3JiV1VWUk5YeFRDQjEvNU5KcUR1bDdBNGYx?=
 =?utf-8?B?Z3dYMXNWL3M4VnhCVWpiQUp5T2lwVzJSQmN2OUZTaVVIaTBBQTNBK1VLTWZn?=
 =?utf-8?B?S3hObTZVQUlhYTlkcjJvSFpnaldLamozaWF4aENYOGVXZ0VBRXJKVDB0RWVp?=
 =?utf-8?B?cncydERpTUJYZCtEZTZRTGJZcEFwbEpieFJyVjRnZmVIWlVIQ0lSMzVLQ1pI?=
 =?utf-8?B?QWtaNlcrRzFzdFVvMTJMbkVSZWl5Y1c3QVZtemh5Y2ZaUXdYRnYwWitFeDEy?=
 =?utf-8?B?RHh3eThadzZBdXpvdGNlQkVFa3dlTGJScWlaSFZOSmNEbmp6VzMyc0RobUxL?=
 =?utf-8?B?RGpLVit3TU9lQi9vZ3pDZFMzTHRsNzE1RnkwWGZoeXRJRzdSd3dEMVJ0ODB2?=
 =?utf-8?B?bVUzNmI1RGhlNThJODdrUmFlS1lTS2JJNnM4QmZkOEVmMWZ0bGk0MmxCRjlR?=
 =?utf-8?B?dXgxUUM2VzhEOUV0K1A5NENkTHN2VFBWQlY0RWcweWt6RzJzcTgvNmdFc2ov?=
 =?utf-8?B?cExMcjNTOVh1UVlMbG8rR1V2UXh1czc5S0ZkOHVpZWtWRzdnQ244czV1eDNN?=
 =?utf-8?B?a0lsbFpaY0R3WDBXNUVwRzhVRHMra1QzVDFObTFQQ0FLdEc0Ynlsb0o2UEI0?=
 =?utf-8?B?NTE4ZDhCNFRsVzlXOWVqejF5WVR3M2RnNmsxeGk1NFlqdG9vZUMrSWloSkF3?=
 =?utf-8?B?MHhHVE5uTk0xOFBkSDB0b0oxUHl4TUhic01kcmNKaU40K2pkWVhYT1VkUFhS?=
 =?utf-8?B?d2E2NGwvd3lRWXFsVytSRFlrQmZObEZrenZMWTdVc0dESmkrSkl5em9SZmIr?=
 =?utf-8?B?WGJ6UGhRQVZvVlhpeHJDRFk1eHN3UzZFdFBCTmh5TE0zckcvTE5YTjFObXpG?=
 =?utf-8?B?VkxSUmFSVUtoMHRHWFFlZVZCazVzVnBHS0cyWENhVTgwbGpEUUVyR3hjVmwz?=
 =?utf-8?B?R0Jjd0VTUFBVaEhXaDdPQnIvczRZUU5tdmVOVW1xV0hGdFM2aDQxb1NjSGFU?=
 =?utf-8?B?bDhoYUNhVkt3MytOMXBHT0w5QkN5QzFzOWFPQlIvZC94Y3VjZlJBdUJ3Z1Ix?=
 =?utf-8?B?ZU5XVWFQcFJZRW1NdE95WHJuVWM3R3BQWUpJeHpzeUV5L3lMVFFvY2pGRHJK?=
 =?utf-8?B?dWoxa3BPUkI0SEozbjZvTWdWeHVJb3VoWnJHN1VUdGxXbjNlWjd2SmY3Y1Vv?=
 =?utf-8?B?aDNmVkhKbzBWMTNka2pNMTdxYlJ3ZnRWQ1haVW9iSnRBalV0MFR0WER1Y0pz?=
 =?utf-8?B?UFRmcE1tNS90WEpSbnJDcHJXOHBCK0JrMWpTdU02WjBCT05hbi9vWld2dnlp?=
 =?utf-8?B?QUE2cXhJbm1tL1dvK1lxbXp6bFBTck1EdkJGdm11MnJORE1RQ3B6SnVEKzVu?=
 =?utf-8?B?WFFodU16Y1BFL3hhNi94bC9BWUJpRlpQNjQxa0FsVkhaNC9PdmE0Snl4ZTEy?=
 =?utf-8?B?WTVrUEdtM0Z1RTExM013ZWhNV3NzUDZJVVpnYVFvVFFrNlVXcUY0aGhHR1dH?=
 =?utf-8?B?NS9UT0JzS3ZEd1p1cXVEV1Z6K0NlUmY4U0Evd1Q3WTVqZ2wrNmNteEQ4Mkdk?=
 =?utf-8?B?cnE2UllGZGc5ZnU1bExLdXI4OXdkZ1BqNDVORGdteUdJZWd1a0ZJeXJ5bVR5?=
 =?utf-8?B?NUhQTlFLWkFGZVhKTEgxbG9VbFNlTTcvVVA3bW5uM2hsQkRkR1NTREdybWFV?=
 =?utf-8?B?WE9BaloxMm9oNzE1bHk4TEhNL3FHd3JhUVBJVHljdkFNSjFPMkFFZXlDL1cv?=
 =?utf-8?Q?e+IV5ndQcpeaSOWGe5xXCilPU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adf0b7d5-e350-4074-9bcb-08dc85ea5394
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 05:34:25.4520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tDr/XnaMAI1vKnDXG/zuXrAyxe6S/zGux4usIejP4CGZQojaGamDw7gabOwi1RZL6+g09fzB1wE1e2ZusBcL8w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7513

On 5/24/2024 7:40 PM, Breno Leitao wrote:
> Warning at every leaking bits can cause a flood of message, triggering
> vairous stall-warning mechanisms to fire, including CSD locks, which
> makes the machine to be unusable.
> 
> Track the bits that are being leaked, and only warn when a new bit is
> set.
> 
> Suggested-by: Paul E. McKenney <paulmck@kernel.org>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Sandipan Das <sandipan.das@amd.com>

> ---
>  arch/x86/events/amd/core.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
> index 1fc4ce44e743..df0ba2382d13 100644
> --- a/arch/x86/events/amd/core.c
> +++ b/arch/x86/events/amd/core.c
> @@ -941,11 +941,12 @@ static int amd_pmu_v2_snapshot_branch_stack(struct perf_branch_entry *entries, u
>  static int amd_pmu_v2_handle_irq(struct pt_regs *regs)
>  {
>  	struct cpu_hw_events *cpuc = this_cpu_ptr(&cpu_hw_events);
> +	static atomic64_t status_warned = ATOMIC64_INIT(0);
> +	u64 reserved, status, mask, new_bits;
>  	struct perf_sample_data data;
>  	struct hw_perf_event *hwc;
>  	struct perf_event *event;
>  	int handled = 0, idx;
> -	u64 reserved, status, mask;
>  	bool pmu_enabled;
>  
>  	/*
> @@ -1010,7 +1011,11 @@ static int amd_pmu_v2_handle_irq(struct pt_regs *regs)
>  	 * the corresponding PMCs are expected to be inactive according to the
>  	 * active_mask
>  	 */
> -	WARN_ON(status > 0);
> +	if (status > 0) {
> +		new_bits = atomic64_fetch_or(status, &status_warned) ^ atomic64_read(&status_warned);
> +		// A new bit was set for the very first time.
> +		WARN(new_bits, "New overflows for inactive PMCs: %llx\n", new_bits);
> +	}
>  
>  	/* Clear overflow and freeze bits */
>  	amd_pmu_ack_global_status(~status);