Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp168503lqt; Wed, 5 Jun 2024 22:57:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWFb+8JrFcgTrIuHrTHF3WnG4401XlXHK71D2ofPChQwKzyERYjLtH4Ls3tWPpfZnsjk3ASjAFplfJWI7gwrbrrAOpD+jbxgAk40/HiNg== X-Google-Smtp-Source: AGHT+IFt4oPPcTTl1JbTNxrNyJ7n18pYgYtYkPfdpzkXpmas/ZWtxLyE0ynpRj5ODpWWF/DHZptM X-Received: by 2002:a17:906:16d8:b0:a68:9a5c:a2a0 with SMTP id a640c23a62f3a-a6c7651b10bmr123000966b.36.1717653435395; Wed, 05 Jun 2024 22:57:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717653435; cv=pass; d=google.com; s=arc-20160816; b=rBABEKcaL8HmMO5q2sZ+5bZvr/1O78ENG39JGh0XPZL9tdUpjbdt/lzvKRCmN/znEC mZB45BATMYVzkaffw49xVkvt9ZJ++OyARZhECFI25Dlrq3f/2Rnm1eCvcFOvOFGhBMRe OmVab82zqh/njMwOIywScpxX9Vw7Hr9b91G0XWnFnwCRH3QdMRrKE4ogzqVP1PuSAcJp +HmN373NSydM/BFY8tjPZ+sTtVJMrTlwMyWl4Q6eL9t/ey33eulBXgpf+H78Lel4G5dS hT8Yjg7DOU4PdQ6TCYBmRZoGQ+0+D1+vv1TiqHToAGFiY0ksidWzcPX1FPOA40ejEJDS sWLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=67dVbFD/2DQF9usMWt43fKDwppvEBt20ndKl7bU0GFw=; fh=ce6DJNwO/J1LvO0GcFZ4RcNnn00hNQ0lVLzXqoxG/Fo=; b=sxmYQrNg+1zVMquTH54yWoW0eMN95tBnzdMYwZR2NDKDkMk89hNA/s4VSYW9HlEQle kGVJmHTqVa6nXZaRqAQi1q3dhi6/2ufKZmiRINW6bRhiJ/fkNzADkqkXmfb2H3QS1amq aCyi1wULU7NLDGvc1wuvxVUUQYjN1s6B5ZM+iIQkVtTXO9ySBdatrMR9G9Z1m1guYol6 Lom9XQBcAu0rTX0GKEJyepCzcB/WMi3UJ1hJ7bNqBfq145TB1vlvzcPGUZ2Xs2SROS6G T8nWtJc+eQ1wHHtYv2s5X0L4WwxvUi83P2+g7TTP0Lx6wXx+4IApDZUJM9gs8LZ1gMQ+ wpJg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lgC91G2C; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-203631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6c80581995si30991066b.84.2024.06.05.22.57.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 22:57:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lgC91G2C; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-203631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203631-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1CD921F25F92 for ; Thu, 6 Jun 2024 05:57:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2190B3EA72; Thu, 6 Jun 2024 05:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lgC91G2C" Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE5C628376; Thu, 6 Jun 2024 05:57:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717653423; cv=none; b=nDotJJ6jDf7GNhMpfjM78aJbE22mJC5jYyggDs8mSWsr9FLcJjlg3RhMXHEJWUZZR50sGMwjnsi1StrrIVzNzAgW9e4dlIu+jytwKfVxoUplS5ba0xk5kpr2OqI8jkKBCYI8zGIoxL+UK+/w3BJDZRMo5WL9eLq1knLLYvJkizk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717653423; c=relaxed/simple; bh=/t3HMt63rItxc4gjrIQ2pDjEkGz9nwhITQHO3zrMkGc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=NGiBSfVI1V3FyldkGzOb83U0EEROhMyZQpEeZxWJX2h2fbHfu0yfgJdYdAIFe1FtSQ9NdI96sxVbmUdGkilsCzbnZfS7fFnyLmEsXxClzlnOyke7NUAPh3pJ71V79cOPVXo+ITh7qzhAzzaV+5y6aUVcIyFWYeJ5IoLBCpt+Ffo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lgC91G2C; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-35e573c0334so951701f8f.1; Wed, 05 Jun 2024 22:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717653420; x=1718258220; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=67dVbFD/2DQF9usMWt43fKDwppvEBt20ndKl7bU0GFw=; b=lgC91G2Cg7YWV9X2MYIWinhCJPCYTebabnCpiFaWxkcGDO7midUsv2j/UO4AFzvUIq 5DuOVGGPxjwEtCSubpqbP4mr6naoCe8zspeVaaeL6Sqdk3J1n63ITapFKBQZ8V1RLHwZ 2sJuPmH95VcOHfNcCjDYKTOrG/H4XrXx9DIYqLQgB5lta9DSee5ijcf1aOIkbAAH7oVj /CfZLD3gSRM7w8BH6gB9iSjrdZAfrlwESoP5KvJUvntmKA4gSJCFOKMPEOw+M5IOnwCT GN4MGnw1wqa3S6jslYczIoD2BEb1zL7fkAzaRcJF62Dr0Md4gVvKMmmqmVSTfvPmtp25 8SrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717653420; x=1718258220; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=67dVbFD/2DQF9usMWt43fKDwppvEBt20ndKl7bU0GFw=; b=DD0mGrYk722cDaSzOSAwO1n7+Ywhxolt+7uOHvRFWFHY2LYZmntLtmqNqrLoIIm+XS zN9ggZ3/h/HzWVy+UXcHAvaFs7awPkXx/Efv+42t6CPyguIZWJCjdxE/fQ1b8cOj7uZb ArOEe4tbQ7H6kx6HUkoKCpp7zRF3u7yq3EM/CximEKi7SN7pCn6+oSi6AaArIGSjgSo+ nY3+77vmYqDqeAbAJrfK9RLvpi+CfKMyPv6tPrSu1HhAmrypLYrPmlRnKBN0b9Nz2ffJ I1hLvnPkEq2mlyvuSJr/XyvpaJPjxO4KQNSHpfyWJdSETJhF9j43fReFrR6UlnrIlIJk mxmw== X-Forwarded-Encrypted: i=1; AJvYcCVqtZUqPkA0RhnbMAUI23CKXtwBAarqqIgIhAQq/sqhHDozxhjugVdSKvHjQxx0X4KvBpQD2NyIDypsHgaegkI9lYMzNFUw2Ig0ELKZxi/KI+EJT5V/jn3D42IFEW9lO+ckrO2o X-Gm-Message-State: AOJu0YzncbuPzLcE9zwiEewbY/cSrP3krrEXOY63aAqAIWK2bJVoT72+ Me7M7KKzBQ8l3KSLQj+vGeOodauLunUxgIHfvJjtcWn2O4uAwDzdhODWgpqkmx76eA52jJTqupD k0lhRLbd/ZGSo3jY8JYtOdDDjbeU= X-Received: by 2002:a5d:58ce:0:b0:35e:61b9:3037 with SMTP id ffacd0b85a97d-35ef0c7281amr1250796f8f.7.1717653420153; Wed, 05 Jun 2024 22:57:00 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240602173247.12651-1-eladwf@gmail.com> <20240605194305.194286d8@kernel.org> In-Reply-To: <20240605194305.194286d8@kernel.org> From: Elad Yifee Date: Thu, 6 Jun 2024 08:56:49 +0300 Message-ID: Subject: Re: [PATCH net-next v5] net: ethernet: mtk_eth_soc: ppe: add support for multiple PPEs To: Jakub Kicinski Cc: Felix Fietkau , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Daniel Golle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 6, 2024 at 5:43=E2=80=AFAM Jakub Kicinski wro= te: > > On Sun, 2 Jun 2024 20:32:40 +0300 Elad Yifee wrote: > > struct mtk_mac { > > int id; > > + u8 ppe_idx; > > I thought Daniel's suggestion was to remove this field. > I don't see your rebuke to that point or how it's addressed in the code. > Also it would be good if you CCed Daniel, always CC people who gave you > feedback. I talked to Daniel in private, I should have done that publicly. Relying solely on ifindex%ppe_num could potentially lead to more than one GMAC assigned to the same PPE. Since the ingress device could be a non mtk type, I added that sanity check= . I think the additional field is a small price to keep things clear and simp= le. (sorry for the previous HTML tags)