Received-SPF: pass (google.com: domain of linux-kernel+bounces-203639-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <664cca91-8615-d3f6-7525-15b9b6725cce@quicinc.com>
Date: Thu, 6 Jun 2024 11:41:19 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450
To: Stephen Boyd <sboyd@kernel.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@linaro.org>
CC: Michael Turquette <mturquette@baylibre.com>,
        Rob Herring
	<robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Vinod Koul <vkoul@kernel.org>,
        Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Taniya Das
	<quic_tdas@quicinc.com>,
        Jagadeesh Kona <quic_jkona@quicinc.com>,
        Imran Shaik
	<quic_imrashai@quicinc.com>,
        Satya Priya Kakitapalli
	<quic_skakitap@quicinc.com>
References: <20240528114254.3147988-1-quic_ajipan@quicinc.com>
 <20240528114254.3147988-8-quic_ajipan@quicinc.com>
 <ssnyujhgz64mbxawb43okjkdidd3tbxwjob36ikgbogy64xuqv@ckvir5vfqo63>
 <63d35ddacc113598f1822486b882552a.sboyd@kernel.org>
Content-Language: en-US
From: Ajit Pandey <quic_ajipan@quicinc.com>
In-Reply-To: <63d35ddacc113598f1822486b882552a.sboyd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 5/30/2024 1:18 AM, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2024-05-28 06:23:27)
>> On Tue, May 28, 2024 at 05:12:53PM +0530, Ajit Pandey wrote:
>>> Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
>>>
>>> Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
>>> ---
>>>   drivers/clk/qcom/Kconfig        |   9 +
>>>   drivers/clk/qcom/Makefile       |   1 +
>>>   drivers/clk/qcom/gpucc-sm4450.c | 805 ++++++++++++++++++++++++++++++++
>>>   3 files changed, 815 insertions(+)
>>>   create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
>>
>> [trimmed]
>>
>>> +
>>> +     /* Keep some clocks always enabled */
>>> +     qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */
>>> +     qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */
>>> +     qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
>>
>> I pinged Stephen regarding these clocks. LGTM otherwise.
>>
> 
> Looks OK to me. I assume that these clks don't get turned off when the
> GPU power domain is turned off. If that's the case then presumably we
> would need to turn these on and off during power transitions.

Yes, these clocks will not get turned off with GPU power domain 
transitions hence explicit on and off isn't required.

-- 
Thanks, and Regards
Ajit