Received-SPF: pass (google.com: domain of linux-kernel+bounces-203692-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <66615c6f.050a0220.2ba5cb.9c15SMTPIN_ADDED_BROKEN@mx.google.com>
Received-SPF: Fail (protection.outlook.com: domain of sony.com does not
 designate 121.100.38.198 as permitted sender)
 receiver=protection.outlook.com; client-ip=121.100.38.198;
 helo=gepdcl09.sg.gdce.sony.com.sg;
Date: Thu, 6 Jun 2024 12:20:40 +0530
From: Sreenath Vijayan <sreenath.vijayan@sony.com>
To: Petr Mladek <pmladek@suse.com>
Cc: john.ogness@linutronix.de, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, rdunlap@infradead.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        taichi.shimoyashiki@sony.com, daniel.palmer@sony.com,
        anandakumar.balasubramaniam@sony.com
Subject: Re: [PATCH] printk: Rename console_replay_all() and update context
References: <66582edb.650a0220.8de7.c591SMTPIN_ADDED_BROKEN@mx.google.com>
 <ZlmPAZUeKIDFKLdf@pathway.suse.cz>
 <Zl7Lo5eGJKLjbTUc@pathway.suse.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zl7Lo5eGJKLjbTUc@pathway.suse.cz>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 06:51:13.0596
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: d093c78b-f195-4d0d-4bf8-08dc85f50e93
X-MS-Exchange-CrossTenant-Id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=66c65d8a-9158-4521-a2d8-664963db48e4;Ip=[121.100.38.198];Helo=[gepdcl09.sg.gdce.sony.com.sg]
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-CH1PEPF0000AD83.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB4987

On Tue, Jun 04, 2024 at 10:09:07AM +0200, Petr Mladek wrote:
> On Fri 2024-05-31 10:49:08, Petr Mladek wrote:
> > On Thu 2024-05-30 13:15:47, Sreenath Vijayan wrote:
> > > Rename console_replay_all() to console_try_replay_all() to make
> > > clear that the implementation is best effort. Also, the function
> > > should not be called in NMI context as it takes locks, so update
> > > the comment in code.
> > > 
> > > Fixes: 693f75b91a91 ("printk: Add function to replay kernel log on consoles")
> > > Fixes: 1b743485e27f ("tty/sysrq: Replay kernel log messages on consoles via sysrq")
> > > Suggested-by: Petr Mladek <pmladek@suse.com>
> > > Signed-off-by: Shimoyashiki Taichi <taichi.shimoyashiki@sony.com>
> > > Signed-off-by: Sreenath Vijayan <sreenath.vijayan@sony.com>
> > 
> > Thanks for the fix.
> > 
> > Reviewed-by: Petr Mladek <pmladek@suse.com>
>  
> > PS: I am going to queue it for 6.11. It is not critical
> >     to hurry it into 6.10-rcX.
> 
> JFYI, the patch has been comitted into printk/linux.git,
> branch for-6.11.
>

Ok, thank you for the update.
 
> BTW:
> 
> I have pushed a patch which came to my mailbox with ID
> 
>    66582edb.650a0220.8de7.c591SMTPIN_ADDED_BROKEN@mx.google.com
> 
> >From some reasons, it is not available in the official archive
> at lore.kernel.org. Instead, I have mentioned in the commit
> message
> 
>      https://lore.kernel.org/r/Zlguq/wU21Z8MqI4@sreenath.vijayan@sony.com
> 
> which points to the same patch (same changes), exists at
> lore.kernel.org but I havn't got that one from some reason.
> 
> Best Regards,
> Petr

Understood.

Regards,
Sreenath