Received-SPF: pass (google.com: domain of linux-kernel+bounces-203703-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <33403007-c14e-4cd5-95a3-e78f88488840@amd.com>
Date: Thu, 6 Jun 2024 12:34:22 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v3 4/4] dt-bindings: net: cdns,macb: Deprecate
 magic-packet property
Content-Language: en-GB
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Rob Herring <robh@kernel.org>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
 linux@armlinux.org.uk, vadim.fedorenko@linux.dev, andrew@lunn.ch,
 netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240605102457.4050539-1-vineeth.karumanchi@amd.com>
 <20240605102457.4050539-5-vineeth.karumanchi@amd.com>
 <20240605154112.GA3197137-robh@kernel.org>
 <241cb8ec-14c9-4d7c-9331-2df0b8bf21b2@amd.com>
 <979b8f74-321d-4b83-bd3b-01643b3cbc35@linaro.org>
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <979b8f74-321d-4b83-bd3b-01643b3cbc35@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?clFWVldPQjlYN2pmM2FTZEtxZjczZGl1eG1xU1dMV1dSbndsWW9xM1IvZVlY?=
 =?utf-8?B?UUJ2VHpFb1Z4MGtsYjJIUkxWV1lBellza2ZmUnE2eGo2NW04UE55VzNqaHVQ?=
 =?utf-8?B?WlpnbmVGMWtkL2xzVmlsVnRreVdCZmp4VDdMcWJrT0preitaM1lrbEZ1QVVZ?=
 =?utf-8?B?bkQ2ZTRsVC9NODc0R2VMNThjSjQ3cXgyU210TkFxNnM2akdpWDA3WDk0QWlN?=
 =?utf-8?B?UlhmSzEreTJGTm42WmhKV3dZellRN0dhczBBelp6U3BPMHN4VzNQV0lWcDEv?=
 =?utf-8?B?L0UxODhMOU1NV3ZKRXJmblM5ZDg2Ly9IZzAyRmlLakowVjJNM2VkU1ZleGF1?=
 =?utf-8?B?ZlBETWtxT3RER2dJUVN0eEhtL3QrTXFHdFEvQmsxdFExRmFMOEc0cjg5MzhO?=
 =?utf-8?B?OG4zT2xwbHgwUWtvek01ejdORE5xekxJbms1S1JMUk5ycmRGOEYwNy9qcC9N?=
 =?utf-8?B?UFQxcVdhQ2RCZHptbGhkYmxWVkxKTVBkaTZIMFFlWHhFdDhoY1B6cmRqWHFO?=
 =?utf-8?B?NU1Jam56aEhKWFlNenNoT0tSYzgrWUdkSm9lc3QzdncrbGswSjRMOHFCKzk0?=
 =?utf-8?B?Q3JVL0NUaU01ckJzM2h0OHRZTEZ0TjBBU2lXYW9pZnNaRjAyMit2WWlTSHlD?=
 =?utf-8?B?dWtFNWNyRkpRdVBLREpsQjBKbE1PMzllUGlncEdtckN6cFBGMUZZam9tKys2?=
 =?utf-8?B?a1FmU09DNi9DZVZkWHZ5OHk4dWpNSTV1MGxmZmJtVnZCMWZYUmI0VmttQkMz?=
 =?utf-8?B?Y3NWaGtaMFNJSjlLL2lHaVFZc1NEQkp4amRCT09qTW9uRUdEYXRONnpLWWVv?=
 =?utf-8?B?WWZQYTkyaFJtNlI1VmFQTWpiSDJYMVJSWWtqZmJnSk1JaDhOUThSOVJCc3JS?=
 =?utf-8?B?WGRVNVArM083YXExV29tTmhVQytYUlpOUWNBSTNSaFpyb2JCamgzWXF2MDl5?=
 =?utf-8?B?aUV5aVFORUdnb25GaGJKQ3hZMW9PQVliQXhZSk1sVGo4RXpuN2dIc1BIYnhJ?=
 =?utf-8?B?TzBMaFpjRkQwRFdROXNLWTVJRDlvcnIzU0JXeGdzVkI1dWdpQVJkMDJmQWRO?=
 =?utf-8?B?QjNwK2cvdjlwSEZ2UCtnZHBTSmZmZ29TcE9JZ3dhOWNZZ1F6bm85azA5N0Jt?=
 =?utf-8?B?Y0p2ZklKQXhycnpzQzFEWlgxRGpkS0RGNE9zQ1U4TkVZTEV3YlB0SnZlSWpo?=
 =?utf-8?B?aEJzWVhhY003ZXBzTXJFMGJqWXdhUjhEQWcxa1VuOSt5S2xnUU80WGF1NkZ6?=
 =?utf-8?B?aGZ6eG9ZQkxiZEM0ZTNTWm5xRmZZNDZ2bnRmSjdweEFoeiszdk5QRi9VWk9m?=
 =?utf-8?B?b0lzNU1BNzBSRVF2N2p5alNFUklEbHNKR2hsK2NzbkQxUEhsak1JV3l6ajFj?=
 =?utf-8?B?dVdWdUZ3RWlsdVVadFZjajZkajBSemRyTS9IblBqemZWM3ByT0JxZWxIelE4?=
 =?utf-8?B?OENvRTdCc0R2Q0ozYzM0Z01wVlkvT1FYc21QblFSeFZVUm9aQ1B0TVhiZ1Ir?=
 =?utf-8?B?aVN6cFBEZmcrYkE1Smw4UW5Ma3NjZ1RhckJvQ0R3V0JWT1hOSGJMcUV6Nkpr?=
 =?utf-8?B?aHVFZFRKdmZ5RitqNXZHbzVjdE9zRE83VVIxRXFvQmhGTFR0TWlJTzl5QUtR?=
 =?utf-8?B?Q0RiQ0hVOE93NEJINldNZ1BEeWQzVURWZThIcTlKbThMZW9sUVVrRFg4cmsz?=
 =?utf-8?B?SlRVYzJpZVlJckxxeGtBZDNIV3dETUdtaUZUKzA2KzRQZ0lrQm05T2EwZXZh?=
 =?utf-8?B?cmRsYy84MllETDlPUmdIR29GNEJzbkljVmVJRFVGbWh6Uzg5eEZSR01DL255?=
 =?utf-8?B?MmdPNS85cW1xbHVrdkZwVkJZU05pYVhOa0p2K0ZhVkh1Wnkxck16RERPR09B?=
 =?utf-8?B?K1VOcFN0QndmL3R6OEdRREZzaktxb0xJQnd3STl6VmJSS2lmMVFzYzJKbWFY?=
 =?utf-8?B?VFhLY0cwUjRmc0NYckg3dzVENm5lZkJoWXZORGFmaFBNV2thWGFHQXZLUjJU?=
 =?utf-8?B?WE85UzVibmRHRkZsbmFXSDdrYlBIczVDajJLVkZXZHZ1YmJld2F5ZVlYcElk?=
 =?utf-8?B?ZUwyLzAyZ1JMRkZuZ2tiaEZjbzJ3QVV5MVpKTDhTYU5yeFJrL1hXOGE5V2o0?=
 =?utf-8?Q?JfGVXY7tou7rJgQ2XTROr3jxR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f75ddaa-450f-4676-0ea4-08dc85f6eb3b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 07:04:33.8006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EObeFUfElPeAn3zbedT43LFr/Lfmhw4276HaGZIucQnhZ5LzbfC23RMNMwfAWMP3
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB6015


On 06/06/24 11:47 am, Krzysztof Kozlowski wrote:
> On 06/06/2024 07:13, Vineeth Karumanchi wrote:
>> Hi Rob,
>>
>>
>> On 05/06/24 9:11 pm, Rob Herring wrote:
>>> On Wed, Jun 05, 2024 at 03:54:57PM +0530, Vineeth Karumanchi wrote:
>>>> WOL modes such as magic-packet should be an OS policy.
>>>> By default, advertise supported modes and use ethtool to activate
>>>> the required mode.
>>>>
>>>> Suggested-by: Andrew Lunn <andrew@lunn.ch>
>>>> Signed-off-by: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
>>>> ---
>>>>    Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>
>>> You forgot Krzysztof's ack.
>>>
>>
>> There is a change in the commit message from earlier version,
>> as we are not using caps any more, I thought of not including the ack.
>>
>> I will add his ack in next version.
> 
> And where is it mentioned that you drop someone's ack on purpose?
> 

sorry, mybad, I missed it mentioning in version history.
I will make a note of it.

???? vineeth

> Best regards,
> Krzysztof
>