Received-SPF: pass (google.com: domain of linux-kernel+bounces-203617-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Ben Walsh <ben@jubnut.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Benson Leung <bleung@chromium.org>, Guenter Roeck <groeck@chromium.org>,
 "Dustin L. Howett" <dustin@howett.net>, Kieran Levin <ktl@frame.work>,
 Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>, Mario Limonciello
 <mario.limonciello@amd.com>, chrome-platform@lists.linux.dev,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] platform/chrome: cros_ec_lpc: MEC access can use
 an AML mutex
In-Reply-To: <ZmEpOQmzFv7Quakq@google.com>
References: <20240605063351.14836-1-ben@jubnut.com>
 <20240605063351.14836-3-ben@jubnut.com> <ZmEpOQmzFv7Quakq@google.com>
Date: Thu, 06 Jun 2024 06:23:30 +0100
Message-ID: <8734pqskz1.fsf@jubnut.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Tzung-Bi Shih <tzungbi@kernel.org> writes:

> A nit haven't caught in previous round review:
>
> - `if (ret)` for cros_ec_lpc_mec_lock().
> - `if (ret < 0)` for cros_ec_lpc_mec_unlock().
>
> If I see the inconsistency when reading the code, it would take me further
> cycles for seeking why.  We should fix it.
>
> No need to resend for this; I will fix it for you.

Oh yes. Thanks very much for fixing, and for reviewing!