Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp214600lqt; Thu, 6 Jun 2024 01:02:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWcWJu3X4fSeJGIYuAvpcYGGNTlc6ozK43c2Cugx+flJr9YYM43zjeiaIfKCSKVKYGegUio7gyZJVijXELicC2sIZDGRX6Xd+Q6ntwCYA== X-Google-Smtp-Source: AGHT+IEK07/Eu7hvcaE9mu9SD3TItgkWmFff1SwSwdbBgbZ0kcGQrgPVrF0P21r86TKgWt8tQpcp X-Received: by 2002:a17:90a:1283:b0:2c1:ff35:78f5 with SMTP id 98e67ed59e1d1-2c27db13b16mr5091473a91.15.1717660978136; Thu, 06 Jun 2024 01:02:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717660978; cv=pass; d=google.com; s=arc-20160816; b=V1HMpH6XLfuC73MEHsJazXtIW+j3q20gBUlEHkLYRauLr3mR6dEnwcsWZOrVveFgh4 GKeP5wZec8U8btTdgIhAyStf5fQASUpxnALTq2kWYmajq0YiGpZbDcZL8ObBFd+hd0t7 FHP9FRfVX5pvtOMz+glihnVfzY0G5HBmDHEquTR90zm8aFLZpwgKEGzUXEQHuCoqwwqT M/cfchtQ3B9cA3NTpDFsG1CKK+kHyXNeUudAmlCTs64lE9x4NJQI8Hiu8isenPn0iUqu GEiDuQpLychk/BFbsXxB16/g446imWwPtz+9QMFRpxtl2eRcYqkHGcUoOI64ZvILF1GT ArdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=oR7QEbzuGGqHtCAKwX6ZwPB6N9sGKg9wqTlE3MkaejM=; fh=QdKBasrkzDvC5O18RtmnT/giLJkddQsBGNUm+P0GMCk=; b=BbyhfxRlBU1jp8AsdoxMlLfVftb/430PC9ZjF4FlfzHN2fNV02GJ+/gXgil1mkPnVw dTCLqs67WM9jpDP/gRjXw2pQ4V4iePhQMqVdAo3Hz3o/p3n4JseED7KhPMnThDOjWhK2 PCnyi2ndj8seqrYaXEawD97GcyUFJ9LxVCZWbS3SlpPDkKF+Ma8TletsV25GSvyYbQ9y Ztvov98dTfB2sTlaS3OIEY3RnXnOtXWxm3gONrHtp5nYGXdWlbxoo8OGIaUep74nDSUM yFhdXPKRmTAzJdrAskwb7gQCD1N8K/8+msmUQhPkSPClwYr4e1myqjmnMAc0z1a28seA yyDw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-203776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203776-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c280661fcfsi2466635a91.41.2024.06.06.01.02.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 01:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-203776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203776-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8101CB24EA5 for ; Thu, 6 Jun 2024 08:00:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0BC513C913; Thu, 6 Jun 2024 07:59:21 +0000 (UTC) Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B9F013C83C for ; Thu, 6 Jun 2024 07:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717660761; cv=none; b=AlWVVE/rDByBzxvSCrfaIxKhhRSdNav2uT8YYYad92mGkBNa4p2+J+hmfde/dY3/9fhgNSyXIHoyM6Hr0CtRwT843+WDYwH6gnj1ggBWfZgLPctoOqOCYeuPNNOzEZTivFwC81oghhOkEWfVUZ2r5+AEPCc8iJbpEh7zF/uy/cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717660761; c=relaxed/simple; bh=uooDHpHJFWI6jV3hynKp8KvY2m93hNxujsxOR1uVsBk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=JlaWAfJ8k3AtXem0pXIQxAKqyMVUFclkJ3PTRNH9h6BeiuE7ppdSfQDP/qOZVLFfXlPhqGiCerCcdHgNtMimPxUyY6hDJKMnYFLfMwXjii/XdqxgOdaE6xlzEbSzm1Fz/r5IvRQcjX85tdzgwe2mBNVCkllZOTD54LjHhvInoBs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: a79610b823da11ef9305a59a3cc225df-20240606 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:b18f9f8c-2039-4090-b582-3a6fc4c2f8a9,IP:25, URL:0,TC:0,Content:-5,EDM:25,RT:0,SF:-1,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:44 X-CID-INFO: VERSION:1.1.38,REQID:b18f9f8c-2039-4090-b582-3a6fc4c2f8a9,IP:25,UR L:0,TC:0,Content:-5,EDM:25,RT:0,SF:-1,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:44 X-CID-META: VersionHash:82c5f88,CLOUDID:6242702a3fbea42b9ae4b3f3e5dc454a,BulkI D:240606155911IJGA8PEG,BulkQuantity:0,Recheck:0,SF:25|72|19|44|66|102,TC:n il,Content:0,EDM:5,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL :0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NAME IP_TRUSTED, SRC_TRUSTED, DN_TRUSTED, SA_UNTRUSTED, SA_UNFAMILIAR SN_UNTRUSTED, SN_UNFAMILIAR, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS CIE_BAD, CIE_GOOD, CIE_GOOD_SPF, GTI_FG_BS, GTI_RG_INFO GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-UUID: a79610b823da11ef9305a59a3cc225df-20240606 X-User: pengfuyuan@kylinos.cn Received: from localhost.localdomain [(116.128.244.171)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 301779591; Thu, 06 Jun 2024 15:59:09 +0800 From: pengfuyuan To: Liviu Dudau Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, pengfuyuan , k2ci Subject: [PATCH] arm/komeda: Compile DEFINE_SHOW_ATTRIBUTE() only when CONFIG_DEBUG_FS is enabled Date: Thu, 6 Jun 2024 15:58:46 +0800 Message-Id: <20240606075846.1307007-1-pengfuyuan@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We do not call komeda_debugfs_init() and the debugfs core function declaration if CONFIG_DEBUG_FS is not defined, but we should not compile it either because the debugfs core function declaration is not included. Reported-by: k2ci Signed-off-by: pengfuyuan --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index 14ee79becacb..7ada8e6f407c 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -21,6 +21,7 @@ #include "komeda_dev.h" +#ifdef CONFIG_DEBUG_FS static int komeda_register_show(struct seq_file *sf, void *x) { struct komeda_dev *mdev = sf->private; @@ -43,7 +44,6 @@ static int komeda_register_show(struct seq_file *sf, void *x) DEFINE_SHOW_ATTRIBUTE(komeda_register); -#ifdef CONFIG_DEBUG_FS static void komeda_debugfs_init(struct komeda_dev *mdev) { if (!debugfs_initialized()) -- 2.25.1