Received-SPF: pass (google.com: domain of linux-kernel+bounces-203858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Aleksandr Mishin <amishin@t-argos.ru>, Oleksij Rempel
	<o.rempel@pengutronix.de>
CC: Bjorn Andersson <andersson@kernel.org>, Mathieu Poirier
	<mathieu.poirier@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer
	<s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, "linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>, "imx@lists.linux.dev"
	<imx@lists.linux.dev>, "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "lvc-project@linuxtesting.org"
	<lvc-project@linuxtesting.org>
Subject: RE: [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while
 remapping optional addresses in imx_rproc_addr_init()
Thread-Topic: [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue
 while remapping optional addresses in imx_rproc_addr_init()
Thread-Index: AQHat+a79vxV3edsLU+70+T7X0ErILG6acbw
Date: Thu, 6 Jun 2024 08:42:21 +0000
Message-ID:
 <AM6PR04MB59415AC28EBEE2821142CCC988FA2@AM6PR04MB5941.eurprd04.prod.outlook.com>
References: <20240606075204.12354-1-amishin@t-argos.ru>
In-Reply-To: <20240606075204.12354-1-amishin@t-argos.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?4dEx/ON+AsoDQFPgVIMYLu09yHRkTLx9dlOxB570RffHZO1DQghoxKjNeha9?=
 =?us-ascii?Q?FTscvMEWpIUwTulZvwzieJWF1Wpoj9qFGu60tNh3DRFN9y18eh37hwenBu/l?=
 =?us-ascii?Q?SjxeyNttJyu4Zlb7zqEdNrXqbN02vLhUJcXMMyV35owu4ACKHenJy0rCZ+7h?=
 =?us-ascii?Q?xzt3M1bxZokgTiZuFSAa0R8WHLjYBPCJtZLQSYfWeolu0e3x8AZRBOFmr9Q+?=
 =?us-ascii?Q?A4KDW9tJly3jzzW+38LxGVM6hZiVe4udmMKKMEXv6mW7V4yAQqv5mRWF8lbW?=
 =?us-ascii?Q?v/8xkO9Ds0swLQFVRPhRQYyIH2c3rVhKfvsmkwj7N3791zqCIB8HxqKo6M5j?=
 =?us-ascii?Q?VrvPJmvT1fpYkOEljBrs5Y2J90/CCM+mqJ+GkMyCL6CePsoaD0in9ehYYhwC?=
 =?us-ascii?Q?dK6L6w+ffyii+L1eUX///1CvyoKbtJNpFBNkkzExrH8HTJtwTPPzIEaJDB+J?=
 =?us-ascii?Q?quGT2ZfbMBS53zZFzAyzV7HO81fd9gwPQsF3Dkmgo+ZjQt2KoeWBbyW2WHwV?=
 =?us-ascii?Q?nsNNOjzkWPJFVrsWDbjpghNdoekOax8AcN/hi2mI9C1hGVyHlzLdQfmDIft6?=
 =?us-ascii?Q?e9+ZaVKiMp0znDAIt438TY4A+YFci/A7HQrieNOuG3ye7LnvY/m3Me8hO7Pv?=
 =?us-ascii?Q?KLWp/Nqr7uCmdU6cZJePiIWuz9XHKpP3hEoZJm8pOun6G8PztVk2oFybMrDK?=
 =?us-ascii?Q?H6a7+RliUR4C+mO3QgbMvqdASYGkQNxoNxazEIzFjnpa4qpEqBLmmGMRINe6?=
 =?us-ascii?Q?w+No0b5qGTrAB4qzNimh3xm4XvMDeff5lIEynj6Qulu6bPmgfRoJNzr19Sqe?=
 =?us-ascii?Q?De4p7EZ/LX2Z8FWR3zL/yPd+wIRU6gGc5GRtZ0ZuhidGYS4DvV3xE3xfTbJv?=
 =?us-ascii?Q?Tbk54qD/AOyDo+VztTfkrr/PhlaAdFqvVyx/cJXSaLHyK3jdSiHLA4L4SnBr?=
 =?us-ascii?Q?aIRBbBf0mzSCZlu5860TVEhgcoBkkv1u+PUWDX1F7AezIjsYqyhwdljT+8GR?=
 =?us-ascii?Q?tGo3BpZJZ94BAIkfjA2Xt5tkjDdpqG4JEDx8jDUZ7CiJBlWgCZXi2+Ej/Rra?=
 =?us-ascii?Q?+yTQgLe83OKkalmtjCKy80QmJW+qXodCYd3hvVsD/GXgDfMTKVKlW1LGES/w?=
 =?us-ascii?Q?ESxXJTVBn926HcH204g7ZeRGvEL/mXnbOjlQe9kTx2MMmclzbQ9oir1ShFw+?=
 =?us-ascii?Q?eENqZsN3AlrluuFIux70441ZmZ91jTmONyi742++W6vGshDp8WLn5f8y25Go?=
 =?us-ascii?Q?iWgLmCvOtNBjQnlGRaQKDLFFqZsfRhnCCO17YsDaLRGKkoOl80oNpbkA6AgD?=
 =?us-ascii?Q?bmsr+CJ0hpblpa+kLNe6rYzFkz+be6L2eQomNQsRXyAKk9aa6TmcIdvslmGQ?=
 =?us-ascii?Q?PyguvGo+Z0T7nXwE3DBDEHOkQTq5xqaBOosG5/JmIVgDowS1rtcmz8RWzfMT?=
 =?us-ascii?Q?IoKkMhDsLFpEOXW/6BNO+0pUpByYicEfORx1Xw0vNxCCI46wRE/YSkIcG136?=
 =?us-ascii?Q?p5x6hsG4wMtu7kuu++2lgaFOJ47l4jc7tLgu9afi8WqGGjga1W0LRIsb/MB5?=
 =?us-ascii?Q?yC7NZySevv01tBgh+LQ=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5941.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4e5bb1b9-49d4-4816-ecfa-08dc860494ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jun 2024 08:42:21.2109
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: p8v1hFP2RfXh5xabcB0aRpgqtg/J49TrUMpuejWTsgkQbHA/7VxfP8j8Cx3a8RWF68ilWTVIdSyFnOEmGJmvRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9723

Hi Aleksandr,

> Subject: [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue whil=
e
> remapping optional addresses in imx_rproc_addr_init()
>=20
> In imx_rproc_addr_init() "nph =3D of_count_phandle_with_args()" just coun=
ts
> number of phandles. But phandles may be empty. So of_parse_phandle() in
> the parsing loop (0 < a < nph) may return NULL which is later dereference=
d.
> Adjust this issue by adding NULL-return check.

It is good to add a check here. But I am not sure whether this will really
happen.

>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20
> Fixes: a0ff4aa6f010 ("remoteproc: imx_rproc: add a NXP/Freescale imx_rpro=
c
> driver")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>

Anyway LGTM:
Reviewed-by: Peng Fan <peng.fan@nxp.com>

Thanks,
Peng.