Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp238192lqt; Thu, 6 Jun 2024 02:00:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW8HBGuah4La/RXnhU99f439ByjHEPcKsyM6nrVYB982LFjQzT70w4FUQOriupw9b7i/qk4ESYkbnRJDt8jTBsSmLPTsJfk25gi8k7fdg== X-Google-Smtp-Source: AGHT+IG00EQ7Bdz7XnVidS++wBBNdgoySvdRb4R6aNMtqZsgd/KRoXCNECiitm6aUdt0i5eTWpQz X-Received: by 2002:a05:6214:46a1:b0:6ae:2da4:fd81 with SMTP id 6a1803df08f44-6b030a3d924mr57899916d6.45.1717664402878; Thu, 06 Jun 2024 02:00:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717664402; cv=pass; d=google.com; s=arc-20160816; b=xe71FNrn6bOhJ6bTvnZ0G8g/zxGdddmAhBMXiG77aQhFuuhFtWtjQCBs7bdX2D5dKA 6D6zuI+o8K4w+xH32FyJn7OBHMTyftu04i510AcSGjpoOEWFD3pA6v8p3lI8HlVQp4G8 HNJOPICFa4CBGy7Cu0uE0IGBjSFWYQW/oazqAUhjWeCWUKmK7qI7N1ta8QJeiy5KoiVc F4577JApxgYNaTq4EDwgYjgf8azKIoSYsmmoNHashcVW5jMxbOM0IblgXFikxzx00Lkg WLH6N/+kobfidwccECvaWs1GXoOErwWUiFRtABhd87xE1Z8tsm0PPTjxP8LBB/VDUbR6 HCLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=4FtmV0ABVc9h1JGHDwXx8rQU8EB+sDESacURohrmJjQ=; fh=xpoQVmrQSZpN3CPEFDk03EkFlnnuNVrhFp3Ynb61HGk=; b=rkFu6+2IgtuwHRegOpU56w1g7AUw4NA6hx3IYMWAPuW6iOuZANFUY0Sbq038+k4kyB enmPF5J+4+JNmIVDBeWlLqm3dDNSb+Zq8FbU8RtLmketlw6NYYm59XUaNl4BL7DIgF+e z7yOGcgJxolklXQChnrT3Fpx9m25zhu5bz7x8LmtSN4aQd3sSlGG1AB46g0Wlnycr13u SWXHdcVE6lWTScg4zgw3ORlzYgPFIXtgoi7TdbhwxM3petiqyUEayDVVOpI+XAspmF1Y 12gG7aAHJyFgNRJ2aYxu0GSs1RSj87VHid6ERFmjnA/xLqdd19R4EGKxihgH7fI7FNxh zpLw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-203904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203904-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6b04f967d66si10195976d6.255.2024.06.06.02.00.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 02:00:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-203904-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203904-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 30BBD1C253E6 for ; Thu, 6 Jun 2024 09:00:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 205C0154443; Thu, 6 Jun 2024 08:55:02 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [91.198.224.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4629513D8AE; Thu, 6 Jun 2024 08:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.198.224.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664101; cv=none; b=HuKmF2IbXiAVg8woW+7MoBCpeYX7Bk1uJfuNYNc+YGbNKb/849WpZ/DDRM/UNHMp7VwEmsA3kOkV2kW9kzUtkLDHvEW5Z4hqnVfOUAwSNzjcK/67rU75AP6oeg60NAkQTWVMbkPn/odCAMNM4f7eNIGZHb4nnvij0lyvgwXYMkM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664101; c=relaxed/simple; bh=KYnzf2IvAqkR+TMZf28aEgu6bpbKnDGL8pVsCkiQRq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e+zIFN0hmFol8Ai66kWCGap/u8pJGTA3uzxpi9Ybv0t74ALJpra/NrJFaGeyjF5RQWWV5sKiJgVOIrGvwlV8T3HUt5V2FRyExY5+7mAYZfSyqURN0rmpa7fxM3UOLA+5vBJjMGxlfEBSNLQoK+M5m288JKGdZDEq7x8dPBgsInI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=91.198.224.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sF8te-00EUz7-7r; Thu, 06 Jun 2024 10:54:58 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF8td-00EK6Z-MQ; Thu, 06 Jun 2024 10:54:57 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 6C6B9240053; Thu, 6 Jun 2024 10:54:57 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 03993240050; Thu, 6 Jun 2024 10:54:57 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id ACCFC379F6; Thu, 6 Jun 2024 10:54:56 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Schiller Subject: [PATCH net-next 11/13] net: dsa: lantiq_gswip: Fix comments in gswip_port_vlan_filtering() Date: Thu, 6 Jun 2024 10:52:32 +0200 Message-ID: <20240606085234.565551-12-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240606085234.565551-1-ms@dev.tdt.de> References: <20240606085234.565551-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1717664098-EEC7DADA-81332706/0/0 From: Martin Blumenstingl Update the comments in gswip_port_vlan_filtering() so it's clear that there are two separate cases, one for "tag based VLAN" and another one for "port based VLAN". Suggested-by: Martin Schiller Signed-off-by: Martin Blumenstingl --- drivers/net/dsa/lantiq_gswip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index 3c96a62b8e0a..f2faee112e33 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -786,7 +786,7 @@ static int gswip_port_vlan_filtering(struct dsa_switc= h *ds, int port, } =20 if (vlan_filtering) { - /* Use port based VLAN tag */ + /* Use tag based VLAN */ gswip_switch_mask(priv, GSWIP_PCE_VCTRL_VSR, GSWIP_PCE_VCTRL_UVR | GSWIP_PCE_VCTRL_VIMR | @@ -795,7 +795,7 @@ static int gswip_port_vlan_filtering(struct dsa_switc= h *ds, int port, gswip_switch_mask(priv, GSWIP_PCE_PCTRL_0_TVM, 0, GSWIP_PCE_PCTRL_0p(port)); } else { - /* Use port based VLAN tag */ + /* Use port based VLAN */ gswip_switch_mask(priv, GSWIP_PCE_VCTRL_UVR | GSWIP_PCE_VCTRL_VIMR | GSWIP_PCE_VCTRL_VEMR, --=20 2.39.2