Received: by 2002:ab2:6309:0:b0:1fb:d597:ff75 with SMTP id s9csp239482lqt; Thu, 6 Jun 2024 02:02:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU58HWoAR41kVLPdHsa3XI3jMgClnntO9MbeaDZd2AJC/epSmHdqZ0kE2AJUvOo5Z6z/ZAeqDf0hK6JlCZDHWKFswvp/Rk0hQMNexDjFA== X-Google-Smtp-Source: AGHT+IFohy+bjuQ4Sns1LtBUBlNp0YR0z6Pn72iWfpXDTUxezDFJv6Pa6iW+pfVuJYinal1+orbu X-Received: by 2002:a17:906:4942:b0:a69:52a:8d7d with SMTP id a640c23a62f3a-a699fac162bmr360599366b.40.1717664522494; Thu, 06 Jun 2024 02:02:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717664522; cv=pass; d=google.com; s=arc-20160816; b=0AYBMjfAbnUQQ5eU81sOK9SEkt8+dAooizoSPTo/TPLz90Whw+U7wLkDcW1TACvMS2 V1ZPhqYhnEKNGdHsqW+HlyOzC2piCXFYKQyMu/IAWQBzr84tpIbicwJQMKcuW68M+DQB 4F6FnrK6V201bp+ghDLlAt5U7ICXjwfJbNDSzuXMB4JhGTeUAphio9UDzhUrGbERsEd3 aBREHSpZhIexEWSalHxJS77jqgquwuUgFOmtOn8i2UIYOyys0abpLVG/emyyQmoos9Ir QjMhLtokG4bCFOMBZtGnyWDrWSABEaAPvHA9VG//Iv1RDHLSAz0maaSV+/lGZP1mJOV9 SZdg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=73G5i3Z6YzhdF1dKn6DqSj/1oVY3HolerwQQsBrCreo=; fh=v3SCYaeCJa93a+n0Uxo5VFFPo3sWNiBtrk6VU3AZNuM=; b=FlyjO0zM4NLWHwZAuWZrvx2O81yWNOaWVcLx0cjvPmdjFEL/SYAu6bThmmrtziCC8Q 96Vi7AWIezTpVySI6i01LwAAP7/M4nQK85MaGxt0mcGU766KUstrZYRqq2Gd2H4F9KI2 4QBIH0Tj3D5iv8wqRPO9ofWAKs2Qb/Vwp/0WS3308MUegf1sySwyhNS40swGfw0fvrpZ E0/OC2zroeKbd19LJsfzjnbrNYDVduA/X2neZlsZJ9fNl7rZCKFkg/RiCjjwq+94XAwd rp+Td3xpGBckK6RgDOPatmkcTaJUDbtv3camwjvkTXttj71uWxtmq9g8p1nCaapF/6oi iIZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-203910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203910-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6c8072a36fsi45880166b.881.2024.06.06.02.02.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jun 2024 02:02:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-203910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=dev.tdt.de); spf=pass (google.com: domain of linux-kernel+bounces-203910-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-203910-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 063F91F27788 for ; Thu, 6 Jun 2024 09:02:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE4E7155C97; Thu, 6 Jun 2024 08:55:11 +0000 (UTC) Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA016155A46; Thu, 6 Jun 2024 08:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664111; cv=none; b=rcIvhXjm4YmCSpeNpcIjJO1JaD+Utv6vaKRcjM5ayGtmXXZHh54UvVX56dqV9c1bkRVjxLcmfNBhnxYAByR9vxGfVDaUGNAsnwAWWCXtAOsoR53a4LbcWbCO+vHb/RJXuaoNshfcMApVxnoTlexTgINfwWWZ8MwSa06u2XdJTsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717664111; c=relaxed/simple; bh=Bn8X3b011v9yLue7/qfY2gNcWkxvqcOkHg5uIA94qxA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GEZwRN/E0U74yySJX+8pOhY1gImNRmI5r65qsb/9L/KphWf2DM1tczuItJyqFhhS4ASC4O2UJMEB6D936i+pkbQ6RV1ahwuPztQJVD/uI8WVMaSr5LFQIDqlwZEtHG6HHdJU/hj8SKeZpzB1GE6ghdZiViJBL4DiemZz6oiHqbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1sF8tn-003wJX-S1; Thu, 06 Jun 2024 10:55:07 +0200 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF8tn-008x2v-AZ; Thu, 06 Jun 2024 10:55:07 +0200 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 0EF2A240053; Thu, 6 Jun 2024 10:55:07 +0200 (CEST) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 996C3240050; Thu, 6 Jun 2024 10:55:06 +0200 (CEST) Received: from mschiller1.dev.tdt.de (unknown [10.2.3.20]) by mail.dev.tdt.de (Postfix) with ESMTPSA id 6D083379F6; Thu, 6 Jun 2024 10:55:06 +0200 (CEST) From: Martin Schiller To: martin.blumenstingl@googlemail.com, hauke@hauke-m.de, andrew@lunn.ch, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 13/13] net: dsa: lantiq_gswip: Improve error message in gswip_port_fdb() Date: Thu, 6 Jun 2024 10:52:34 +0200 Message-ID: <20240606085234.565551-14-ms@dev.tdt.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240606085234.565551-1-ms@dev.tdt.de> References: <20240606085234.565551-1-ms@dev.tdt.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate-ID: 151534::1717664107-834B4642-90B4C736/0/0 X-purgate: clean From: Martin Blumenstingl Print the port which is not found to be part of a bridge so it's easier to investigate the underlying issue. Signed-off-by: Martin Blumenstingl --- drivers/net/dsa/lantiq_gswip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswi= p.c index 4bb894e75b81..69035598e8a4 100644 --- a/drivers/net/dsa/lantiq_gswip.c +++ b/drivers/net/dsa/lantiq_gswip.c @@ -1377,7 +1377,8 @@ static int gswip_port_fdb(struct dsa_switch *ds, in= t port, } =20 if (fid =3D=3D -1) { - dev_err(priv->dev, "Port not part of a bridge\n"); + dev_err(priv->dev, + "Port %d is not known to be part of bridge\n", port); return -EINVAL; } =20 --=20 2.39.2