Received-SPF: pass (google.com: domain of linux-kernel+bounces-203920-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 6 Jun 2024 14:30:37 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Primoz Fiser <primoz.fiser@norik.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, upstream@lists.phytec.de
Subject: Re: [PATCH] cpufreq: ti-cpufreq: Handle deferred probe with
 dev_err_probe()
Message-ID: <20240606090037.2v3sl72rjfzzk4k7@vireshk-i7>
References: <20240606065847.3499145-1-primoz.fiser@norik.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240606065847.3499145-1-primoz.fiser@norik.com>

On 06-06-24, 08:58, Primoz Fiser wrote:
> Handle deferred probing gracefully by using dev_err_probe() to not
> spam console with unnecessary error messages.
> 
> Fixes: f88d152dc739 ("cpufreq: ti: Migrate to dev_pm_opp_set_config()")
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
>  drivers/cpufreq/ti-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/ti-cpufreq.c b/drivers/cpufreq/ti-cpufreq.c
> index 714ed53753fa..5af85c4cbad0 100644
> --- a/drivers/cpufreq/ti-cpufreq.c
> +++ b/drivers/cpufreq/ti-cpufreq.c
> @@ -417,7 +417,7 @@ static int ti_cpufreq_probe(struct platform_device *pdev)
>  
>  	ret = dev_pm_opp_set_config(opp_data->cpu_dev, &config);
>  	if (ret < 0) {
> -		dev_err(opp_data->cpu_dev, "Failed to set OPP config\n");
> +		dev_err_probe(opp_data->cpu_dev, ret, "Failed to set OPP config\n");
>  		goto fail_put_node;
>  	}

Applied. Thanks.

-- 
viresh