Received-SPF: pass (google.com: domain of linux-kernel+bounces-203946-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Javier Carrasco <javier.carrasco@wolfvision.net>
Date: Thu, 06 Jun 2024 11:03:56 +0200
Subject: [PATCH 2/3] usb: typec: tipd: add error log to provide firmware
 name and size
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240606-tps6598x_fw_update_log-v1-2-2b5b8369a0ba@wolfvision.net>
References: <20240606-tps6598x_fw_update_log-v1-0-2b5b8369a0ba@wolfvision.net>
In-Reply-To: <20240606-tps6598x_fw_update_log-v1-0-2b5b8369a0ba@wolfvision.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>, 
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, 
 Javier Carrasco <javier.carrasco@wolfvision.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TzhlVkVDUC9mS1VYbTZVY2tHLzd3TVhKWXhoUE94anBSZk51TGlYKzdNekFV?=
 =?utf-8?B?QWNaRm5UdkdZLzdpT1l2SSttTzB0NVgzV056NmpqMzJINDhqdFN4MVAzNnV3?=
 =?utf-8?B?UnBlM1F4WGxuL2J3OWY1ZmJjNktaa3pIdXBPY2szNU1FUGRaWHAyWU01WTdW?=
 =?utf-8?B?dzFTc1NrS29lYjlHVTBvS3B4OUNWUGVaaTEvVnRuTExtYVh6MG9JNEZ3eEQ1?=
 =?utf-8?B?YVlQbWhYSURZZWJ4dGREc2dSbnBzQlJydUVQRG5heFFJU2duVGVycHFzUTMr?=
 =?utf-8?B?SXB0WkpUVEQwRFB4R2ljQm50aHZUYUM4amtZNndYaVg2WGJmOG9xWFhSSFdj?=
 =?utf-8?B?OTZvaWZaQzFDdDV5UFJZVVJ6ZTRZbWhhODFINmppTFVTaXhMMHhodmthR3l1?=
 =?utf-8?B?SUorODZLcnFsUWpUVUo1TGVFUmN1WmNoYnJOdXdNU0F0aW9ETnNxZHRoTUdI?=
 =?utf-8?B?K0QzVUFNMWdscGJiQzVSamNidUc4ei9WVnphKzM3NzA0THlaUG9tNkZSRFVM?=
 =?utf-8?B?WlBlZ1hzcCtRTjF1SU5rM2IzeUhHaG5yWTczbjJlYm5ycVV5a21IWllsZmkv?=
 =?utf-8?B?TFNyMXozUzJsbDRINlJmUUFDMFN3VVZyL3l6NkRJQ2w3WFlUK056d1lTYkRq?=
 =?utf-8?B?TUlFbVRpbjdRL1hBK3hxWkdrNWZjOVJmdjZXVVo0NE5tRk9xdjV4bFdWdHZR?=
 =?utf-8?B?LzNLUUxWVlJGWTJ1d2F4Qkd2TElacWdwZERpZElIYThyazFpRUV4eVpYbGQy?=
 =?utf-8?B?M2htc1A2QkQzbmlQSkxMdW9LV3ZRU2ZVMEFXZmpTMlA4SGZLS3Y3QUpyNWhP?=
 =?utf-8?B?akpqeU42L3F2MEUzdE5qdk5ocjZVbUJIU3gyTmlpNzFjYVNHQ0FYWGRlRDBU?=
 =?utf-8?B?bUNKYU1OSTJ4SXpZOGIycVM4Qk11eVA4ZC9PZVpYcEJuanFTb21ObUltTGZE?=
 =?utf-8?B?bitFYjJnWDBwaFpyb3RpZWxWVUxSWE4vb3ZhU1pHQkZFUnRKMERuSWdyYXpS?=
 =?utf-8?B?QnBPOEhDQ293dGhleHYrUEk1ekt2Q2p1QXptbmZOV21BSkI3NU1kbWsxYktm?=
 =?utf-8?B?dUFHSnM2UWZhcHBUb1RwNVp1Q1cxUEs3YTdlNVJpLy96RFdjempIYXVHM1ZY?=
 =?utf-8?B?WXVUZzZieUV4T2E2SXg4a01WYmRHZk5NWFRmaHJBd0tiLzVDTExXSEEvU2pP?=
 =?utf-8?B?MHZQM0JLelR1WEY0L0M1UXRTR1JNcW1DMmZYNXVQdGhRY3FvMllUUjdzeG9o?=
 =?utf-8?B?QUxuNk9xVUkrcjI2V1d0WnU1eXJDY1hDTHJGNUFPMWx6MnJnd0JjdStDbS9l?=
 =?utf-8?B?Y2lWdURmU3Z0OWloQlRtaTE0MnNrOEdPL3I0a0Ira21pZmJIL3R1QkNFNFpi?=
 =?utf-8?B?cWVDUjNqdEhFR3BpYWh5MWhNME5OdWg1TTRtWFNQTEJnd2ZndldKUGN5aXR1?=
 =?utf-8?B?RUdQQWhRc3JWMWQ3eUFLU2JMZzlLMVNOOW56R2xETk00aStvdkx2dlhBdmRa?=
 =?utf-8?B?aWp1amdSNnArUnRZM0ZjMUdCbWE0SS8xQTFmQVI4NlJtbUdiQmJ3K0JFS2px?=
 =?utf-8?B?aE54WWRLdXFtOVRjUFM3MjZWRmNGc2lwTWtkLzN4TzdQZFpvbzdOLytiSWE1?=
 =?utf-8?B?YURBUHVYQ05YVDltRlRoN0F4Um1UaGN2b2pydzJTWEtjWmVaQ2J1OEdtSnNN?=
 =?utf-8?B?Y2hRK0hGTkVJYnRFSENGUktHd3NYYzNMTmtvK1JkNVYxQ1B1ek9qQU1zVnpO?=
 =?utf-8?B?OTNtTUdWNXVPYWFqdG5rUGp3dlB2cjdubUV1elN2NVQ0QzV4TkFnQ0ZpcWpS?=
 =?utf-8?B?Qk9xY3R5bE9IWlVGTmNkenZnUFhzWm13WnBWYk1jS3VmQWV3ZGdRd0FnUXJZ?=
 =?utf-8?B?L3JvUlNqUk9PVFJxSlVYbkxNejUwVXhtZGhQUDdud2hOUmgyNWk1NVhzSUVL?=
 =?utf-8?B?TW56RjltUjRrYTdkclpMaUs3MFhXamxoTEhuUndiZFFSUG1IMGIzaVN1aG5a?=
 =?utf-8?B?dkVGQ0w3ZmJkUmNoU29NdUhUa1JZWWw1eVdYWTRhR01KaHVNMmNJSFgvZnY0?=
 =?utf-8?B?QnAreFREczdOYmwzd1JjYVhLaHBZUFdkZ0tZckk3bE9MVVJ6aTdHL3VBV3Vq?=
 =?utf-8?B?Sy93MUR0QjNQVXhPMXdNY1p3WERoRm5jU1hKTXRSU2FYZjZjRkVDZGFwakhs?=
 =?utf-8?Q?1DAoF3OIBVhVGmjtPU3Wl4o=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 7501ae53-f733-4cd1-069b-08dc86079d2d
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 09:04:04.0570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QnupOk8Y7g0SqtjlwufvtXey6sqeZSIKO+sM6wVBdMBd3tQV8PWvQFgta1vVS8nAIy3XrksKnwkItSqK0nYDoIBYj0vHu8NI/epQ/ZWnTz8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9513

The current error logs do not show the firmware name and size for the
tps6598x. On the other hand, this information is provided for the
tps25750. Both implementations have access to that information, and the
existing message for the tps25750 can be used for the tps6598x without
extra modifications.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/usb/typec/tipd/core.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 851b0d02727a..58f6eeffd070 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -1195,6 +1195,10 @@ static int tps6598x_apply_patch(struct tps6598x *tps)
 
 release_fw:
 	release_firmware(fw);
+	if (ret) {
+		dev_err(tps->dev, "Failed to write patch %s of %zu bytes\n",
+			firmware_name, fw->size);
+	}
 
 	return ret;
 };

-- 
2.40.1